From: sashiko-bot@kernel.org
To: "Kuppuswamy Sathyanarayanan"
<sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 4/6] PCI/portdrv: Don't require AER to bind DPC service
Date: Tue, 20 Oct 2026 18:34:33 +0000 [thread overview]
Message-ID: <sashiko-outbox-179482@kernel.org> (raw)
In-Reply-To: <20261020181924.3003553-5-sathyanarayanan.kuppuswamy@linux.intel.com>
> get_port_device_capability() binds the DPC service only if
> pci_aer_available() is true. pci_aer_available() is false with
> "pci=noaer" or when MSI is disabled.
>
> The DPC driver does not need either of these. pci_aer_available()
> depends on MSI only because the AER driver does not work with INTx
> (commit 3e77a3f7895e ("PCI: Disable AER with pci=nomsi")). The DPC
> driver does not depend on MSI or on the AER driver, and it works on
> ports without an AER capability.
>
> PCIe r7.0 sec 6.2.11 recommends that the OS link control of DPC to
> control of AER. PCI Firmware r3.3, sec 4.5.2.4, requires the same for
> _OSC. Both are about ownership, not about using the AER driver.
> host->native_aer and the _OSC negotiation already cover ownership.
>
> [ ... ]
> uncorrectable error that used to be ignored with "pci=noaer" now
> triggers DPC, which takes the link down and resets the devices below
> the port.
>
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261020181924.3003553-1-sathyanarayanan.kuppuswamy@linux.intel.com?part=4
next prev parent reply other threads:[~2026-10-20 18:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 18:19 [PATCH v2 0/6] PCI/DPC: Decide DPC ownership with host_bridge->native_dpc Kuppuswamy Sathyanarayanan
2026-10-20 18:19 ` [PATCH v2 1/6] PCI/DPC: Avoid access to non-existent AER capability Kuppuswamy Sathyanarayanan
2026-10-20 18:29 ` sashiko-bot
2026-10-20 18:19 ` [PATCH v2 2/6] PCI/DPC: Reinstate support for AER-incapable ports Kuppuswamy Sathyanarayanan
2026-10-20 18:27 ` sashiko-bot
2026-10-20 18:19 ` [PATCH v2 3/6] PCI/EDR: Remove CONFIG_PCIE_EDR Kuppuswamy Sathyanarayanan
2026-10-20 18:30 ` sashiko-bot
2026-10-20 18:19 ` [PATCH v2 4/6] PCI/portdrv: Don't require AER to bind DPC service Kuppuswamy Sathyanarayanan
2026-10-20 18:34 ` sashiko-bot [this message]
2026-10-20 18:19 ` [PATCH v2 5/6] PCI/ACPI: Request DPC control only together with AER control Kuppuswamy Sathyanarayanan
2026-10-20 18:33 ` sashiko-bot
2026-10-20 18:19 ` [PATCH v2 6/6] PCI/portdrv: Bind DPC service based on host_bridge->native_dpc Kuppuswamy Sathyanarayanan
2026-10-20 18:36 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-179482@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.