From: sashiko-bot@kernel.org
To: "Omar Elghoul" <oelghoul@linux.ibm.com>, linux-s390@vger.kernel.org
Cc: "Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH v10 2/5] s390/pci: Reuse FMB buffer across enable and disable cycles
Date: Tue, 20 Oct 2026 22:35:53 +0000 [thread overview]
Message-ID: <sashiko-outbox-179548@kernel.org> (raw)
In-Reply-To: <20261020212427.2561-3-oelghoul@linux.ibm.com>
> Allocate the FMB once upon first enable and keep it for the lifetime of
> the zdev instead of freeing it on every disable. Track the enablement
> state in the new statistics_on bool, since a non-null FMB no longer
> implies that measurement is enabled. Defer freeing the buffer until
> device teardown in zpci_release_device().
>
> Drop the alignment warning after allocating the FMB buffer due to it
> already being guaranteed by the kmem_cache.
>
> Audit the only consumer of the FMB (pci_perf_show) and update its
> liveness check to be aware of this change.
>
> Signed-off-by: Omar Elghoul <oelghoul@linux.ibm.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261020212427.2561-1-oelghoul@linux.ibm.com?part=2
next prev parent reply other threads:[~2026-10-20 22:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 21:24 [PATCH v10 0/5] vfio-pci/zdev: Improved zPCI Function Measurement Support Omar Elghoul
2026-10-20 21:24 ` [PATCH v10 1/5] s390/pci: Hold fmb_lock when enabling or disabling PCI devices Omar Elghoul
2026-10-20 22:35 ` sashiko-bot
2026-10-20 21:24 ` [PATCH v10 2/5] s390/pci: Reuse FMB buffer across enable and disable cycles Omar Elghoul
2026-10-20 22:35 ` sashiko-bot [this message]
2026-10-20 21:24 ` [PATCH v10 3/5] s390/pci: Improve function measurement state management Omar Elghoul
2026-10-20 22:53 ` sashiko-bot
2026-10-20 21:24 ` [PATCH v10 4/5] s390/pci: Fence FMB enable/disable via debugfs for passthrough devices Omar Elghoul
2026-10-20 22:33 ` sashiko-bot
2026-10-20 21:24 ` [PATCH v10 5/5] vfio-pci/zdev: Add VFIO FMB device features Omar Elghoul
2026-10-20 22:46 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-179548@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=oelghoul@linux.ibm.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.