Re: [PATCH 1/2] [v4] serial: 8250: remove obsolete PORT_RSA support

[sashiko-bot@kernel.org]

> From: Arnd Bergmann <arnd@arndb.de>
> 
> For all I can tell, the RSA support in the 8250 driver is not functional
> and has not been for a long time.
> 
> The RSA-DV II/S ISA card[1] was sold by IODATA in the 1990s as a faster
> alternative to regular ISA serial ports, and it was discontinued in
> 2002. Linux support was added by Kiyokazu SUTO in 2000[2]. The company
> also made PCI versions of this device, but Linux never supported those.
> 
> It seems that a patch to setserial would be required in order to set
> PORT_RSA when not using autoconfiguration, and this was never merged.
> Autotoconfiguration in turn requires passing probe_rsa=IOPORT arguments
> at boot or module load time, which is not how any other uart drivers
> work any more since linux-2.4.
> 
> This patch removes all code related to the RSA support, with the exception
> of the user-visible PORT_RSA definition. I had originall sent this in
> 2011 [3], but did not follow up at the time.
> 
> Link: http://www.iodata.jp/products/network/rsadv2s.htm [1]
> Link: https://pub.ks-and-ks.ne.jp/prog/linux/rsa.en.shtml [2]
> Link: https://lore.kernel.org/all/1309211120-2803-6-git-send-email-arnd@arndb.de/ [3]
> Cc: Kiyokazu SUTO <suto@ks-and-ks.ne.jp>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261021081746.3278002-1-arnd@kernel.org?part=1