Re: [PATCH] leds: mlxreg: Fix missing fan LEDs on systems reporting a unit count

[sashiko-bot@kernel.org]

> From: Vadim Pasternak <vadimp@nvidia.com>
> 
> LED platform data is shared between systems of the same family, and the
> driver registers only the LED instances that are actually present on the
> running system. The platform data entry names a capability register and
> a bit in it, and an entry whose bit is clear is skipped.
> 
> The capability registers are a single byte wide, so a bitmap cannot
> describe more than eight units, which is not enough for systems with ten
> fan drawers. Recent CPLD revisions therefore report a count of the units
> present instead of a bitmap, and do so uniformly rather than only where
> the bitmap would overflow, leaving no per unit bit to test. Platform
> data describes such an entry by its 'slot', the one based index of the
> unit the LED belongs to, and leaves 'bit' at zero.
> 
> [ ... ]
> 
> Fixes: 783259e9b19d ("platform: mellanox: Introduce support of Nvidia smart switch")
> 
> Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
> Signed-off-by: Felix Radensky <fradensky@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261021142824.603605-1-fradensky@nvidia.com?part=1