From: sashiko-bot@kernel.org
To: "Sebastian Reichel" <sebastian.reichel@collabora.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH v18 2/7] phy: rockchip: usbdp: Add reset hook support for dwc3
Date: Wed, 21 Oct 2026 18:20:07 +0000 [thread overview]
Message-ID: <sashiko-outbox-180548@kernel.org> (raw)
In-Reply-To: <20261021-b4-rockchip-dwc3-rockchip-glue-v18-2-60000d03fca2@collabora.com>
> When TCPM (Type-C Port Manager) triggers a orientation or mux
> change, the PHY needs to reset. This results in the PHY no longer
> providing a clock to the USB controller. If the USB controller
> registers are accessed without the clock, SErrors are generated.
>
> This can be avoided by switching the clock provider for the USB
> controller. But after switching the clock, the USB PHY sometimes does
> not succeed to lock its "cmn ana lcpll" PLLs again. I suspect this is
> due to a clock glitch and after some debugging figured out that this
> can be avoided by disabling the USB controller's PIPE interface while
> the PHY reset is ongoing.
>
> Implement an API that allows the USBDP to actively request a reset
> from DWC3 as a quirk.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261021-b4-rockchip-dwc3-rockchip-glue-v18-0-60000d03fca2@collabora.com?part=2
next prev parent reply other threads:[~2026-10-21 18:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 18:05 [PATCH v18 0/7] usb: dwc3: introduce Rockchip glue driver Sebastian Reichel
2026-10-21 18:05 ` Sebastian Reichel
2026-10-21 18:05 ` Sebastian Reichel
2026-10-21 18:05 ` [PATCH v18 1/7] phy: rockchip: usbdp: Track PHY power state Sebastian Reichel
2026-10-21 18:05 ` Sebastian Reichel
2026-10-21 18:05 ` Sebastian Reichel
2026-10-21 18:10 ` sashiko-bot
2026-10-21 18:05 ` [PATCH v18 2/7] phy: rockchip: usbdp: Add reset hook support for dwc3 Sebastian Reichel
2026-10-21 18:05 ` Sebastian Reichel
2026-10-21 18:05 ` Sebastian Reichel
2026-10-21 18:20 ` sashiko-bot [this message]
2026-10-21 18:05 ` [PATCH v18 3/7] usb: dwc3: rockchip: introduce glue driver Sebastian Reichel
2026-10-21 18:05 ` Sebastian Reichel
2026-10-21 18:05 ` Sebastian Reichel
2026-10-21 18:12 ` sashiko-bot
2026-10-21 18:05 ` [PATCH v18 4/7] usb: dwc3: core: add post PHY registration hook for platform glue Sebastian Reichel
2026-10-21 18:05 ` Sebastian Reichel
2026-10-21 18:05 ` Sebastian Reichel
2026-10-21 18:10 ` sashiko-bot
2026-10-21 18:05 ` [PATCH v18 5/7] usb: dwc3: rockchip: add USBDP PHY reset quirk Sebastian Reichel
2026-10-21 18:05 ` Sebastian Reichel
2026-10-21 18:05 ` Sebastian Reichel
2026-10-21 18:35 ` sashiko-bot
2026-10-21 18:35 ` sashiko-bot
2026-10-21 18:05 ` [PATCH v18 6/7] usb: gadget: define stub for usb_udc_vbus_handler Sebastian Reichel
2026-10-21 18:05 ` Sebastian Reichel
2026-10-21 18:05 ` Sebastian Reichel
2026-10-21 18:13 ` sashiko-bot
2026-10-21 18:05 ` [PATCH v18 7/7] usb: dwc3: rockchip: fix USB-C reconnect in gadget mode Sebastian Reichel
2026-10-21 18:05 ` Sebastian Reichel
2026-10-21 18:05 ` Sebastian Reichel
2026-10-21 18:31 ` sashiko-bot
2026-10-21 18:31 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-180548@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.