Re: [PATCH net 1/2] net/rds: do not fail init when CONFIG_SYSCTL=n

[sashiko-bot@kernel.org]

> With CONFIG_SYSCTL=n, register_net_sysctl() and register_net_sysctl_sz()
> are inline stubs that return NULL.  rds_sysctl_init(),
> rds_ib_sysctl_init() and rds_tcp_init_net() all treat that NULL as
> -ENOMEM, so RDS refuses to initialize at all even though every tunable
> has a sane compiled-in default.
> 
> When RDS is built in, that is worse than a missing feature: the failed
> rds_init() destroys rds_wq, but the rds_rdma initcall still runs, and
> when rds_ib_sysctl_init() fails the same way, the error path in
> rds_ib_init() flushes the already freed workqueue:
> 
>   BUG: KASAN: slab-use-after-free in touch_wq_lockdep_map
>   ...
>    __flush_workqueue
>    rds_ib_init
> [ ... ]
> Fixes: e6babe4cc4ce ("RDS/IB: Stats and sysctls")
> Fixes: c6a58ffed536 ("RDS: TCP: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket")
> Suggested-by: Joel Granados <joel.granados@kernel.org>
> Assisted-by: LLM
> Signed-off-by: Allison Henderson <achender@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261021195837.142802-1-achender@kernel.org?part=1