Re: [PATCH 2/2] arm64: dts: imx8qm-tqma8qm: Re-enable A72 cluster after ERR050104 workaround

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] arm64: dts: imx8qm-tqma8qm: missing cpu1-thermal restore for A72 cluster
--

commit 187cd9d157965a8b6ed40b9b4b40d998a0f0385a
Author: Peng Fan <peng.fan@nxp.com>

arm64: dts: imx8qm-tqma8qm: Re-enable A72 cluster after ERR050104 workaround

This commit removes the /delete-node/ directives for cpu-map, cpu@100, and
cpu@101 in imx8qm-tqma8qm.dtsi to re-enable the Cortex-A72 cluster now that
the ERR050104 workaround has been merged.

> diff --git a/arch/arm64/boot/dts/freescale/imx8qm-tqma8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm-tqma8qm.dtsi
> index f0e398eb2aad7..8cd6e75eb87a9 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qm-tqma8qm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qm-tqma8qm.dtsi
> @@ -15,13 +15,6 @@ / {
>  	model = "TQ-Systems i.MX8QM TQMa8QM";
>  	compatible = "tq,imx8qm-tqma8qm", "fsl,imx8qm";
>  
> -	/* Due to missing workaround for ERR050104 */
> -	cpus {
> -		/delete-node/ cpu-map;
> -		/delete-node/ cpu@100;
> -		/delete-node/ cpu@101;
> -	};
> -

[Severity: High]
When commit 5d20f1ccb3393a ("arm64: dts: imx8qm-tqma8qm-mba8x: Disable
Cortex-A72 cluster") disabled cpu@100 and cpu@101 due to the missing
ERR050104 workaround, it also removed the thermal management configuration
for the Cortex-A72 cluster.

In arch/arm64/boot/dts/freescale/imx8qm-tqma8qm.dtsi, thermal_zones still
deletes cpu1-thermal and omits A72_0 and A72_1 from the pmic0-thermal
cooling-maps:

&thermal_zones {
	/delete-node/ cpu1-thermal;

	pmic0-thermal {
		...
		cooling-maps {
			map0 {
				trip = <&pmic_alert0>;
				cooling-device =
					<&A53_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
					<&A53_1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
					<&A53_2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
					<&A53_3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
			};
		};
	};
};

Deleting cpu1-thermal also leaves the cpu_alert1 and cpu_crit1 trip point
overrides in arch/arm64/boot/dts/freescale/imx8qm-tqma8qm.dtsi unused:

&cpu_alert1 {
	temperature = <95000>;
};

&cpu_crit1 {
	temperature = <100000>;
};

In addition, commit 5d20f1ccb3393a removed the cpu1-thermal active trip
points and fan0 cooling-maps from thermal-zones in
arch/arm64/boot/dts/freescale/imx8qm-tqma8qm-mba8x.dts.

Unlike companion commit 72b6162dd6e2 ("arm64: dts: imx8qm-mek: Re-enable A72
cluster after ERR050104 workaround"), which removed /delete-node/
cpu1-thermal alongside the /cpus deletions, booting a board using
imx8qm-tqma8qm.dtsi (such as imx8qm-tqma8qm-mba8x.dts) with this change
brings cpu@100 and cpu@101 online without cpu1-thermal (monitoring
IMX_SC_R_A72), leaving the A72 cluster without passive cpufreq throttling at
95 C, thermal shutdown at 100 C, pmic0-thermal alert throttling, or active
fan cooling under sustained load.

Should commit 5d20f1ccb3393a be reverted completely so that cpu1-thermal and
the A72 cooling maps are restored together with the Cortex-A72 CPU nodes?

>  	memory@80000000 {
>  		device_type = "memory";
>  		/*

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261022-8qm-v1-0-2a597cb3debd@nxp.com?part=2