From: sashiko-bot@kernel.org
To: "Zhang Yi" <zhangyi@everest-semi.com>, linux-sound@vger.kernel.org
Subject: Re: [PATCH] ASoC: codecs: es8375: Modify Register Configuration
Date: Thu, 22 Oct 2026 02:39:12 +0000 [thread overview]
Message-ID: <sashiko-outbox-180874@kernel.org> (raw)
In-Reply-To: <20261022023336.21653-1-zhangyi@everest-semi.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] ASoC: es8375: undeclared ES8375_VSEL2 and ES8375_LP_DAC in es8375_init()
--
commit 17c9435d23c86c411e36588d57fd84ba71d4892e
Author: Zhang Yi <zhangyi@everest-semi.com>
ASoC: codecs: es8375: Modify Register Configuration
This commit updates the clock divider table coeff_div[] and modifies the
register initialization sequence in es8375_init() for the ES8375 audio
codec.
> diff --git a/sound/soc/codecs/es8375.c b/sound/soc/codecs/es8375.c
> index bed872eafc955..501a3eda5a89b 100644
> --- a/sound/soc/codecs/es8375.c
> +++ b/sound/soc/codecs/es8375.c
[ ... ]
> @@ -543,18 +543,20 @@ static void es8375_init(struct snd_soc_component *component)
> regmap_write(es8375->regmap, ES8375_CLK_MGR4, 0x02);
> regmap_write(es8375->regmap, ES8375_CLK_MGR5, 0x05);
> regmap_write(es8375->regmap, ES8375_CSM1, 0x82);
> - regmap_write(es8375->regmap, ES8375_VMID_CHARGE2, 0x20);
> - regmap_write(es8375->regmap, ES8375_VMID_CHARGE3, 0x20);
> - regmap_write(es8375->regmap, ES8375_DAC_CAL, 0x28);
> - regmap_write(es8375->regmap, ES8375_ANALOG_SPK1, 0xFC);
> + regmap_write(es8375->regmap, ES8375_VMID_CHARGE2, 0x10);
> + regmap_write(es8375->regmap, ES8375_VMID_CHARGE3, 0x10);
> + regmap_write(es8375->regmap, ES8375_DAC_CAL, 0x2F);
> + regmap_write(es8375->regmap, ES8375_ANALOG_SPK1, 0xEC);
> regmap_write(es8375->regmap, ES8375_ANALOG_SPK2, 0xE0);
> regmap_write(es8375->regmap, ES8375_VMID_SEL, 0xFE);
> regmap_write(es8375->regmap, ES8375_ANALOG1, 0xB8);
> + regmap_write(es8375->regmap, ES8375_VSEL2, 0x05);
> + regmap_write(es8375->regmap, ES8375_LP_DAC, 0xCC);
[Severity: Low]
Are the register definitions for ES8375_VSEL2 and ES8375_LP_DAC missing from
sound/soc/codecs/es8375.h?
In sound/soc/codecs/es8375.c, es8375_init() adds regmap_write() calls using
ES8375_VSEL2 and ES8375_LP_DAC, but neither identifier is defined in
sound/soc/codecs/es8375.h:
#define ES8375_VMID_SEL 0x2D
#define ES8375_ANALOG1 0x2E
#define ES8375_ANALOG2 0x32
#define ES8375_ANALOG3 0x37
Will this cause a build regression with undeclared identifier errors when
compiling sound/soc/codecs/es8375.c with CONFIG_SND_SOC_ES8375 enabled?
[ ... ]
>
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261022023336.21653-1-zhangyi@everest-semi.com?part=1
next prev parent reply other threads:[~2026-10-22 2:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 2:33 [PATCH] ASoC: codecs: es8375: Modify Register Configuration Zhang Yi
2026-10-22 2:39 ` sashiko-bot [this message]
2026-10-22 2:56 ` Zhang Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-180874@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhangyi@everest-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.