All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Lin Wang" <wanglin@open-hieco.net>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v8 6/7] x86/amd_node: Restrict SMN setup to AMD CPUs
Date: Thu, 22 Oct 2026 07:49:50 +0000	[thread overview]
Message-ID: <sashiko-outbox-181136@kernel.org> (raw)
In-Reply-To: <20261022074218.667049-7-wanglin@open-hieco.net>

> amd_smn_init() also runs on Hygon because Hygon sets X86_FEATURE_ZEN.
> It reserves config space on the matching host-bridge roots and groups
> them by the CPU-derived node count. Hygon DF nodes are enumerated by
> PCI ID, CPU NodeIds are sparse, and the nodes in a socket share one SMN
> ingress, so the resulting root map is wrong on Hygon. These reservations
> also prevent the Hygon node layer from claiming roots for its own
> node-to-root mapping.
> 
> Hygon vendor matching has been removed from amd64_edac, amd_atl, and
> k10temp modules. The remaining users match AMD PCI IDs or check for an
> AMD CPU. With these changes in place, no in-tree Hygon driver uses the
> AMD SMN accessors.
> 
> Restrict SMN setup and root discovery to AMD CPUs.
> 
> Signed-off-by: Lin Wang <wanglin@open-hieco.net>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261022074218.667049-1-wanglin@open-hieco.net?part=6


  reply	other threads:[~2026-10-22  7:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22  7:42 [PATCH v8 0/7] x86/hygon: Add Family 0x18 DF node enumeration and SMN access Lin Wang
2026-10-22  7:42 ` [PATCH v8 1/7] x86/hygon: Add Family 0x18 DF node enumeration Lin Wang
2026-10-22  7:49   ` sashiko-bot
2026-10-24 15:15   ` Yazen Ghannam
2026-10-27  5:59     ` Lin Wang
2026-10-22  7:42 ` [PATCH v8 2/7] x86/hygon: Map CPU NodeIds to DF nodes Lin Wang
2026-10-22  7:56   ` sashiko-bot
2026-10-22  7:42 ` [PATCH v8 3/7] EDAC/amd64: Stop matching Hygon CPUs Lin Wang
2026-10-22  7:45   ` sashiko-bot
2026-10-22  7:42 ` [PATCH v8 4/7] RAS/AMD/ATL: Match AMD CPUs only Lin Wang
2026-10-22  7:46   ` sashiko-bot
2026-10-22  7:42 ` [PATCH v8 5/7] x86/amd_nb: Restrict the northbridge framework to AMD CPUs Lin Wang
2026-10-22  7:48   ` sashiko-bot
2026-10-22  7:42 ` [PATCH v8 6/7] x86/amd_node: Restrict SMN setup " Lin Wang
2026-10-22  7:49   ` sashiko-bot [this message]
2026-10-22  7:42 ` [PATCH v8 7/7] x86/hygon: Add Family 0x18 SMN access Lin Wang
2026-10-22  7:52   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-181136@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=wanglin@open-hieco.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.