From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4556B606A33D for ; Thu, 22 Oct 2026 13:42:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=TbAncWCa; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Xkx1gM5d DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=H88+bVx+n7eXJh4Cgkc9YmXAE3jGNLSpvnt2hfNYt8s=; b=TbAncWCaViZ07epQ/BFOqbRm5b 5QJCNrFE4UgMZc4KMnpuTRSrMl9Nbk6ch3LVjZnSdi0SVJUFLgAbwsCDxAeRd2orbpoDi6zyOhHwz abO/54/twY+VwRxgE2DUDzGAevXSJmZ52kYVjv2X+acr9EY17mxfqUl3d7jj053kb5oIFbjNiS4+i DVQhCfIkZ8GlGZmJnlEWli8RXjtplG7X6hiFrxhKM84U9nrfg/6PtliLQEbsbM2LaDJEEpwL9Wm1P Y+sDBCowKg4TP2lBdq8LXOgIikRWY3tPINIpf8L+OWJEhKnRnKAXICK/3rqWdbD9OVrRLgSqRNvfn m6SrFLkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xJt3N-0000000EE06-0S1s; Thu, 22 Oct 2026 13:41:57 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xJt3L-0000000EDzz-2dzz for linux-amlogic@lists.infradead.org; Thu, 22 Oct 2026 13:41:55 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id CB9D860018; Thu, 22 Oct 2026 13:41:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 191431F000C2; Thu, 22 Oct 2026 13:41:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792676514; bh=byINeMt3A+PO89GiAsGNR3UuXwrnKL5MmsK2RAyTqss=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Xkx1gM5duvKz40/m53Ukc1GNlUzzoFwrOxlH6ts1Bqoq+jPI9Sm6Z/Q2bOPj5SVlB UD6DWvw6ZraJho+Y69Pk1iCQCzCcXYAHr+Mvjr6C3o5Uoh2bEzjM8Z38vFRZrZceSX iHvzKgtjT3QaG1npKKrPXNDBk9rc30szzMTAhdM1nAcBBiLKEHaKGl+PK6hhXKzIhE t0pkRIBlvLjzOjXr0szzj4Ks/aYRZqbvSW+FKzuXymb7D9/zkZFYy2PMwATGxQ0u/G EqhrIVw7gce1nlXhhzI1gRjeDQurjAt1QgqnmQbpoLWGUh5smbhDa9VhwHYW14IdGp lQF4MqKbo51dA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 9/9] usb: typec: ucsi: huawei-gaokun: pass down HPD_IRQ events To: "Dmitry Baryshkov" Cc: dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-amlogic@lists.infradead.org, neil.armstrong@linaro.org In-Reply-To: <20261022-hpd-irq-events-v6-9-337ea3ddaa62@oss.qualcomm.com> References: <20261022-hpd-irq-events-v6-0-337ea3ddaa62@oss.qualcomm.com> <20261022-hpd-irq-events-v6-9-337ea3ddaa62@oss.qualcomm.com> Date: Thu, 22 Oct 2026 13:41:53 +0000 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIGRybS9tc20vZHA6IG1p c3NpbmcgY2xvc2luZyBicmFjZSBpbiBtc21fZHBfYnJpZGdlX2hwZF9ub3RpZnkoKQotIFtIaWdo XSBkcm0vbXNtL2RwOiBtc21fZHBfaHBkX3BsdWdfaGFuZGxlKCkgc2tpcHMgSFBEIGhpZ2ggcHJv Y2Vzc2luZyBhZnRlciBkZXRlY3QKLS0KCmNvbW1pdCA0MjAzNGY1NzBkMTIwNjU0ZDZhYTRlMDZi OWM1ODJlYjA2Y2IyZjVmCkF1dGhvcjogRG1pdHJ5IEJhcnlzaGtvdiA8ZG1pdHJ5LmJhcnlzaGtv dkBvc3MucXVhbGNvbW0uY29tPgoKZHJtL21zbTogZHA6IGhhbmRsZSB0aGUgSVJRX0hQRCBldmVu dHMgcmVwb3J0ZWQgYnkgVVNCLUMKClRoaXMgY29tbWl0IHVwZGF0ZXMgbXNtX2RwX2JyaWRnZV9o cGRfbm90aWZ5KCkgaW4gdGhlIG1zbSBEaXNwbGF5UG9ydCBkcml2ZXIKdG8gaGFuZGxlIERSTV9D T05ORUNUT1JfRFBfSVJRX0hQRCBldmVudHMgcmVwb3J0ZWQgdmlhIG91dC1vZi1iYW5kCm5vdGlm aWNhdGlvbnMuCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2RwL2RwX2Rpc3Bs YXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZHAvZHBfZGlzcGxheS5jCj4gaW5kZXggY2U5MTlh MjZmYmEyOC4uNmE4YjNiOGUxZmU3ZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNt L2RwL2RwX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZHAvZHBfZGlzcGxh eS5jCj4gQEAgLTE1NjYsMTEgKzE1NjYsMTMgQEAgdm9pZCBtc21fZHBfYnJpZGdlX2hwZF9ub3Rp Znkoc3RydWN0IGRybV9icmlkZ2UgKmJyaWRnZSwKPiAgCQlpZiAoaHBkX2xpbmtfc3RhdHVzID09 IElTUl9IUERfUkVQTFVHX0NPVU5UKSB7Cj4gIAkJCW1zbV9kcF9ocGRfdW5wbHVnX2hhbmRsZShk cCk7Cj4gIAkJCW1zbV9kcF9ocGRfcGx1Z19oYW5kbGUoZHApOwo+IC0JCX0gZWxzZSBpZiAoaHBk X2xpbmtfc3RhdHVzID09IElTUl9JUlFfSFBEX1BVTFNFX0NPVU5UKSB7Cj4gLQkJCW1zbV9kcF9p cnFfaHBkX2hhbmRsZShkcCk7Cj4gIAkJfSBlbHNlIHsKPiAgCQkJbXNtX2RwX2hwZF9wbHVnX2hh bmRsZShkcCk7Cj4gIAkJfQo+ICsKPiArCQlpZiAoaHBkX2xpbmtfc3RhdHVzID09IElTUl9JUlFf SFBEX1BVTFNFX0NPVU5UIHx8Cj4gKwkJICAgIGV2ZW50ID09IERSTV9DT05ORUNUT1JfRFBfSVJR X0hQRCkgewo+ICsJCQltc21fZHBfaXJxX2hwZF9oYW5kbGUoZHApOwo+ICAJfSBlbHNlIHsKPiAg CQltc21fZHBfaHBkX3VucGx1Z19oYW5kbGUoZHApOwo+ICAJfQoKW1NldmVyaXR5OiBIaWdoXQpJ cyB0aGVyZSBhIG1pc3NpbmcgY2xvc2luZyBicmFjZSBmb3IgdGhlIGlubmVyIGlmIHN0YXRlbWVu dCBpbgptc21fZHBfYnJpZGdlX2hwZF9ub3RpZnkoKSBpbiBkcml2ZXJzL2dwdS9kcm0vbXNtL2Rw L2RwX2Rpc3BsYXkuYz8KClRoZSBvcGVuaW5nIGJyYWNlIGFmdGVyIGNoZWNraW5nIElTUl9JUlFf SFBEX1BVTFNFX0NPVU5UIGFuZApEUk1fQ09OTkVDVE9SX0RQX0lSUV9IUEQgaXMgbmV2ZXIgY2xv c2VkIGJlZm9yZSB0aGUgZWxzZSBicmFuY2g6CgoJaWYgKHN0YXR1cyA9PSBjb25uZWN0b3Jfc3Rh dHVzX2Nvbm5lY3RlZCkgewoJCS4uLgoJCWlmIChocGRfbGlua19zdGF0dXMgPT0gSVNSX0lSUV9I UERfUFVMU0VfQ09VTlQgfHwKCQkgICAgZXZlbnQgPT0gRFJNX0NPTk5FQ1RPUl9EUF9JUlFfSFBE KSB7CgkJCW1zbV9kcF9pcnFfaHBkX2hhbmRsZShkcCk7Cgl9IGVsc2UgewoJCW1zbV9kcF9ocGRf dW5wbHVnX2hhbmRsZShkcCk7Cgl9CgpUaGlzIGxlYXZlcyB0aGUgb3V0ZXIgaWYgYmxvY2sgdW5j bG9zZWQsIGNhdXNpbmcgYSBidWlsZCBmYWlsdXJlIGF0IHRoZSBlbmQKb2YgZHJpdmVycy9ncHUv ZHJtL21zbS9kcC9kcF9kaXNwbGF5LmMgYXMgd2VsbCBhcyBwYWlyaW5nIHRoZQptc21fZHBfaHBk X3VucGx1Z19oYW5kbGUoZHApIGVsc2UgYnJhbmNoIHdpdGggdGhlIGlubmVyIGNoZWNrIGluc3Rl YWQgb2YKc3RhdHVzID09IGNvbm5lY3Rvcl9zdGF0dXNfY29ubmVjdGVkLgoKCmNvbW1pdCAxMTgy ZDdmMmYyZTg3NmM2M2RkNjc1NmRlMWY4NTIyNzcwMmI5M2I0CkF1dGhvcjogRG1pdHJ5IEJhcnlz aGtvdiA8ZG1pdHJ5LmJhcnlzaGtvdkBvc3MucXVhbGNvbW0uY29tPgoKZHJtL21zbS9kcDogZG9u J3QgdGFrZSBleHRyYSByZWZlcmVuY2VzIG9uIG11bHRpcGxlIHBsdWcgZXZlbnRzCgpUaGlzIGNv bW1pdCBhZGRzIGFuIGVhcmx5IHJldHVybiBpbiBtc21fZHBfaHBkX3BsdWdfaGFuZGxlKCkgd2hl bgpkcC0+cGx1Z2dlZCBpcyBhbHJlYWR5IHNldCBzbyBzZXF1ZW50aWFsIHBsdWcgZXZlbnRzIGRv IG5vdCB0YWtlIGV4dHJhCnJ1bnRpbWUgcG93ZXIgbWFuYWdlbWVudCByZWZlcmVuY2VzLgoKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9kcC9kcF9kaXNwbGF5LmMgYi9kcml2ZXJz L2dwdS9kcm0vbXNtL2RwL2RwX2Rpc3BsYXkuYwo+IGluZGV4IGZhODk0MjkyMmI1MzMuLmNlOTE5 YTI2ZmJhMjggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9kcC9kcF9kaXNwbGF5 LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2RwL2RwX2Rpc3BsYXkuYwo+IEBAIC00MTIs NiArNDEyLDkgQEAgc3RhdGljIGludCBtc21fZHBfaHBkX3BsdWdfaGFuZGxlKHN0cnVjdCBtc21f ZHBfZGlzcGxheV9wcml2YXRlICpkcCkKPiAgCj4gIAlndWFyZChtdXRleCkoJmRwLT5wbHVnZ2Vk X2xvY2spOwo+ICAKPiArCWlmIChkcC0+cGx1Z2dlZCkKPiArCQlyZXR1cm4gMDsKPiArCj4gIAly ZXQgPSBwbV9ydW50aW1lX3Jlc3VtZV9hbmRfZ2V0KCZwZGV2LT5kZXYpOwo+ICAJaWYgKHJldCkg ewo+ICAJCURSTV9FUlJPUigiZmFpbGVkIHRvIHBtX3J1bnRpbWVfcmVzdW1lXG4iKTsKCltTZXZl cml0eTogSGlnaF0KV2lsbCByZXR1cm5pbmcgZWFybHkgd2hlbiBkcC0+cGx1Z2dlZCBpcyB0cnVl IGluIG1zbV9kcF9ocGRfcGx1Z19oYW5kbGUoKQpjYXVzZSBtc21fZHBfZGlzcGxheV9wcm9jZXNz X2hwZF9oaWdoKCkgdG8gYmUgc2tpcHBlZCBhZnRlciBjb25uZWN0b3IKZGV0ZWN0aW9uPwoKRHVy aW5nIGNvbm5lY3RvciBwcm9iaW5nIGluCmRyaXZlcnMvZ3B1L2RybS9kaXNwbGF5L2RybV9icmlk Z2VfY29ubmVjdG9yLmM6ZHJtX2JyaWRnZV9jb25uZWN0b3JfZGV0ZWN0X2N0eCgpLApkZXRlY3Qt PmZ1bmNzLT5kZXRlY3QoKSBpcyBjYWxsZWQgYmVmb3JlIGRybV9icmlkZ2VfY29ubmVjdG9yX2hw ZF9ub3RpZnkoKToKCglpZiAoZGV0ZWN0KSB7CgkJc3RhdHVzID0gZGV0ZWN0LT5mdW5jcy0+ZGV0 ZWN0KGRldGVjdCwgY29ubmVjdG9yKTsKCQkuLi4KCQlkcm1fYnJpZGdlX2Nvbm5lY3Rvcl9ocGRf bm90aWZ5KGNvbm5lY3Rvciwgc3RhdHVzLAoJCQkJCQlEUk1fQ09OTkVDVE9SX05PX0VYVFJBX1NU QVRVUyk7Cgl9CgpXaGVuIGRldGVjdC0+ZnVuY3MtPmRldGVjdCgpIHJ1bnMgbXNtX2RwX2JyaWRn ZV9kZXRlY3QoKSBpbgpkcml2ZXJzL2dwdS9kcm0vbXNtL2RwL2RwX2Rpc3BsYXkuYywgaXQgcmVh ZHMgdGhlIHJlY2VpdmVyIGNhcGFiaWxpdGllcyBhbmQKc2V0cyBwcml2LT5wbHVnZ2VkID0gdHJ1 ZSB3aXRob3V0IGNhbGxpbmcgbXNtX2RwX2Rpc3BsYXlfcHJvY2Vzc19ocGRfaGlnaCgpOgoKCXJl dCA9IGRybV9kcF9yZWFkX2Rlc2MocHJpdi0+YXV4LCAmZGVzYywgZHJtX2RwX2lzX2JyYW5jaChk cGNkKSk7CglpZiAocmV0KSB7CgkJRFJNX0RFQlVHX0RQKCJmYWlsZWQgdG8gcmVhZCBkZXNjXG4i KTsKCQlwcml2LT5wbHVnZ2VkID0gZmFsc2U7CgkJZ290byBlbmQ7Cgl9CgoJc3RhdHVzID0gY29u bmVjdG9yX3N0YXR1c19jb25uZWN0ZWQ7Cglwcml2LT5wbHVnZ2VkID0gdHJ1ZTsKCldoZW4gZHJt X2JyaWRnZV9jb25uZWN0b3JfaHBkX25vdGlmeSgpIC0+IG1zbV9kcF9icmlkZ2VfaHBkX25vdGlm eSgpIC0+Cm1zbV9kcF9ocGRfcGx1Z19oYW5kbGUoKSB0aGVuIHJ1bnMgKG9yIHdoZW4gYSBzdWJz ZXF1ZW50IHBsdWcgbm90aWZpY2F0aW9uCmFycml2ZXMpLCBkcC0+cGx1Z2dlZCBpcyBhbHJlYWR5 IHRydWUsIHNvIG1zbV9kcF9ocGRfcGx1Z19oYW5kbGUoKSByZXR1cm5zIDAKaW1tZWRpYXRlbHkg d2l0aG91dCBjYWxsaW5nIG1zbV9kcF9kaXNwbGF5X3Byb2Nlc3NfaHBkX2hpZ2goKS4KCldpdGhv dXQgbXNtX2RwX2Rpc3BsYXlfcHJvY2Vzc19ocGRfaGlnaCgpLCBkcm1fZWRpZF9jb25uZWN0b3Jf dXBkYXRlKCkgaXMKbm90IGNhbGxlZCwgZHAtPnBhbmVsIGxpbmsgcGFyYW1ldGVycyByZW1haW4g dW5pbml0aWFsaXplZCwgYW5kCmRwLT5saW5rLT5zaW5rX2NvdW50IHN0YXlzIDAsIGNhdXNpbmcg bGluayBwcmVwYXJhdGlvbiB0byBmYWlsIHdpdGgKLUVOT1RDT05OLgoKLS0gClNhc2hpa28gQUkg cmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MTAyMi1ocGQtaXJx LWV2ZW50cy12Ni0wLTMzN2VhM2RkYWE2MkBvc3MucXVhbGNvbW0uY29tP3BhcnQ9OQoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYW1sb2dpYyBt YWlsaW5nIGxpc3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792676515; b=FI1BRp9uu+SbFIIReQGjjGDnMupekduZgpuiDDP3ip3Xhe6rAM6XWb1iJ5EDseW2j7pE 2TXsuWPuRDkI6KKUDKoGLFKRCCODHqg7C6QGemFjZuAQ4bn9arZC1Cr305+xIXMRYzky0 wrnBMrzEU7/dm0Q/bKLPwbjLoHM9vJIbK4DJq4bmL9bGZnDavS+mvdFjvAC+isyLcOHPZ 8DApvwVWj7iLdp8xIbV8kkl2ktQvcN3y9XcwgBKt4KaS/sMbCC868kjIqIFD4/xligSI2 /3bnTKIlYmkB5ZLVhecZufSN+4XlCWOrxrt0IJ/1KIN+2nj7VKdb3cHhBywnIMYlYQg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792676515; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=byINeMt3A+PO89GiAsGNR3UuXwrnKL5MmsK2RAyTqss=; b=dcgSvhFuBk9LRqGzqQqdI109MY/6Lon6bTL8n+6ShDyTTvwvQurY4aY2GiwQBTTfd2zS /T3OO4PUCfUeHRTpXUXKc1DSNHU2/lnhg265fMXGECjYMzzC8Ph7LE7iVSVCpgZnlldVW zG+NaE7mnQbA6M0sGG5EHpJwPS+4l2Y30n/8xeQL/qqEf8WNmjskEqzPvA6mv0I80IZDz 7kx5ZDni7FKmG7/IwCDV3FVrZVWdImzk6tq/+zP/ignQdgYmDSBGyd03/7V4luouHp7Ud hGL1WnesWCrmIk1thE2wkxIta5fjiqCXt1gBSLEUmRs3W3ZaShQeD2NFibsL+3JSZ2g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Xkx1gM5d; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAC9E60A2605 for ; Thu, 22 Oct 2026 13:41:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Xkx1gM5d Received: by smtp.kernel.org (Postfix) with ESMTPSA id 191431F000C2; Thu, 22 Oct 2026 13:41:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792676514; bh=byINeMt3A+PO89GiAsGNR3UuXwrnKL5MmsK2RAyTqss=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Xkx1gM5duvKz40/m53Ukc1GNlUzzoFwrOxlH6ts1Bqoq+jPI9Sm6Z/Q2bOPj5SVlB UD6DWvw6ZraJho+Y69Pk1iCQCzCcXYAHr+Mvjr6C3o5Uoh2bEzjM8Z38vFRZrZceSX iHvzKgtjT3QaG1npKKrPXNDBk9rc30szzMTAhdM1nAcBBiLKEHaKGl+PK6hhXKzIhE t0pkRIBlvLjzOjXr0szzj4Ks/aYRZqbvSW+FKzuXymb7D9/zkZFYy2PMwATGxQ0u/G EqhrIVw7gce1nlXhhzI1gRjeDQurjAt1QgqnmQbpoLWGUh5smbhDa9VhwHYW14IdGp lQF4MqKbo51dA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 9/9] usb: typec: ucsi: huawei-gaokun: pass down HPD_IRQ events Reply-To: sashiko-reviews@lists.linux.dev To: "Dmitry Baryshkov" Cc: dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-amlogic@lists.infradead.org, neil.armstrong@linaro.org In-Reply-To: <20261022-hpd-irq-events-v6-9-337ea3ddaa62@oss.qualcomm.com> References: <20261022-hpd-irq-events-v6-0-337ea3ddaa62@oss.qualcomm.com> <20261022-hpd-irq-events-v6-9-337ea3ddaa62@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 22 Oct 2026 13:41:53 +0000 X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [High] drm/msm/dp: missing closing brace in msm_dp_bridge_hpd_notify() - [High] drm/msm/dp: msm_dp_hpd_plug_handle() skips HPD high processing aft= er detect -- commit 42034f570d120654d6aa4e06b9c582eb06cb2f5f Author: Dmitry Baryshkov drm/msm: dp: handle the IRQ_HPD events reported by USB-C This commit updates msm_dp_bridge_hpd_notify() in the msm DisplayPort driver to handle DRM_CONNECTOR_DP_IRQ_HPD events reported via out-of-band notifications. > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp= /dp_display.c > index ce919a26fba28..6a8b3b8e1fe7f 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -1566,11 +1566,13 @@ void msm_dp_bridge_hpd_notify(struct drm_bridge *= bridge, > if (hpd_link_status =3D=3D ISR_HPD_REPLUG_COUNT) { > msm_dp_hpd_unplug_handle(dp); > msm_dp_hpd_plug_handle(dp); > - } else if (hpd_link_status =3D=3D ISR_IRQ_HPD_PULSE_COUNT) { > - msm_dp_irq_hpd_handle(dp); > } else { > msm_dp_hpd_plug_handle(dp); > } > + > + if (hpd_link_status =3D=3D ISR_IRQ_HPD_PULSE_COUNT || > + event =3D=3D DRM_CONNECTOR_DP_IRQ_HPD) { > + msm_dp_irq_hpd_handle(dp); > } else { > msm_dp_hpd_unplug_handle(dp); > } [Severity: High] Is there a missing closing brace for the inner if statement in msm_dp_bridge_hpd_notify() in drivers/gpu/drm/msm/dp/dp_display.c? The opening brace after checking ISR_IRQ_HPD_PULSE_COUNT and DRM_CONNECTOR_DP_IRQ_HPD is never closed before the else branch: if (status =3D=3D connector_status_connected) { ... if (hpd_link_status =3D=3D ISR_IRQ_HPD_PULSE_COUNT || event =3D=3D DRM_CONNECTOR_DP_IRQ_HPD) { msm_dp_irq_hpd_handle(dp); } else { msm_dp_hpd_unplug_handle(dp); } This leaves the outer if block unclosed, causing a build failure at the end of drivers/gpu/drm/msm/dp/dp_display.c as well as pairing the msm_dp_hpd_unplug_handle(dp) else branch with the inner check instead of status =3D=3D connector_status_connected. commit 1182d7f2f2e876c63dd6756de1f85227702b93b4 Author: Dmitry Baryshkov drm/msm/dp: don't take extra references on multiple plug events This commit adds an early return in msm_dp_hpd_plug_handle() when dp->plugged is already set so sequential plug events do not take extra runtime power management references. > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp= /dp_display.c > index fa8942922b533..ce919a26fba28 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -412,6 +412,9 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_displ= ay_private *dp) > =20 > guard(mutex)(&dp->plugged_lock); > =20 > + if (dp->plugged) > + return 0; > + > ret =3D pm_runtime_resume_and_get(&pdev->dev); > if (ret) { > DRM_ERROR("failed to pm_runtime_resume\n"); [Severity: High] Will returning early when dp->plugged is true in msm_dp_hpd_plug_handle() cause msm_dp_display_process_hpd_high() to be skipped after connector detection? During connector probing in drivers/gpu/drm/display/drm_bridge_connector.c:drm_bridge_connector_detect_= ctx(), detect->funcs->detect() is called before drm_bridge_connector_hpd_notify(): if (detect) { status =3D detect->funcs->detect(detect, connector); ... drm_bridge_connector_hpd_notify(connector, status, DRM_CONNECTOR_NO_EXTRA_STATUS); } When detect->funcs->detect() runs msm_dp_bridge_detect() in drivers/gpu/drm/msm/dp/dp_display.c, it reads the receiver capabilities and sets priv->plugged =3D true without calling msm_dp_display_process_hpd_high= (): ret =3D drm_dp_read_desc(priv->aux, &desc, drm_dp_is_branch(dpcd)); if (ret) { DRM_DEBUG_DP("failed to read desc\n"); priv->plugged =3D false; goto end; } status =3D connector_status_connected; priv->plugged =3D true; When drm_bridge_connector_hpd_notify() -> msm_dp_bridge_hpd_notify() -> msm_dp_hpd_plug_handle() then runs (or when a subsequent plug notification arrives), dp->plugged is already true, so msm_dp_hpd_plug_handle() returns 0 immediately without calling msm_dp_display_process_hpd_high(). Without msm_dp_display_process_hpd_high(), drm_edid_connector_update() is not called, dp->panel link parameters remain uninitialized, and dp->link->sink_count stays 0, causing link preparation to fail with -ENOTCONN. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261022-hpd-irq-ev= ents-v6-0-337ea3ddaa62@oss.qualcomm.com?part=3D9