From: sashiko-bot@kernel.org
To: "Julian Sun" <sunjunchao@bytedance.com>, linux-ext4@vger.kernel.org
Cc: tytso@mit.edu
Subject: Re: [PATCH v2 2/6] ext4: submit mapped buffers when io_end_vec allocation fails
Date: Fri, 23 Oct 2026 06:33:14 +0000 [thread overview]
Message-ID: <sashiko-outbox-182353@kernel.org> (raw)
In-Reply-To: <20261023061851.45579-3-sunjunchao@bytedance.com>
> When the filesystem block size is smaller than the folio size, a folio
> can contain discontiguous unwritten ranges. mpage_process_folio() records
> a mapped range for conversion before allocating an io_end_vec for the
> next range.
>
> If that allocation fails, mpage_map_and_submit_buffers() returns before
> submitting the folio. Its caller skips partial-folio submission, leaving
> the recorded range in io_end. Completion can then convert the range to
> written without writing its data, allowing reads to return stale disk
> contents.
>
> Pass progress into buffer processing and set it as buffer mappings are
> updated. Route errors after such progress through the existing
> partial-folio submission path, so the mapped buffers are submitted before
> io_end completion. Buffers still requiring mapping remain dirty for retry.
>
> Fixes: 4d06bfb97ecb ("ext4: Add error handling for io_end_vec struct allocation")
> Cc: stable@vger.kernel.org
> Signed-off-by: Julian Sun <sunjunchao@bytedance.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261023061851.45579-1-sunjunchao@bytedance.com?part=2
next prev parent reply other threads:[~2026-10-23 6:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 6:18 [PATCH v2 0/6] ext4: fix buffered writeback error handling Julian Sun
2026-10-23 6:18 ` [PATCH v2 1/6] ext4: move extent mapping error handling out of the loop Julian Sun
2026-10-23 6:27 ` sashiko-bot
2026-10-23 6:18 ` [PATCH v2 2/6] ext4: submit mapped buffers when io_end_vec allocation fails Julian Sun
2026-10-23 6:33 ` sashiko-bot [this message]
2026-10-23 6:18 ` [PATCH v2 3/6] ext4: prevent stale data exposure after fatal mapping errors Julian Sun
2026-10-23 6:18 ` [PATCH v2 4/6] ext4: put folio on partial writeback validation failure Julian Sun
2026-10-23 6:28 ` sashiko-bot
2026-10-23 6:18 ` [PATCH v2 5/6] ext4: report unwritten extent conversion errors to fsync Julian Sun
2026-10-23 6:26 ` sashiko-bot
2026-10-23 6:18 ` [PATCH v2 6/6] ext4: use atomic bitops for io_end flags Julian Sun
2026-10-23 6:31 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-182353@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sunjunchao@bytedance.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.