Re: [PATCH 4/6] arm64: dts: qcom: sm8250-hdk: Enable the PCIe ports

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] arm64: dts: qcom: missing Co-developed-by sign-off and From email mismatch
--

commit 330aa236347071fbfcbc8b5b9c4e5d1913e72fce
Author: ShiTou Hong <redstone.dcity@gmail.com>

arm64: dts: qcom: sm8250-hdk: Enable the PCIe ports

This commit adds the 3V3 fixed regulator node for pcie2 and enables the pcie0
and pcie2 controllers and their PHYs on the sm8250-hdk board.

>     arm64: dts: qcom: sm8250-hdk: Enable the PCIe ports
>
>     The sm8250-hdk has 2 PCIe ports which are not enabled in the dts.
>     The pcie0 is for the on-board ath11k WiFi/BT module;
>     while the pcie2 is for the M.2 connector.
>
>     Add the 3V3 regulator node for pcie2.
>     Enable the 2 pcie controllers and phys.
>
>     Co-developed-by: KancyJoe <kancy2333@outlook.com>
>     Signed-off-by: ShiTou Hong <dc_redstone@outlook.com>

[Severity: Low]
Per Documentation/process/submitting-patches.rst, every Co-developed-by: tag
denotes authorship and must be immediately followed by a matching
Signed-off-by: tag from the associated co-author:

  Since Co-developed-by: denotes authorship, every Co-developed-by: must be
  immediately followed by a Signed-off-by: of the associated co-author.

Should this include a Signed-off-by: tag for KancyJoe <kancy2333@outlook.com>
immediately following the Co-developed-by: line?

Also, the commit Author email address (redstone.dcity@gmail.com) does not
match the email address in the submitter's Signed-off-by: line
(dc_redstone@outlook.com). Should the Author header and Signed-off-by: tag
use matching email addresses?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261023072832.2642647-1-dc_redstone@outlook.com?part=4