Re: [PATCH 4/7] dt-bindings: power: supply: axp20x-usb-power: Add the AXP2101

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: power: supply: missing allOf constraint for axp2101
--

commit 2c463350d4ace5833f7eb6572cc583175ea48340
Author: Olivier Louvignes <olivier@mgcrea.io>

dt-bindings: power: supply: axp20x-usb-power: Add the AXP2101

This commit adds the x-powers,axp2101-usb-power-supply compatible string to
the AXP20x USB power supply binding schema for the AXP2101 PMIC.

> diff --git a/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-usb-power-supply.yaml b/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-usb-power-supply.yaml
> index 2ec036405ae47..1c582aa5e1d0b 100644
> --- a/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-usb-power-supply.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-usb-power-supply.yaml
> @@ -25,6 +25,7 @@ properties:
>            - x-powers,axp223-usb-power-supply
>            - x-powers,axp717-usb-power-supply
>            - x-powers,axp813-usb-power-supply
> +          - x-powers,axp2101-usb-power-supply

[Severity: Medium]
Should x-powers,axp2101-usb-power-supply also have a corresponding if-then
block under allOf to constrain input-current-limit-microamp?

In Documentation/devicetree/bindings/power/supply/x-powers,axp20x-usb-power-supply.yaml,
the top-level input-current-limit-microamp property only defines broad generic
bounds (minimum: 100000, maximum: 4000000), while allOf restricts the property
for each existing compatible variant:

  allOf:
    - $ref: power-supply.yaml#
    ...
    - if:
        properties:
          compatible:
            contains:
              enum:
                - x-powers,axp717-usb-power-supply
      then:
        properties:
          input-current-limit-microamp:
            description: Maximum input current in increments of 50000 uA.
            minimum: 100000
            maximum: 3250000

Without a conditional block in allOf for x-powers,axp2101-usb-power-supply,
device tree nodes using this compatible string will pass schema validation
with any input-current-limit-microamp value between 100000 and 4000000 uA,
even though the AXP2101 hardware only supports discrete limits of 100000,
500000, 900000, 1000000, 1500000, and 2000000 uA.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261023100401.67592-1-olivier@mgcrea.io?part=4