From: sashiko-bot@kernel.org
To: "Thomas Zimmermann" <tzimmermann@suse.de>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH v3 3/7] fbcon: Implement struct consw.con_unblank
Date: Fri, 23 Oct 2026 13:41:35 +0000 [thread overview]
Message-ID: <sashiko-outbox-182840@kernel.org> (raw)
In-Reply-To: <20261023132448.115747-4-tzimmermann@suse.de>
> Implement con_unblank from struct consw with the !blank branches from
> fbcon_blank(). The new function is called fbcon_unblank(). Remove the
> duplicated code from fbcon_blank().
>
> Fbcon tracks fbdev blank state in par->blank_state using fbdev's FB_BLANK
> constants. In fbcon_unblank() the stored value is always FB_BLANK_UNBLANK.
> In fbcon_blank(), the new blank state is 1 + plus the VESA blank mode
> given in the parameter blank.
>
> fbcon_blank() now disables the cursor worker unconditionally.
>
> v3:
> - take mode_switch from parameter
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261023132448.115747-1-tzimmermann@suse.de?part=3
next prev parent reply other threads:[~2026-10-23 13:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 13:16 [PATCH v3 0/7] vt: Simplify console-blanking interface Thomas Zimmermann
2026-10-23 13:16 ` [PATCH v3 1/7] vt: Add con_unblank callback to struct consw Thomas Zimmermann
2026-10-23 13:38 ` sashiko-bot
2026-10-23 13:16 ` [PATCH v3 2/7] dummycon: Implement struct consw.con_unblank Thomas Zimmermann
2026-10-23 13:37 ` sashiko-bot
2026-10-23 13:16 ` [PATCH v3 3/7] fbcon: " Thomas Zimmermann
2026-10-23 13:41 ` sashiko-bot [this message]
2026-10-23 13:16 ` [PATCH v3 4/7] newport_con: " Thomas Zimmermann
2026-10-23 13:36 ` sashiko-bot
2026-10-23 13:16 ` [PATCH v3 5/7] sticon: " Thomas Zimmermann
2026-10-23 13:35 ` sashiko-bot
2026-10-23 13:16 ` [PATCH v3 6/7] vgacon: " Thomas Zimmermann
2026-10-23 13:39 ` sashiko-bot
2026-10-23 13:16 ` [PATCH v3 7/7] vt: Remove old-style con_blank Thomas Zimmermann
2026-10-23 13:37 ` Greg KH
2026-10-25 7:48 ` Helge Deller
2026-10-26 7:41 ` Thomas Zimmermann
2026-10-23 13:37 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-182840@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.