From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792764350; b=Qi0QApdtmrUpFMTt4QVanFBtVlRyJqVZtKZ8fEYHelP9fYFWi4SJ85Icd3is5FgktP+U d1+shco4VAdurRi0Z7foVIwtDepDd1IxgUUbNSXf8HbUDVi0R6mKgfCzIHpHFCESp8eDJ GkYPwEhKFGhhM/oq5W7l/gKlCSP2k7BS1j7HYDuDzFg1N1aCSmQLpB344k0/q//yfGhE3 cxyQahZh71shmTOdWCNZ+ogaENFzqjvCGwHxrjZ3moKFAhSG7EWYo0yLgSoSdomMeb4QJ AuKnh1f5ddiEPFAZdsztyJhlk3i5PVrlKya1zXUjJ0y3vJNJ4tz1oha52Pz1j/KuvyA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792764350; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=bN4K8C2gcJoq6iVuHKcSfWsvC4b7uQWBypjpJ05w2EM=; b=PxbhDG9KmUYLw3jrFNlqE5t1Xl6MHCvDOTig3vzJThYYhrtIQU+lfH802zBlktm973FE WeHNiV/IEKCX7cFC1neWlKkLtlg4l5SwmODdMz4D/X6Pbln1yIUNf4al7dH6yS0SCbhqJ 5/Zx9CgexVwoYzayMt3wkIHbZQLHQDztUxCNJBhEKklWsRiAr99tiUocujt0YQX2WV/Jw Og27BjJT1GPRz0I7g/QsBiu94146MlZ9c60SQkzoUa9pGdhpnLChizL39Bl380LOmeChI fjVuoI5cljFkskY7L4KaOsoWG2IrjR9oW5rlLGRiKC9qNtYRdvoO/fDv50X2qhSaTMw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=X03GOyY9; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08E3B606A31B for ; Fri, 23 Oct 2026 14:05:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=X03GOyY9 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 867291F01829; Fri, 23 Oct 2026 14:05:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792764349; bh=bN4K8C2gcJoq6iVuHKcSfWsvC4b7uQWBypjpJ05w2EM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=X03GOyY9GFgm7DNoST/RH7kZYWrgOstVN6nOQFjox6sr9vNJbi4EmBCUCvcHsNJL4 ZfR3Vw49qUPPwZmq8HE8oWD/pMOSIctkgQBml98RvNAE8hi5mnXo/q+OrfCa148o3W 632IiHtQzmzBlDwJc//IRddS5R6qKoFDdm3AmOzH2GbsnxAKbMuMG68PnqhGGJQ4gy /n6hWMUtf0NwoY2KM640k/Fn64e6h9foVCk3DZnmDJ6BEoOQDHGnL7oJKEYVpUUIT5 /N7psXaH3xh2ZpEiOk8O3B27t8E81nqjraDvUP7sBxNPw82fhHXTPBTtFjAbSTNMcm yoCWngz9taYlA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v7 7/9] drm/msm/dp: handle the IRQ_HPD events reported by USB-C Reply-To: sashiko-reviews@lists.linux.dev To: "Dmitry Baryshkov" Cc: dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-amlogic@lists.infradead.org, neil.armstrong@linaro.org In-Reply-To: <20261023-hpd-irq-events-v7-7-57a3aea3f09e@oss.qualcomm.com> References: <20261023-hpd-irq-events-v7-0-57a3aea3f09e@oss.qualcomm.com> <20261023-hpd-irq-events-v7-7-57a3aea3f09e@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 23 Oct 2026 14:05:49 +0000 X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] drm/msm/dp: msm_dp_bridge_hpd_notify() runs irq_hpd on unpowered l= ink -- commit 378c862ef1c761eb90130da10b12f8747c15b1a2 Author: Dmitry Baryshkov drm/msm/dp: handle the IRQ_HPD events reported by USB-C This commit updates msm_dp_bridge_hpd_notify() to handle out-of-band DRM_CONNECTOR_DP_IRQ_HPD events reported via USB-C AltMode notifications and restructures the connected branch so that msm_dp_hpd_plug_handle() runs prior to msm_dp_irq_hpd_handle(). > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp= /dp_display.c > index ce919a26fba28..771c8b0744aee 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -1566,11 +1566,13 @@ void msm_dp_bridge_hpd_notify(struct drm_bridge *= bridge, > if (hpd_link_status =3D=3D ISR_HPD_REPLUG_COUNT) { > msm_dp_hpd_unplug_handle(dp); > msm_dp_hpd_plug_handle(dp); > - } else if (hpd_link_status =3D=3D ISR_IRQ_HPD_PULSE_COUNT) { > - msm_dp_irq_hpd_handle(dp); > } else { > msm_dp_hpd_plug_handle(dp); > } > + > + if (hpd_link_status =3D=3D ISR_IRQ_HPD_PULSE_COUNT || > + event =3D=3D DRM_CONNECTOR_DP_IRQ_HPD) > + msm_dp_irq_hpd_handle(dp); [Severity: High] Can calling msm_dp_irq_hpd_handle(dp) unconditionally after msm_dp_hpd_plug_handle(dp) trigger link maintenance while the mainlink and link clocks are still off? Previously, msm_dp_hpd_plug_handle(dp) and msm_dp_irq_hpd_handle(dp) were in mutually exclusive branches in msm_dp_bridge_hpd_notify(). With this change, when status is connector_status_connected and either event is DRM_CONNECTOR_DP_IRQ_HPD or hpd_link_status is ISR_IRQ_HPD_PULSE_COUNT, msm_dp_hpd_plug_handle(dp) runs first and is immediately followed by msm_dp_irq_hpd_handle(dp). When dp->plugged is false on entry (such as when a USB-C AltMode driver reports both HPD_STATE and IRQ_HPD together on initial plug, or when a monitor is plugged into a connected USB-C branch device whose prior sink_count =3D=3D 0 caused msm_dp_hpd_unplug_handle() to clear dp->plugged)= , or after msm_dp_hpd_unplug_handle(dp) in the ISR_HPD_REPLUG_COUNT path, msm_dp_hpd_plug_handle(dp) runs: msm_dp_hpd_plug_handle() -> msm_dp_display_process_hpd_high() -> msm_dp_link_process_request() -> msm_dp_link_process_ds_port_status_change() At this point, msm_dp_hpd_plug_handle(dp) only enables AUX transfers and initializes the PHY; dp->msm_dp_display.power_on and ctrl->link_clks_on remain false until msm_dp_display_atomic_enable() is called. However, msm_dp_link_process_ds_port_status_change() has already updated link->prev_sink_count to match link->msm_dp_link.sink_count. When msm_dp_irq_hpd_handle(dp) then runs immediately afterward (or when an IRQ_HPD arrives while dp->plugged is true before atomic_enable() has enabled the mainlink): drivers/gpu/drm/msm/dp/dp_display.c:msm_dp_irq_hpd_handle() { rc =3D msm_dp_link_process_request(dp->link); if (!rc) { sink_request =3D dp->link->sink_request; drm_dbg_dp(dp->drm_dev, "sink_request=3D%d\n", sink_request); if (sink_request & DS_PORT_STATUS_CHANGED) rc =3D msm_dp_display_process_hpd_high(dp); else rc =3D msm_dp_display_handle_irq_hpd(dp); } } If DP_DOWNSTREAM_PORT_STATUS_CHANGED is still set in DP_LANE_ALIGN_STATUS_UPDATED, msm_dp_display_process_hpd_high(dp) is called a second time, redundantly re-initializing LTTPRs and re-reading DPCD and EDID. Otherwise, because link->prev_sink_count already equals sink_count, msm_dp_link_process_ds_port_status_change() returns -EINVAL and msm_dp_link_process_request() falls through to msm_dp_link_process_link_status_update(): drivers/gpu/drm/msm/dp/dp_link.c:msm_dp_link_process_request() { ... } else { ret =3D msm_dp_link_process_link_status_update(link); if (!ret) { msm_dp_link->sink_request |=3D DP_LINK_STATUS_UPDATED; } Because the link has not been trained yet (dp->msm_dp_display.power_on is false and DP_INTERLANE_ALIGN_DONE is 0), drm_dp_channel_eq_ok() is false, so msm_dp_link_process_link_status_update() returns 0 and flags DP_LINK_STATUS_UPDATED. msm_dp_irq_hpd_handle(dp) then takes the else branch into msm_dp_display_handle_irq_hpd(dp) -> msm_dp_ctrl_handle_sink_request() -> msm_dp_ctrl_link_maintenance(): drivers/gpu/drm/msm/dp/dp_ctrl.c:msm_dp_ctrl_link_maintenance() { int ret =3D 0; int training_step =3D DP_TRAINING_NONE; msm_dp_ctrl_push_idle(&ctrl->msm_dp_ctrl); ctrl->link->phy_params.p_level =3D 0; ctrl->link->phy_params.v_level =3D 0; ret =3D msm_dp_ctrl_setup_main_link(ctrl, panel, &training_step); if (ret) goto end; msm_dp_ctrl_clear_training_pattern(ctrl, panel, DP_PHY_DPRX); msm_dp_write_link(ctrl, REG_DP_STATE_CTRL, DP_STATE_CTRL_SEND_VIDEO); ret =3D msm_dp_ctrl_wait4video_ready(ctrl); } This drives msm_dp_ctrl_push_idle() and writes to link_base registers while !dp->msm_dp_display.power_on and !ctrl->link_clks_on, which causes unclocked register accesses, PUSH_IDLE timeouts, or a TrustZone force-stop and SoC reset (as noted in msm_dp_display_atomic_disable() where msm_dp_ctrl_push_idle() is guarded by dp->power_on). Should msm_dp_irq_hpd_handle(dp) be skipped when msm_dp_hpd_plug_handle(dp) just handled a fresh plug, and should link maintenance in the IRQ_HPD path check that the mainlink is powered on before attempting to retrain the link? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261023-hpd-irq-ev= ents-v7-0-57a3aea3f09e@oss.qualcomm.com?part=3D7 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8CBD606A31E for ; Fri, 23 Oct 2026 14:05:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=lSlS0eAg; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=X03GOyY9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=35lFTincDxrlE9Zhib47oTA9YbpsqrBMQnTYQXO5Pvk=; b=lSlS0eAgrifFy3M4Oab9KbL86s VgDkbCFb5+2iy5h2TA9hC5zdfdC4tEGSFQpcCR1kpixCncrDhEJKnYG6GUVhBwmZB2Wg+C7zzorAm i9JKEyKea1uXflFcI2579Cnv5Mv86k5Ee6b7KlbRgLt1VkqckuimvsHwdU+ybSs11OgODfwkfZwL4 8+4CZBENNC36SQvsxshuJi3kDBpcPfgH915yQex2q/UGXKY9xpTIaZBbeutL7XoHVXksPb7PFczCH 4daMcCqoaQ+eUSY/n3I6+qEORB9RdDHfFeVyXxjHBga0zgxXf8dQczh+irRAkBE0uh/vdr599KVMq jPFLggZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xKFu3-0000000GTRP-125T; Fri, 23 Oct 2026 14:05:51 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xKFu2-0000000GTR3-24W7 for linux-amlogic@lists.infradead.org; Fri, 23 Oct 2026 14:05:50 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 01AB0421EF; Fri, 23 Oct 2026 14:05:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 867291F01829; Fri, 23 Oct 2026 14:05:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792764349; bh=bN4K8C2gcJoq6iVuHKcSfWsvC4b7uQWBypjpJ05w2EM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=X03GOyY9GFgm7DNoST/RH7kZYWrgOstVN6nOQFjox6sr9vNJbi4EmBCUCvcHsNJL4 ZfR3Vw49qUPPwZmq8HE8oWD/pMOSIctkgQBml98RvNAE8hi5mnXo/q+OrfCa148o3W 632IiHtQzmzBlDwJc//IRddS5R6qKoFDdm3AmOzH2GbsnxAKbMuMG68PnqhGGJQ4gy /n6hWMUtf0NwoY2KM640k/Fn64e6h9foVCk3DZnmDJ6BEoOQDHGnL7oJKEYVpUUIT5 /N7psXaH3xh2ZpEiOk8O3B27t8E81nqjraDvUP7sBxNPw82fhHXTPBTtFjAbSTNMcm yoCWngz9taYlA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v7 7/9] drm/msm/dp: handle the IRQ_HPD events reported by USB-C To: "Dmitry Baryshkov" Cc: dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-amlogic@lists.infradead.org, neil.armstrong@linaro.org In-Reply-To: <20261023-hpd-irq-events-v7-7-57a3aea3f09e@oss.qualcomm.com> References: <20261023-hpd-irq-events-v7-0-57a3aea3f09e@oss.qualcomm.com> <20261023-hpd-irq-events-v7-7-57a3aea3f09e@oss.qualcomm.com> Date: Fri, 23 Oct 2026 14:05:49 +0000 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIGRybS9tc20vZHA6IG1z bV9kcF9icmlkZ2VfaHBkX25vdGlmeSgpIHJ1bnMgaXJxX2hwZCBvbiB1bnBvd2VyZWQgbGluawot LQoKY29tbWl0IDM3OGM4NjJlZjFjNzYxZWI5MDEzMGRhMTBiMTJmODc0N2MxNWIxYTIKQXV0aG9y OiBEbWl0cnkgQmFyeXNoa292IDxkbWl0cnkuYmFyeXNoa292QG9zcy5xdWFsY29tbS5jb20+Cgpk cm0vbXNtL2RwOiBoYW5kbGUgdGhlIElSUV9IUEQgZXZlbnRzIHJlcG9ydGVkIGJ5IFVTQi1DCgpU aGlzIGNvbW1pdCB1cGRhdGVzIG1zbV9kcF9icmlkZ2VfaHBkX25vdGlmeSgpIHRvIGhhbmRsZSBv dXQtb2YtYmFuZApEUk1fQ09OTkVDVE9SX0RQX0lSUV9IUEQgZXZlbnRzIHJlcG9ydGVkIHZpYSBV U0ItQyBBbHRNb2RlIG5vdGlmaWNhdGlvbnMKYW5kIHJlc3RydWN0dXJlcyB0aGUgY29ubmVjdGVk IGJyYW5jaCBzbyB0aGF0IG1zbV9kcF9ocGRfcGx1Z19oYW5kbGUoKSBydW5zCnByaW9yIHRvIG1z bV9kcF9pcnFfaHBkX2hhbmRsZSgpLgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21z bS9kcC9kcF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2RwL2RwX2Rpc3BsYXkuYwo+ IGluZGV4IGNlOTE5YTI2ZmJhMjguLjc3MWM4YjA3NDRhZWUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL21zbS9kcC9kcF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNt L2RwL2RwX2Rpc3BsYXkuYwo+IEBAIC0xNTY2LDExICsxNTY2LDEzIEBAIHZvaWQgbXNtX2RwX2Jy aWRnZV9ocGRfbm90aWZ5KHN0cnVjdCBkcm1fYnJpZGdlICpicmlkZ2UsCj4gIAkJaWYgKGhwZF9s aW5rX3N0YXR1cyA9PSBJU1JfSFBEX1JFUExVR19DT1VOVCkgewo+ICAJCQltc21fZHBfaHBkX3Vu cGx1Z19oYW5kbGUoZHApOwo+ICAJCQltc21fZHBfaHBkX3BsdWdfaGFuZGxlKGRwKTsKPiAtCQl9 IGVsc2UgaWYgKGhwZF9saW5rX3N0YXR1cyA9PSBJU1JfSVJRX0hQRF9QVUxTRV9DT1VOVCkgewo+ IC0JCQltc21fZHBfaXJxX2hwZF9oYW5kbGUoZHApOwo+ICAJCX0gZWxzZSB7Cj4gIAkJCW1zbV9k cF9ocGRfcGx1Z19oYW5kbGUoZHApOwo+ICAJCX0KPiArCj4gKwkJaWYgKGhwZF9saW5rX3N0YXR1 cyA9PSBJU1JfSVJRX0hQRF9QVUxTRV9DT1VOVCB8fAo+ICsJCSAgICBldmVudCA9PSBEUk1fQ09O TkVDVE9SX0RQX0lSUV9IUEQpCj4gKwkJCW1zbV9kcF9pcnFfaHBkX2hhbmRsZShkcCk7CgpbU2V2 ZXJpdHk6IEhpZ2hdCkNhbiBjYWxsaW5nIG1zbV9kcF9pcnFfaHBkX2hhbmRsZShkcCkgdW5jb25k aXRpb25hbGx5IGFmdGVyCm1zbV9kcF9ocGRfcGx1Z19oYW5kbGUoZHApIHRyaWdnZXIgbGluayBt YWludGVuYW5jZSB3aGlsZSB0aGUgbWFpbmxpbmsgYW5kCmxpbmsgY2xvY2tzIGFyZSBzdGlsbCBv ZmY/CgpQcmV2aW91c2x5LCBtc21fZHBfaHBkX3BsdWdfaGFuZGxlKGRwKSBhbmQgbXNtX2RwX2ly cV9ocGRfaGFuZGxlKGRwKSB3ZXJlIGluCm11dHVhbGx5IGV4Y2x1c2l2ZSBicmFuY2hlcyBpbiBt c21fZHBfYnJpZGdlX2hwZF9ub3RpZnkoKS4gV2l0aCB0aGlzIGNoYW5nZSwKd2hlbiBzdGF0dXMg aXMgY29ubmVjdG9yX3N0YXR1c19jb25uZWN0ZWQgYW5kIGVpdGhlciBldmVudCBpcwpEUk1fQ09O TkVDVE9SX0RQX0lSUV9IUEQgb3IgaHBkX2xpbmtfc3RhdHVzIGlzIElTUl9JUlFfSFBEX1BVTFNF X0NPVU5ULAptc21fZHBfaHBkX3BsdWdfaGFuZGxlKGRwKSBydW5zIGZpcnN0IGFuZCBpcyBpbW1l ZGlhdGVseSBmb2xsb3dlZCBieQptc21fZHBfaXJxX2hwZF9oYW5kbGUoZHApLgoKV2hlbiBkcC0+ cGx1Z2dlZCBpcyBmYWxzZSBvbiBlbnRyeSAoc3VjaCBhcyB3aGVuIGEgVVNCLUMgQWx0TW9kZSBk cml2ZXIKcmVwb3J0cyBib3RoIEhQRF9TVEFURSBhbmQgSVJRX0hQRCB0b2dldGhlciBvbiBpbml0 aWFsIHBsdWcsIG9yIHdoZW4gYQptb25pdG9yIGlzIHBsdWdnZWQgaW50byBhIGNvbm5lY3RlZCBV U0ItQyBicmFuY2ggZGV2aWNlIHdob3NlIHByaW9yCnNpbmtfY291bnQgPT0gMCBjYXVzZWQgbXNt X2RwX2hwZF91bnBsdWdfaGFuZGxlKCkgdG8gY2xlYXIgZHAtPnBsdWdnZWQpLCBvcgphZnRlciBt c21fZHBfaHBkX3VucGx1Z19oYW5kbGUoZHApIGluIHRoZSBJU1JfSFBEX1JFUExVR19DT1VOVCBw YXRoLAptc21fZHBfaHBkX3BsdWdfaGFuZGxlKGRwKSBydW5zOgoKbXNtX2RwX2hwZF9wbHVnX2hh bmRsZSgpCiAgLT4gbXNtX2RwX2Rpc3BsYXlfcHJvY2Vzc19ocGRfaGlnaCgpCiAgICAgICAtPiBt c21fZHBfbGlua19wcm9jZXNzX3JlcXVlc3QoKQogICAgICAgICAgICAtPiBtc21fZHBfbGlua19w cm9jZXNzX2RzX3BvcnRfc3RhdHVzX2NoYW5nZSgpCgpBdCB0aGlzIHBvaW50LCBtc21fZHBfaHBk X3BsdWdfaGFuZGxlKGRwKSBvbmx5IGVuYWJsZXMgQVVYIHRyYW5zZmVycyBhbmQKaW5pdGlhbGl6 ZXMgdGhlIFBIWTsgZHAtPm1zbV9kcF9kaXNwbGF5LnBvd2VyX29uIGFuZCBjdHJsLT5saW5rX2Ns a3Nfb24KcmVtYWluIGZhbHNlIHVudGlsIG1zbV9kcF9kaXNwbGF5X2F0b21pY19lbmFibGUoKSBp cyBjYWxsZWQuIEhvd2V2ZXIsCm1zbV9kcF9saW5rX3Byb2Nlc3NfZHNfcG9ydF9zdGF0dXNfY2hh bmdlKCkgaGFzIGFscmVhZHkgdXBkYXRlZApsaW5rLT5wcmV2X3NpbmtfY291bnQgdG8gbWF0Y2gg bGluay0+bXNtX2RwX2xpbmsuc2lua19jb3VudC4KCldoZW4gbXNtX2RwX2lycV9ocGRfaGFuZGxl KGRwKSB0aGVuIHJ1bnMgaW1tZWRpYXRlbHkgYWZ0ZXJ3YXJkIChvciB3aGVuIGFuCklSUV9IUEQg YXJyaXZlcyB3aGlsZSBkcC0+cGx1Z2dlZCBpcyB0cnVlIGJlZm9yZSBhdG9taWNfZW5hYmxlKCkg aGFzIGVuYWJsZWQKdGhlIG1haW5saW5rKToKCmRyaXZlcnMvZ3B1L2RybS9tc20vZHAvZHBfZGlz cGxheS5jOm1zbV9kcF9pcnFfaHBkX2hhbmRsZSgpIHsKCXJjID0gbXNtX2RwX2xpbmtfcHJvY2Vz c19yZXF1ZXN0KGRwLT5saW5rKTsKCWlmICghcmMpIHsKCQlzaW5rX3JlcXVlc3QgPSBkcC0+bGlu ay0+c2lua19yZXF1ZXN0OwoJCWRybV9kYmdfZHAoZHAtPmRybV9kZXYsICJzaW5rX3JlcXVlc3Q9 JWRcbiIsIHNpbmtfcmVxdWVzdCk7CgkJaWYgKHNpbmtfcmVxdWVzdCAmIERTX1BPUlRfU1RBVFVT X0NIQU5HRUQpCgkJCXJjID0gbXNtX2RwX2Rpc3BsYXlfcHJvY2Vzc19ocGRfaGlnaChkcCk7CgkJ ZWxzZQoJCQlyYyA9IG1zbV9kcF9kaXNwbGF5X2hhbmRsZV9pcnFfaHBkKGRwKTsKCX0KfQoKSWYg RFBfRE9XTlNUUkVBTV9QT1JUX1NUQVRVU19DSEFOR0VEIGlzIHN0aWxsIHNldCBpbgpEUF9MQU5F X0FMSUdOX1NUQVRVU19VUERBVEVELCBtc21fZHBfZGlzcGxheV9wcm9jZXNzX2hwZF9oaWdoKGRw KSBpcyBjYWxsZWQKYSBzZWNvbmQgdGltZSwgcmVkdW5kYW50bHkgcmUtaW5pdGlhbGl6aW5nIExU VFBScyBhbmQgcmUtcmVhZGluZyBEUENEIGFuZApFRElELgoKT3RoZXJ3aXNlLCBiZWNhdXNlIGxp bmstPnByZXZfc2lua19jb3VudCBhbHJlYWR5IGVxdWFscyBzaW5rX2NvdW50LAptc21fZHBfbGlu a19wcm9jZXNzX2RzX3BvcnRfc3RhdHVzX2NoYW5nZSgpIHJldHVybnMgLUVJTlZBTCBhbmQKbXNt X2RwX2xpbmtfcHJvY2Vzc19yZXF1ZXN0KCkgZmFsbHMgdGhyb3VnaCB0bwptc21fZHBfbGlua19w cm9jZXNzX2xpbmtfc3RhdHVzX3VwZGF0ZSgpOgoKZHJpdmVycy9ncHUvZHJtL21zbS9kcC9kcF9s aW5rLmM6bXNtX2RwX2xpbmtfcHJvY2Vzc19yZXF1ZXN0KCkgewoJLi4uCgl9IGVsc2UgewoJCXJl dCA9IG1zbV9kcF9saW5rX3Byb2Nlc3NfbGlua19zdGF0dXNfdXBkYXRlKGxpbmspOwoJCWlmICgh cmV0KSB7CgkJCW1zbV9kcF9saW5rLT5zaW5rX3JlcXVlc3QgfD0gRFBfTElOS19TVEFUVVNfVVBE QVRFRDsKfQoKQmVjYXVzZSB0aGUgbGluayBoYXMgbm90IGJlZW4gdHJhaW5lZCB5ZXQgKGRwLT5t c21fZHBfZGlzcGxheS5wb3dlcl9vbiBpcwpmYWxzZSBhbmQgRFBfSU5URVJMQU5FX0FMSUdOX0RP TkUgaXMgMCksIGRybV9kcF9jaGFubmVsX2VxX29rKCkgaXMgZmFsc2UsIHNvCm1zbV9kcF9saW5r X3Byb2Nlc3NfbGlua19zdGF0dXNfdXBkYXRlKCkgcmV0dXJucyAwIGFuZCBmbGFncwpEUF9MSU5L X1NUQVRVU19VUERBVEVELgoKbXNtX2RwX2lycV9ocGRfaGFuZGxlKGRwKSB0aGVuIHRha2VzIHRo ZSBlbHNlIGJyYW5jaCBpbnRvCm1zbV9kcF9kaXNwbGF5X2hhbmRsZV9pcnFfaHBkKGRwKSAtPiBt c21fZHBfY3RybF9oYW5kbGVfc2lua19yZXF1ZXN0KCkgLT4KbXNtX2RwX2N0cmxfbGlua19tYWlu dGVuYW5jZSgpOgoKZHJpdmVycy9ncHUvZHJtL21zbS9kcC9kcF9jdHJsLmM6bXNtX2RwX2N0cmxf bGlua19tYWludGVuYW5jZSgpIHsKCWludCByZXQgPSAwOwoJaW50IHRyYWluaW5nX3N0ZXAgPSBE UF9UUkFJTklOR19OT05FOwoKCW1zbV9kcF9jdHJsX3B1c2hfaWRsZSgmY3RybC0+bXNtX2RwX2N0 cmwpOwoKCWN0cmwtPmxpbmstPnBoeV9wYXJhbXMucF9sZXZlbCA9IDA7CgljdHJsLT5saW5rLT5w aHlfcGFyYW1zLnZfbGV2ZWwgPSAwOwoKCXJldCA9IG1zbV9kcF9jdHJsX3NldHVwX21haW5fbGlu ayhjdHJsLCBwYW5lbCwgJnRyYWluaW5nX3N0ZXApOwoJaWYgKHJldCkKCQlnb3RvIGVuZDsKCglt c21fZHBfY3RybF9jbGVhcl90cmFpbmluZ19wYXR0ZXJuKGN0cmwsIHBhbmVsLCBEUF9QSFlfRFBS WCk7CgoJbXNtX2RwX3dyaXRlX2xpbmsoY3RybCwgUkVHX0RQX1NUQVRFX0NUUkwsIERQX1NUQVRF X0NUUkxfU0VORF9WSURFTyk7CgoJcmV0ID0gbXNtX2RwX2N0cmxfd2FpdDR2aWRlb19yZWFkeShj dHJsKTsKfQoKVGhpcyBkcml2ZXMgbXNtX2RwX2N0cmxfcHVzaF9pZGxlKCkgYW5kIHdyaXRlcyB0 byBsaW5rX2Jhc2UgcmVnaXN0ZXJzIHdoaWxlCiFkcC0+bXNtX2RwX2Rpc3BsYXkucG93ZXJfb24g YW5kICFjdHJsLT5saW5rX2Nsa3Nfb24sIHdoaWNoIGNhdXNlcyB1bmNsb2NrZWQKcmVnaXN0ZXIg YWNjZXNzZXMsIFBVU0hfSURMRSB0aW1lb3V0cywgb3IgYSBUcnVzdFpvbmUgZm9yY2Utc3RvcCBh bmQgU29DCnJlc2V0IChhcyBub3RlZCBpbiBtc21fZHBfZGlzcGxheV9hdG9taWNfZGlzYWJsZSgp IHdoZXJlCm1zbV9kcF9jdHJsX3B1c2hfaWRsZSgpIGlzIGd1YXJkZWQgYnkgZHAtPnBvd2VyX29u KS4KClNob3VsZCBtc21fZHBfaXJxX2hwZF9oYW5kbGUoZHApIGJlIHNraXBwZWQgd2hlbiBtc21f ZHBfaHBkX3BsdWdfaGFuZGxlKGRwKQpqdXN0IGhhbmRsZWQgYSBmcmVzaCBwbHVnLCBhbmQgc2hv dWxkIGxpbmsgbWFpbnRlbmFuY2UgaW4gdGhlIElSUV9IUEQgcGF0aApjaGVjayB0aGF0IHRoZSBt YWlubGluayBpcyBwb3dlcmVkIG9uIGJlZm9yZSBhdHRlbXB0aW5nIHRvIHJldHJhaW4gdGhlIGxp bms/CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNo c2V0LzIwMjYxMDIzLWhwZC1pcnEtZXZlbnRzLXY3LTAtNTdhM2FlYTNmMDllQG9zcy5xdWFsY29t bS5jb20/cGFydD03CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hbWxvZ2ljIG1haWxpbmcgbGlzdApsaW51eC1hbWxvZ2ljQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hbWxvZ2ljCg==