From: sashiko-bot@kernel.org
To: "James Hilliard" <james.hilliard1@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH v3 3/4] dmaengine: dw: Prevent tx-status calling DMA-desc callback
Date: Fri, 23 Oct 2026 16:40:08 +0000 [thread overview]
Message-ID: <sashiko-outbox-182959@kernel.org> (raw)
In-Reply-To: <20261023-submit-dw-dma-synchronize-v1-v3-3-c62bf048f5ce@gmail.com>
> From: Serge Semin <fancer.lancer@gmail.com>
>
> The DMA transfer status getter can invoke a completion callback from
> dwc_scan_descriptors(). An 8250 RX timeout queries that status while
> holding the UART port lock, and its DMA callback takes the same lock:
>
> serial8250_handle_irq()
> uart_port_lock_irqsave(port)
> serial8250_rx_dma_flush()
> dmaengine_tx_status()
> dwc_scan_descriptors()
> dwc_descriptor_complete()
> dma_rx_complete()
> uart_port_lock_irqsave(port)
>
> [ ... ]
> Fixes: 3bfb1d20b547 ("dmaengine: Driver for the Synopsys DesignWare DMA controller")
> Cc: stable@vger.kernel.org
> Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
> [james: defer notifications while preserving polled completion and cleanup]
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261023-submit-dw-dma-synchronize-v1-v3-0-c62bf048f5ce@gmail.com?part=3
next prev parent reply other threads:[~2026-10-23 16:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 16:27 [PATCH v3 0/4] dmaengine: dw: serialize completion and termination James Hilliard
2026-10-23 16:27 ` [PATCH v3 1/4] dmaengine: dw: Fix XFER bit set, but channel not idle error James Hilliard
2026-10-23 16:42 ` sashiko-bot
2026-10-23 21:35 ` Frank Li
2026-10-23 21:51 ` James Hilliard
2026-10-28 16:17 ` Frank Li
2026-10-23 16:27 ` [PATCH v3 2/4] dmaengine: dw: serialize error recovery with channel termination James Hilliard
2026-10-23 16:34 ` sashiko-bot
2026-10-28 16:24 ` Frank Li
2026-10-23 16:27 ` [PATCH v3 3/4] dmaengine: dw: Prevent tx-status calling DMA-desc callback James Hilliard
2026-10-23 16:40 ` sashiko-bot [this message]
2026-10-28 16:28 ` Frank Li
2026-10-23 16:27 ` [PATCH v3 4/4] dmaengine: dw: synchronize completion callbacks James Hilliard
2026-10-23 16:35 ` sashiko-bot
2026-10-28 16:32 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-182959@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=james.hilliard1@gmail.com \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.