Re: [PATCH 4/7] RDMA/zrdma: Add hardware resource initialization and verbs skeleton

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] RDMA/zrdma: accidental deletion of zrdma_main.c breaks build
--

commit e05483ee5929bdb338026257200504048dace255
Author: Yanze Zhang <zhang.yanze@zte.com.cn>

RDMA/zrdma: Add hardware resource initialization and verbs skeleton

This commit adds hardware resource initialization routines in zrdma_hw.c
and a minimal verbs device registration skeleton in zrdma_verbs.c and
zrdma_verbs.h.

> diff --git a/drivers/infiniband/hw/zrdma/Makefile b/drivers/infiniband/hw/zrdma/Makefile
> index 2ddf50d1fd208..88be835f5c5c2 100644
> --- a/drivers/infiniband/hw/zrdma/Makefile
> +++ b/drivers/infiniband/hw/zrdma/Makefile
> @@ -1,4 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB
>  
>  obj-$(CONFIG_INFINIBAND_ZRDMA) += zrdma.o
> -zrdma-y := zrdma_main.o
> +zrdma-y := \
> +	zrdma_main.o \
> +	zrdma_hw.o \
> +	zrdma_verbs.o
> \ No newline at end of file

[ ... ]

> diff --git a/drivers/infiniband/hw/zrdma/zrdma_main.c b/drivers/infiniband/hw/zrdma/zrdma_main.c
> deleted file mode 100644
> index af1d37be63362..0000000000000
> --- a/drivers/infiniband/hw/zrdma/zrdma_main.c
> +++ /dev/null
> @@ -1,57 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB
> -/*
> - * ZTE DingHai Rdma driver
> - * Copyright (c) 2022-2026, ZTE Corporation
> - */
> -
> -#include <linux/module.h>
> -#include <linux/auxiliary_bus.h>

[ ... ]

> -static int __init zrdma_module_init(void)
> -{
> -	return auxiliary_driver_register(&zxdh_auxiliary_drv);
> -}
> -
> -static void __exit zrdma_module_exit(void)
> -{
> -	auxiliary_driver_unregister(&zxdh_auxiliary_drv);
> -}
> -
> -module_init(zrdma_module_init);
> -module_exit(zrdma_module_exit);

[Severity: High]
Was drivers/infiniband/hw/zrdma/zrdma_main.c deleted here by mistake?

In drivers/infiniband/hw/zrdma/Makefile, zrdma-y still lists zrdma_main.o:

    zrdma-y := \
            zrdma_main.o \
            zrdma_hw.o \
            zrdma_verbs.o

Deleting drivers/infiniband/hw/zrdma/zrdma_main.c in this commit removes
zrdma_module_init(), zrdma_module_exit(), zxdh_probe(), and zxdh_remove(),
and causes the build to fail when building drivers/infiniband/hw/zrdma/
because there is no rule to make target zrdma_main.o.

Although a later commit in the series ("RDMA/zrdma: Add device probe and
remove logic") re-adds drivers/infiniband/hw/zrdma/zrdma_main.c, leaving it
deleted here breaks the build and git bisection at this commit.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261024071539.2182864-1-zhang.yanze@zte.com.cn?part=4