Re: [PATCH v5] arm64: dts: qcom: sm7125-samsung: add initial device tree

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] arm64: dts: qcom: sm7125-samsung: missing unit-address on rmtfs_mem node
- [Low] arm64: dts: qcom: sm7125-samsung: unit-address without reg on framebuffer
--

commit 0db97bf83930cb651c62d03dfabe385a7334be7f
Author: Erikas Bitovtas <xerikasxx@gmail.com>

arm64: dts: qcom: sm7125-samsung: add initial device tree

This commit adds the initial device trees for the Samsung Galaxy A52 (a52q)
and Galaxy A72 (a72q) based on the Qualcomm SM7125 platform, along with
their shared common device tree include file.

> diff --git a/arch/arm64/boot/dts/qcom/sm7125-samsung-common.dtsi b/arch/arm64/boot/dts/qcom/sm7125-samsung-common.dtsi
> new file mode 100644
> index 0000000000000..3a8339395d6cb
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm7125-samsung-common.dtsi
> @@ -0,0 +1,583 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * SM7125 Samsung common device tree source
> + *
> + * Copyright (c) 2026, Erikas Bitovtas. All rights reserved.
> + */
> +
> +#include <dt-bindings/arm/qcom,ids.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
> +#include "sm7125.dtsi"
> +#include "pm6150.dtsi"
> +#include "pm6150l.dtsi"
> +
> +/delete-node/ &rmtfs_mem;
> +/delete-node/ &ipa_fw_mem;
> +/delete-node/ &tz_mem;
> +
> +/ {
> +	chassis-type = "handset";
> +
> +	qcom,msm-id = <QCOM_ID_SM7125 0x0>;
> +
> +	chosen {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		framebuffer@9c000000 {
> +			compatible = "simple-framebuffer";
> +			memory-region = <&cont_splash_mem>;
> +			width = <1080>;
> +			height = <2400>;
> +			stride = <(1080 * 4)>;
> +			format = "a8r8g8b8";
> +			clocks = <&gcc GCC_DISP_HF_AXI_CLK>;
> +		};
> +	};

[Severity: Low]
Since the simple-framebuffer node under chosen uses memory-region =
<&cont_splash_mem> instead of a reg property, does naming it
framebuffer@9c000000 trigger a dtc unit_address_vs_reg warning during W=1
DTB builds?

In scripts/dtc/checks.c, check_unit_address_vs_reg() warns when a node has
a unit name without a reg or ranges property:

scripts/dtc/checks.c:check_unit_address_vs_reg() {
	...
	} else {
		if (unitname[0])
			FAIL(c, dti, node, "node has a unit name, but no reg or ranges property");
	}
}

Should this node be named framebuffer without the @9c000000 unit-address
(and without #address-cells, #size-cells, and ranges in chosen)?

[ ... ]

> +		pstore_mem: ramoops@b4600000 {
> +			compatible = "ramoops";
> +			reg = <0x0 0xb4600000 0x0 0x100000>;
> +			record-size = <0x40000>;
> +			console-size = <0x40000>;
> +			ftrace-size = <0x40000>;
> +			pmsg-size = <0x40000>;
> +		};
> +
> +		rmtfs_mem: memory {
> +			compatible = "qcom,rmtfs-mem";
> +			qcom,use-guard-pages;
> +			no-map;
> +
> +			qcom,client-id = <1>;
> +			qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>;
> +		};
> +	};

[Severity: Low]
Here rmtfs_mem is defined under reserved-memory with the node name memory
and no unit-address, while sm7125-samsung-a52q.dts and
sm7125-samsung-a72q.dts override &rmtfs_mem by label to add a reg property:

arch/arm64/boot/dts/qcom/sm7125-samsung-a52q.dts:
&rmtfs_mem {
	reg = <0x0 0xf4f00000 0x0 0x202000>;
};

arch/arm64/boot/dts/qcom/sm7125-samsung-a72q.dts:
&rmtfs_mem {
	reg = <0x0 0xf3700000 0x0 0x202000>;
};

Because referencing &rmtfs_mem merges reg into /reserved-memory/memory
without adding a unit-address to the node name, won't this trigger a dtc
warning in check_unit_address_vs_reg() under W=1 and a dtbs_check schema
violation?

scripts/dtc/checks.c:check_unit_address_vs_reg() {
	...
	if (prop) {
		if (!unitname[0])
			FAIL(c, dti, node, "node has a reg or ranges property, but no unit name");
	} else {
	...
}

Since the two boards use different base addresses for rmtfs_mem, should the
rmtfs_mem node be defined with its respective unit-address (memory@f4f00000
and memory@f3700000) in each board's .dts file instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261024-sm7125-samsung-v5-1-5a602ab00626@gmail.com?part=1