From: sashiko-bot@kernel.org
To: "Janne Grunau" <j@jannau.net>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: apple: Avoid PERST# deassertion through gpiod initialization
Date: Sat, 24 Oct 2026 16:58:10 +0000 [thread overview]
Message-ID: <sashiko-outbox-183808@kernel.org> (raw)
In-Reply-To: <20261024-pcie-apple-perst-gpiod-init-v1-1-f92f30f205ef@jannau.net>
> Commit 87620512681a ("PCI: apple: Fix PERST# polarity") switched the
> PERST# polarity by annotaing its GPIO as active low in the device tree
> via [1]. It missed to update gpiod_get()'s flags to GPIOD_OUT_HIGH
> resulting in deasserting PERST# through gpiod initialization.
> The Aquantia AQC113 10GB ethernet device used in some Apple silicon
> desktop does not finish link training with this additional PERST#
> deassert before the usual PERST# dance.
>
> Link: https://lore.kernel.org/linux-pci/20211123180636.80558-1-maz@kernel.org/ [1]
> Fixes: 87620512681a ("PCI: apple: Fix PERST# polarity")
> Cc: stable@vger.kernel.org
> Signed-off-by: Janne Grunau <j@jannau.net>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261024-pcie-apple-perst-gpiod-init-v1-1-f92f30f205ef@jannau.net?part=1
next prev parent reply other threads:[~2026-10-24 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 16:46 [PATCH] PCI: apple: Avoid PERST# deassertion through gpiod initialization Janne Grunau
2026-10-24 16:58 ` sashiko-bot [this message]
2026-10-25 9:59 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-183808@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=j@jannau.net \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.