Re: [PATCH perf-tools-next v10 03/10] perf ftrace: Support filtering return address comments

[sashiko-bot@kernel.org]

> When tracing with the Linux kernel's function graph tracer, enabling
> funcgraph-retaddr records the return address of each function entry as
> a comment in the trace stream (e.g. /* <-load_elf_phdrs+0x6c/0xb0 */).
> Whilst valuable for tracing execution origins, these trailing comments
> can add considerable visual clutter to the call graph, particularly
> when examining deeply nested call trees or when synthesising higher-level
> abstractions.
> 
> Introduce support for filtering out return address comments from
> function graph trace output whenever return address display is not
> explicitly requested via --graph-opts retaddr.
> 
> Key aspects of this implementation:
> 
>     1.  Return address parsing and filtering
> [ ... ]
>         Add a dedicated unit test suite ("Ftrace return address
>         processing") in tools/perf/tests/ftrace.c to validate comment
>         parsing and string filtering across all supported formats.
> 
> Signed-off-by: Aaron Tomlin <atomlin@atomlin.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261024212549.450634-1-atomlin@atomlin.com?part=3