From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59F1F606A31E for ; Sun, 25 Oct 2026 03:37:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=vSrYvNuL; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=cJygGthz DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=fkxHxvEKnkGgyNeickZWclSiudDJWVqGc6PDoxtgCRI=; b=vSrYvNuL17olHlJHvyIiRwUKOu YNv0HVQ53/Sq0vfnHZwvJvhAS/MjS2pjJsncQDfZTu6gj1frk87395VJAtmqUJD1jQT1mF0+le5bI gR2btVgyhraH7mIRP/lUUc5mu8MZncfNxMxQNPrT+QFjBvPF88zt8oRflxBVD6fiyzAQLI3WZqs0I RZH0+PxEMCzW4cPcA49TRU25Ag2syfE7CeEIz8dTY2EfAJc8tGSGV8ftEI143edgiepUVbcIG1rrG QDEguvypt2qma/76R1yw4SXM9ZvlNV6FE9fsF+prQpej3j7wX5st1kPKzwjRxvldztoBhWltu5BN2 s2H3P7tg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xKp30-00000000hGF-05YU; Sun, 25 Oct 2026 03:37:26 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xKp2x-00000000hG8-3joa for linux-phy@lists.infradead.org; Sun, 25 Oct 2026 03:37:24 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id BBDE4600D4; Sun, 25 Oct 2026 03:37:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0103E1F01825; Sun, 25 Oct 2026 03:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792899442; bh=DNrd9zf1g0/1vsLw/Gwfafp9ltT5ubtSaLG4hUj3UHM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=cJygGthzhS24It1g9cfKgQQUKCsjn5F8Wq+M90rVwkJMzbLvhNZ4dHZFCNKX6Ip/n kPhQGvvtNyPa+VX78GkvpQqxSa6s79me7Y3PrrQ6Z9g1HTRjwh2aqpuZB3pMKRfdMt tLdCVHEVxAskIfgi+B/KYBMEnLKKLAXUhEu2ZKeoYiB/6wzYg6u83AxGfCLqYNyGrs gR50/TekZZT164GkwtzJu4fcHVllOSdsBuDp/daMv5+ZPjvyg7G+4rxVv646sH/KAx moD39uMFYUTcjJFqybmx5BaxDZSWInBlBFcidlkUyn2mR/3mqYYUqAAVNz82wLFzv9 3zQLyKpL4/ikA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v22 10/14] media: qcom: camss: tpg: Add support for v2.4.0 TPG To: "Hangxiang Ma" Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, media-ci@linuxtv.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261024-kaanapali-camss-v22-10-7da3ea49c8a1@oss.qualcomm.com> References: <20261024-kaanapali-camss-v22-0-7da3ea49c8a1@oss.qualcomm.com> <20261024-kaanapali-camss-v22-10-7da3ea49c8a1@oss.qualcomm.com> Date: Sun, 25 Oct 2026 03:37:21 +0000 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gbWVkaWE6IHFjb206 IGNhbXNzOiB1bmluaXRpYWxpemVkIGh3X3ZlcnNpb24gY2hlY2sgaW4gdHBnX3Jlc2V0KCkKLS0K CmNvbW1pdCAwODEwZWFmZDdhZjhhM2M5MDk1NmE4MGE1MTMyMTg3ZTYzNDUzMWU1CkF1dGhvcjog SGFuZ3hpYW5nIE1hIDxoYW5neGlhbmcubWFAb3NzLnF1YWxjb21tLmNvbT4KCm1lZGlhOiBxY29t OiBjYW1zczogdHBnOiBBZGQgc3VwcG9ydCBmb3IgdjIuNC4wIFRQRwoKVGhpcyBwYXRjaCBhZGRz IHN1cHBvcnQgZm9yIFRQRyBoYXJkd2FyZSB2ZXJzaW9uIDIuNC4wIG9uIEthYW5hcGFsaSwgdXNp bmcKdGhlIFRQR19DVFJMX0NNRCByZWdpc3RlciBmb3IgdGVzdC1lbmFibGUgYW5kIHJlc2V0LCBy b3V0aW5nIFRQRyBvdXRwdXQKdGhyb3VnaCB0aGUgQ1NJRCAxMDgwIENTSTIgVFBHIG11eCwgYW5k IHdpcmluZyB1cCB0aGUgVFBHIHJlc291cmNlcyBmb3IKS2FhbmFwYWxpLgoKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9xY29tL2NhbXNzL2NhbXNzLXRwZy1nZW4xLmMgYi9k cml2ZXJzL21lZGlhL3BsYXRmb3JtL3Fjb20vY2Ftc3MvY2Ftc3MtdHBnLWdlbjEuYwo+IGluZGV4 IGQyOWRlNWY5M2MxOGUuLmNhYmJiMjYzOGNmMzggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9tZWRp YS9wbGF0Zm9ybS9xY29tL2NhbXNzL2NhbXNzLXRwZy1nZW4xLmMKPiArKysgYi9kcml2ZXJzL21l ZGlhL3BsYXRmb3JtL3Fjb20vY2Ftc3MvY2Ftc3MtdHBnLWdlbjEuYwoKWyAuLi4gXQoKPiBAQCAt MTY0LDE4ICsxNjcsMjYgQEAgc3RhdGljIGludCB0cGdfc3RyZWFtX29uKHN0cnVjdCB0cGdfZGV2 aWNlICp0cGcpCgpbIC4uLiBdCgo+ICBzdGF0aWMgaW50IHRwZ19yZXNldChzdHJ1Y3QgdHBnX2Rl dmljZSAqdHBnKQo+ICB7Cj4gLQl3cml0ZWwoMCwgdHBnLT5iYXNlICsgVFBHX0NUUkwpOwo+IC0J d3JpdGVsKDEsIHRwZy0+YmFzZSArIFRQR19DTEVBUik7Cj4gKwlpZiAodHBnLT5od192ZXJzaW9u IDwgVFBHX0hXX1ZFUl8yXzRfMCkKPiArCQl3cml0ZWwoMCwgdHBnLT5iYXNlICsgVFBHX0NUUkwp Owo+ICsKPiArCXdyaXRlbChUUEdfQ1RSTF9DTURfSFdfUkVTRVQsIHRwZy0+YmFzZSArIFRQR19D VFJMX0NNRCk7Cj4gIAo+ICAJcmV0dXJuIDA7Cj4gIH0KCltTZXZlcml0eTogTWVkaXVtXQpJcyB0 cGctPmh3X3ZlcnNpb24gaW5pdGlhbGl6ZWQgd2hlbiB0cGdfcmVzZXQoKSBpcyBjYWxsZWQgZm9y IHRoZSBmaXJzdAp0aW1lPwoKSW4gZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9xY29tL2NhbXNzL2Nh bXNzLXRwZy5jLCB0cGdfc2V0X3Bvd2VyKCkgY2FsbHMKcmVzZXQoKSBiZWZvcmUgY2FsbGluZyBo d192ZXJzaW9uKCk6Cgpkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3Fjb20vY2Ftc3MvY2Ftc3MtdHBn LmM6dHBnX3NldF9wb3dlcigpIHsKCWlmIChvbikgewoJCS4uLgoJCXRwZy0+cmVzLT5od19vcHMt PnJlc2V0KHRwZyk7CgoJCXRwZy0+cmVzLT5od19vcHMtPmh3X3ZlcnNpb24odHBnKTsKCX0KfQoK U2luY2UgdHBnLT5od192ZXJzaW9uIGlzIG9ubHkgcG9wdWxhdGVkIGluIHRwZ19od192ZXJzaW9u KCkgYW5kIHN0YXJ0cyBhdCAwCmZyb20gdGhlIGluaXRpYWwgZGV2bV9rY2FsbG9jKCkgaW4gY2Ft c3NfcHJvYmUoKSwgd29uJ3QgdGhlIGZpcnN0IHBvd2VyLW9uCm9mIGEgdjIuNC4wIFRQRyBldmFs dWF0ZSAwIDwgVFBHX0hXX1ZFUl8yXzRfMCBhcyB0cnVlIGFuZCBzdGlsbCB3cml0ZSAwIHRvClRQ R19DVFJMPwoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9w YXRjaHNldC8yMDI2MTAyNC1rYWFuYXBhbGktY2Ftc3MtdjIyLTAtN2RhM2VhNDljOGExQG9zcy5x dWFsY29tbS5jb20/cGFydD0xMAoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5 QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtcGh5Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792899443; b=x/9yuTzNVreKizcANp1b6hJaTwbPwO3qOmCW28OdyjWqPjzGLUoNEXDw04pP6Dhz3rBH kLA6upvwVL4Sihkq52DiYkjaAUfsWKNXrcRpCzDFeu/FGwuQJzQ5W6udmI2bc2EjoszmD uPZKG3QQOm4cvQYCptZDkVwcvnvAfq+gbuAi7AHGe31KMzBYZDzChlnge/P0YaBTBGD70 obef3GZVocFTD8UbGWBnEDy2uWmop1CbEOqPJEjV/sFhC26eqOhp7bFt1hXnpGJVObYy4 eaS/VDYlLWhJ1tD9QVCnQy8CPS0PqBII5wECy+AqecDZ25+llV1gC3R9LzbJPLYXqaA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792899443; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=DNrd9zf1g0/1vsLw/Gwfafp9ltT5ubtSaLG4hUj3UHM=; b=OCgXWFR+5qmia0nRJutuEYgqRzQByOtu2aJ5nEisfjwrh5D6bcnmZhxQMnb+uK0GIYCX qBEsMVieRe1EFK2w/f80V+Q3jha/xS+ISceKe6p9skBLiXzOrNwUeRSnkcL6wIiYm0JzG hvAiELLv2XYhtqROI9ew2gOhgRhwYvFeSh8/P93GKWqoVa5XLInNGL2R0qiZZj3SdozHv vxsp+/h2s04gbQadTi2NbuKoIZG7X3XzGtJnuKucFZiDfDigtIimQyanm8mzwTG7mZjWN hiaVlV9VjHeI3CZ7p0KikJJ6y6nAGlI1dYUso+on9wZBXuQHV3cXlqseCaAuh4hQ9Rg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=cJygGthz; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1FDE606A31E for ; Sun, 25 Oct 2026 03:37:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=cJygGthz Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0103E1F01825; Sun, 25 Oct 2026 03:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792899442; bh=DNrd9zf1g0/1vsLw/Gwfafp9ltT5ubtSaLG4hUj3UHM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=cJygGthzhS24It1g9cfKgQQUKCsjn5F8Wq+M90rVwkJMzbLvhNZ4dHZFCNKX6Ip/n kPhQGvvtNyPa+VX78GkvpQqxSa6s79me7Y3PrrQ6Z9g1HTRjwh2aqpuZB3pMKRfdMt tLdCVHEVxAskIfgi+B/KYBMEnLKKLAXUhEu2ZKeoYiB/6wzYg6u83AxGfCLqYNyGrs gR50/TekZZT164GkwtzJu4fcHVllOSdsBuDp/daMv5+ZPjvyg7G+4rxVv646sH/KAx moD39uMFYUTcjJFqybmx5BaxDZSWInBlBFcidlkUyn2mR/3mqYYUqAAVNz82wLFzv9 3zQLyKpL4/ikA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v22 10/14] media: qcom: camss: tpg: Add support for v2.4.0 TPG Reply-To: sashiko-reviews@lists.linux.dev To: "Hangxiang Ma" Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, media-ci@linuxtv.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261024-kaanapali-camss-v22-10-7da3ea49c8a1@oss.qualcomm.com> References: <20261024-kaanapali-camss-v22-0-7da3ea49c8a1@oss.qualcomm.com> <20261024-kaanapali-camss-v22-10-7da3ea49c8a1@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sun, 25 Oct 2026 03:37:21 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] media: qcom: camss: uninitialized hw_version check in tpg_reset() -- commit 0810eafd7af8a3c90956a80a5132187e634531e5 Author: Hangxiang Ma media: qcom: camss: tpg: Add support for v2.4.0 TPG This patch adds support for TPG hardware version 2.4.0 on Kaanapali, using the TPG_CTRL_CMD register for test-enable and reset, routing TPG output through the CSID 1080 CSI2 TPG mux, and wiring up the TPG resources for Kaanapali. > diff --git a/drivers/media/platform/qcom/camss/camss-tpg-gen1.c b/drivers= /media/platform/qcom/camss/camss-tpg-gen1.c > index d29de5f93c18e..cabbb2638cf38 100644 > --- a/drivers/media/platform/qcom/camss/camss-tpg-gen1.c > +++ b/drivers/media/platform/qcom/camss/camss-tpg-gen1.c [ ... ] > @@ -164,18 +167,26 @@ static int tpg_stream_on(struct tpg_device *tpg) [ ... ] > static int tpg_reset(struct tpg_device *tpg) > { > - writel(0, tpg->base + TPG_CTRL); > - writel(1, tpg->base + TPG_CLEAR); > + if (tpg->hw_version < TPG_HW_VER_2_4_0) > + writel(0, tpg->base + TPG_CTRL); > + > + writel(TPG_CTRL_CMD_HW_RESET, tpg->base + TPG_CTRL_CMD); > =20 > return 0; > } [Severity: Medium] Is tpg->hw_version initialized when tpg_reset() is called for the first time? In drivers/media/platform/qcom/camss/camss-tpg.c, tpg_set_power() calls reset() before calling hw_version(): drivers/media/platform/qcom/camss/camss-tpg.c:tpg_set_power() { if (on) { ... tpg->res->hw_ops->reset(tpg); tpg->res->hw_ops->hw_version(tpg); } } Since tpg->hw_version is only populated in tpg_hw_version() and starts at 0 from the initial devm_kcalloc() in camss_probe(), won't the first power-on of a v2.4.0 TPG evaluate 0 < TPG_HW_VER_2_4_0 as true and still write 0 to TPG_CTRL? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261024-kaanapali-= camss-v22-0-7da3ea49c8a1@oss.qualcomm.com?part=3D10