All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Joonho Lee" <mynameisjune111@gmail.com>
Cc: virtualization@lists.linux.dev,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH v4 2/2] ALSA: virtio-snd: fix dsnoop capture with staged buffers
Date: Sun, 25 Oct 2026 07:22:46 +0000	[thread overview]
Message-ID: <sashiko-outbox-184111@kernel.org> (raw)
In-Reply-To: <20261025064038.81674-3-mynameisjune111@gmail.com>

> dsnoop runs its hardware slave with stop_threshold == boundary and can
> consume the mmap capture ring without advancing the hardware application
> pointer. Staged capture currently treats every stream as a bounded
> consumer: capture_ready grows until the completion capacity check fails.
> 
> With a 48 kHz mono slave, 960-frame periods and a 7680-frame buffer, the
> baseline dsnoop reproduction stops after 6720 frames with -EPIPE and a
> ring_capacity rejection. Direct capture continues to work.
> 
> Cache the prepared boundary and recognize the free-running policy under
> the substream lock. Keep RX requests supplied in that mode, while retaining
> payload, frame alignment, counter and pointer-window checks. Sample the
> policy once per completion so validation, copying and refill agree.
> Refresh it separately in the ACK accounting and refill critical sections.
> 
> [ ... ]
> regression also pass with KASAN and lockdep. No new physical-device or
> KCSAN results are claimed for this revision.
> 
> Assisted-by: LLM
> Signed-off-by: Joonho Lee <mynameisjune111@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261025064038.81674-1-mynameisjune111@gmail.com?part=2


  reply	other threads:[~2026-10-25  7:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-25  6:40 [PATCH v4 0/2] ALSA: virtio-snd: fix dsnoop capture with staged buffers Joonho Lee
2026-10-25  6:40 ` [PATCH v4 1/2] ALSA: pcm: mark stop-threshold accesses for capture policy sampling Joonho Lee
2026-10-25  6:44   ` sashiko-bot
2026-10-25  6:40 ` [PATCH v4 2/2] ALSA: virtio-snd: fix dsnoop capture with staged buffers Joonho Lee
2026-10-25  7:22   ` sashiko-bot [this message]
2026-10-27  9:15 ` [PATCH v4 0/2] " Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-184111@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=eperezma@redhat.com \
    --cc=mst@redhat.com \
    --cc=mynameisjune111@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.