From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792957382; b=WzTjy2KRm02oUD0WeSiezfDxG+nKWzIFHRaOVGpJ3raEJBnprt6Rr909bg8LRlFrP165 98SaGVQh6FHLk1NsVPvLBsQ7+nX6gcwlro3OyAxQ6RNEK2WIlfL0IVbJx8ayKtSTSyJ0Q 65ebQBUkurFpgKMl9wMSbl3hh9PCQxocbNrXoxvyKt9gpvKTsfiZ/e2YHdG4zAmkqZPxf aJZFv/4n0HPVhLSJc0KbE+wZG/QWeV0yhmPIavNoKsw1LnVmOMzsbkyo2jI4uAmq0flnz 6Um+XKx+GSIwYZV5VLJtJOzCOrpqZ2C4UIK378N0ymBJSn54BNCPi4vZof+j0CC4umg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792957382; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=8h8F/ulXVgUyzmdy0weLIC0OOzaMsDaQfyRgn9jCG5g=; b=2zs3TmRlIoAjYFpGwoW5hxET8ElJB/+COEjJH0rSqdMlGKyVwqQxSNTwNRNX8+ahBFkb gvwJkGVbEOyChkUMA+yVB4NCQkDPRWaOXlAE6usLPL5q+7W2Jb3M9picPbHkiIAIMrV7r 3vxfdCxbDcsBcD5xlPSRwheB4hHtqisZf6/uZ0xSG5r5WtPVNWQT2UPhgGzfaTZLJR26l aETXQE2mD77YV5MRC4ekMrAWvNowRFudWxfbuhib82joiN0ACkb+1/h+vgLST/k7tKp3l vn9U3WClbelnDOQJ3d/H7fzoE0FXBiocvBro1ZulTA6gPie8M2osgDjDGAol282LhBg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=bUmDhlcV; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E387C606A31E for ; Sun, 25 Oct 2026 19:43:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=bUmDhlcV Received: by smtp.kernel.org (Postfix) with ESMTPSA id 650341F01828; Sun, 25 Oct 2026 19:43:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792957381; bh=8h8F/ulXVgUyzmdy0weLIC0OOzaMsDaQfyRgn9jCG5g=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=bUmDhlcVyXuNR9lm4fFX+bOcycqGAbhiP2qum3eh1llzGHrxWVPtvOgJ2/z0NduVw qHobfekG3qtnbEcaCQULrwT1eYaoo8YjykcshjbBlElwRuYvnGSpAiVAhJFqI+ibgu 7zPvbB1DzxABrvTK15p4Vg9j8NrxaUAePZdvfeqsqWLUfvQ/eBUaeR3pjxFOHEHX69 PDLjYdnJ+x1rt8UOtNbzLDh6x/HB4yLclFwl8Xe2MRkQbyjwBjPLL2XjOpMueyz8Zp o6wQst48fMJSKSXvJ4xYzQkds+35NvBLW3DucfC6NTvkVVs1Xbc6p/NnADfN6kmUkx Y6gulkO9NtwxA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 1/3] dt-bindings: thermal: amlogic: add the S4 CPU sensor Reply-To: sashiko-reviews@lists.linux.dev To: christian.koever-draxl@student.uibk.ac.at Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20261025192244.209256-2-christian.koever-draxl@student.uibk.ac.at> References: <20261025192244.209256-1-christian.koever-draxl@student.uibk.ac.at> <20261025192244.209256-2-christian.koever-draxl@student.uibk.ac.at> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sun, 25 Oct 2026 19:43:01 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] dt-bindings: thermal: amlogic: missing bus clock constraint for = S4 sensor -- commit b2d42a2f90c7882650efb090daff31a9ed1ad3e0 Author: Christian Stefan K=C3=B6v=C3=A9r-Draxl dt-bindings: thermal: amlogic: add the S4 CPU sensor This commit adds the amlogic,s4-cpu-thermal compatible string to the Amlogic thermal binding schema for the S4 CPU temperature sensor. > diff --git a/Documentation/devicetree/bindings/thermal/amlogic,thermal.ya= ml b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml > index e72cb39ac635d..5d966ab4d820e 100644 > --- a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml > +++ b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml > @@ -23,6 +23,7 @@ properties: > - const: amlogic,g12a-thermal > - enum: > - amlogic,a1-cpu-thermal > + - amlogic,s4-cpu-thermal > - amlogic,t7-thermal > =20 > reg: [Severity: Medium] Should amlogic,s4-cpu-thermal also require two clocks (bus and core) in the allOf conditional block, or use amlogic,t7-thermal as a fallback compatible? In Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml, the seco= nd allOf conditional checks only for amlogic,t7-thermal: - if: properties: compatible: contains: const: amlogic,t7-thermal then: properties: clocks: minItems: 2 required: - clock-names else: properties: clocks: maxItems: 1 clock-names: false Because amlogic,s4-cpu-thermal is omitted from that condition, it falls into the else branch, which restricts clocks to a single entry and forbids clock-names. In commit 8195b945794c ("dt-bindings: thermal: amlogic: describe bus clock for t7-thermal"), the single-clock else branch was retained only for older bindings to avoid breaking existing device trees, whereas T7 requires both the peripheral bus gate clock and the shared core clock. Looking at drivers/clk/meson/s4-peripherals.c, S4 has the same clock topolo= gy as T7, with dedicated per-sensor bus gate clocks (s4_ts_ddr / CLKID_TS_DDR and s4_ts_pll / CLKID_TS_PLL) in addition to the shared functional clock (s4_ts_clk / CLKID_TS): drivers/clk/meson/s4-peripherals.c: static S4_PCLK(s4_ts_ddr, CLKCTRL_SYS_CLK_EN0_REG1, 15, CLK_IGNORE_UNUSED); static S4_PCLK(s4_ts_pll, CLKCTRL_SYS_CLK_EN0_REG1, 16, CLK_IGNORE_UNUSED); Without allowing both clocks in the binding, device tree nodes using amlogic,s4-cpu-thermal cannot describe the sensor's peripheral bus gate clo= ck for amlogic_thermal_probe() to manage via devm_clk_bulk_get_all(), leaving the sensor reliant on the temporary CLK_IGNORE_UNUSED flag on s4_ts_pll. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261025192244.2092= 56-1-christian.koever-draxl@student.uibk.ac.at?part=3D1 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5FDD606A31B for ; Sun, 25 Oct 2026 19:43:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=SjpUF7OU; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=bUmDhlcV DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=HLBNTZ/kBM1u39HwZzi+ZXbntb9NV9D4uuQcTuWjcZw=; b=SjpUF7OUuDju9ta83oXihkag+d snmJ2Mz3/G5M3C8FsfvHorI98KVdka1tTmnEfjWhdgiTLx/tl+1mAz8zdpfa0Q42Hw7R1NQ7bNAuf hzmIQetgfIFYL9efWVbesZLKUcDs/FXC4SBWJV/Lo+/PZAVg+Gg3KUHJRHN8KoD2DhdFpAFl16+mm JlPvqVwuYs+Lb3uWP7YF6lIB6IjJ6DRTsGUv+5uvGu67m+C9Tpc5VPbudTA10uZrMZlKuUI1VhcwG CIM+WwXrvrKmQjbtFxCEReINcMbHrk1dXTMgDUb5PGMrEzORduBesJLG7qKb5bA+y1esMyJitJ83J d6DADgRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xL47V-00000001O9c-2BK8; Sun, 25 Oct 2026 19:43:05 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xL47S-00000001O8n-42EB for linux-amlogic@lists.infradead.org; Sun, 25 Oct 2026 19:43:03 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 0824060120; Sun, 25 Oct 2026 19:43:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 650341F01828; Sun, 25 Oct 2026 19:43:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792957381; bh=8h8F/ulXVgUyzmdy0weLIC0OOzaMsDaQfyRgn9jCG5g=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=bUmDhlcVyXuNR9lm4fFX+bOcycqGAbhiP2qum3eh1llzGHrxWVPtvOgJ2/z0NduVw qHobfekG3qtnbEcaCQULrwT1eYaoo8YjykcshjbBlElwRuYvnGSpAiVAhJFqI+ibgu 7zPvbB1DzxABrvTK15p4Vg9j8NrxaUAePZdvfeqsqWLUfvQ/eBUaeR3pjxFOHEHX69 PDLjYdnJ+x1rt8UOtNbzLDh6x/HB4yLclFwl8Xe2MRkQbyjwBjPLL2XjOpMueyz8Zp o6wQst48fMJSKSXvJ4xYzQkds+35NvBLW3DucfC6NTvkVVs1Xbc6p/NnADfN6kmUkx Y6gulkO9NtwxA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 1/3] dt-bindings: thermal: amlogic: add the S4 CPU sensor To: christian.koever-draxl@student.uibk.ac.at Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20261025192244.209256-2-christian.koever-draxl@student.uibk.ac.at> References: <20261025192244.209256-1-christian.koever-draxl@student.uibk.ac.at> <20261025192244.209256-2-christian.koever-draxl@student.uibk.ac.at> Date: Sun, 25 Oct 2026 19:43:01 +0000 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gZHQtYmluZGluZ3M6 IHRoZXJtYWw6IGFtbG9naWM6IG1pc3NpbmcgYnVzIGNsb2NrIGNvbnN0cmFpbnQgZm9yIFM0IHNl bnNvcgotLQoKY29tbWl0IGIyZDQyYTJmOTBjNzg4MjY1MGVmYjA5MGRhZmYzMWE5ZWQxYWQzZTAK QXV0aG9yOiBDaHJpc3RpYW4gU3RlZmFuIEvDtnbDqXItRHJheGwgPGNrb2V2ZXJAb3V0bG9vay5k ZT4KCmR0LWJpbmRpbmdzOiB0aGVybWFsOiBhbWxvZ2ljOiBhZGQgdGhlIFM0IENQVSBzZW5zb3IK ClRoaXMgY29tbWl0IGFkZHMgdGhlIGFtbG9naWMsczQtY3B1LXRoZXJtYWwgY29tcGF0aWJsZSBz dHJpbmcgdG8gdGhlIEFtbG9naWMKdGhlcm1hbCBiaW5kaW5nIHNjaGVtYSBmb3IgdGhlIFM0IENQ VSB0ZW1wZXJhdHVyZSBzZW5zb3IuCgo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2Rldmlj ZXRyZWUvYmluZGluZ3MvdGhlcm1hbC9hbWxvZ2ljLHRoZXJtYWwueWFtbCBiL0RvY3VtZW50YXRp b24vZGV2aWNldHJlZS9iaW5kaW5ncy90aGVybWFsL2FtbG9naWMsdGhlcm1hbC55YW1sCj4gaW5k ZXggZTcyY2IzOWFjNjM1ZC4uNWQ5NjZhYjRkODIwZSAxMDA2NDQKPiAtLS0gYS9Eb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdGhlcm1hbC9hbWxvZ2ljLHRoZXJtYWwueWFtbAo+ICsr KyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy90aGVybWFsL2FtbG9naWMsdGhl cm1hbC55YW1sCj4gQEAgLTIzLDYgKzIzLDcgQEAgcHJvcGVydGllczoKPiAgICAgICAgICAgIC0g Y29uc3Q6IGFtbG9naWMsZzEyYS10aGVybWFsCj4gICAgICAgIC0gZW51bToKPiAgICAgICAgICAg IC0gYW1sb2dpYyxhMS1jcHUtdGhlcm1hbAo+ICsgICAgICAgICAgLSBhbWxvZ2ljLHM0LWNwdS10 aGVybWFsCj4gICAgICAgICAgICAtIGFtbG9naWMsdDctdGhlcm1hbAo+ICAKPiAgICByZWc6Cgpb U2V2ZXJpdHk6IE1lZGl1bV0KU2hvdWxkIGFtbG9naWMsczQtY3B1LXRoZXJtYWwgYWxzbyByZXF1 aXJlIHR3byBjbG9ja3MgKGJ1cyBhbmQgY29yZSkgaW4gdGhlCmFsbE9mIGNvbmRpdGlvbmFsIGJs b2NrLCBvciB1c2UgYW1sb2dpYyx0Ny10aGVybWFsIGFzIGEgZmFsbGJhY2sgY29tcGF0aWJsZT8K CkluIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy90aGVybWFsL2FtbG9naWMsdGhl cm1hbC55YW1sLCB0aGUgc2Vjb25kCmFsbE9mIGNvbmRpdGlvbmFsIGNoZWNrcyBvbmx5IGZvciBh bWxvZ2ljLHQ3LXRoZXJtYWw6CgogIC0gaWY6CiAgICAgIHByb3BlcnRpZXM6CiAgICAgICAgY29t cGF0aWJsZToKICAgICAgICAgIGNvbnRhaW5zOgogICAgICAgICAgICBjb25zdDogYW1sb2dpYyx0 Ny10aGVybWFsCiAgICB0aGVuOgogICAgICBwcm9wZXJ0aWVzOgogICAgICAgIGNsb2NrczoKICAg ICAgICAgIG1pbkl0ZW1zOiAyCiAgICAgIHJlcXVpcmVkOgogICAgICAgIC0gY2xvY2stbmFtZXMK ICAgIGVsc2U6CiAgICAgIHByb3BlcnRpZXM6CiAgICAgICAgY2xvY2tzOgogICAgICAgICAgbWF4 SXRlbXM6IDEKICAgICAgICBjbG9jay1uYW1lczogZmFsc2UKCkJlY2F1c2UgYW1sb2dpYyxzNC1j cHUtdGhlcm1hbCBpcyBvbWl0dGVkIGZyb20gdGhhdCBjb25kaXRpb24sIGl0IGZhbGxzIGludG8K dGhlIGVsc2UgYnJhbmNoLCB3aGljaCByZXN0cmljdHMgY2xvY2tzIHRvIGEgc2luZ2xlIGVudHJ5 IGFuZCBmb3JiaWRzCmNsb2NrLW5hbWVzLgoKSW4gY29tbWl0IDgxOTViOTQ1Nzk0YyAoImR0LWJp bmRpbmdzOiB0aGVybWFsOiBhbWxvZ2ljOiBkZXNjcmliZSBidXMgY2xvY2sKZm9yIHQ3LXRoZXJt YWwiKSwgdGhlIHNpbmdsZS1jbG9jayBlbHNlIGJyYW5jaCB3YXMgcmV0YWluZWQgb25seSBmb3Ig b2xkZXIKYmluZGluZ3MgdG8gYXZvaWQgYnJlYWtpbmcgZXhpc3RpbmcgZGV2aWNlIHRyZWVzLCB3 aGVyZWFzIFQ3IHJlcXVpcmVzIGJvdGgKdGhlIHBlcmlwaGVyYWwgYnVzIGdhdGUgY2xvY2sgYW5k IHRoZSBzaGFyZWQgY29yZSBjbG9jay4KCkxvb2tpbmcgYXQgZHJpdmVycy9jbGsvbWVzb24vczQt cGVyaXBoZXJhbHMuYywgUzQgaGFzIHRoZSBzYW1lIGNsb2NrIHRvcG9sb2d5CmFzIFQ3LCB3aXRo IGRlZGljYXRlZCBwZXItc2Vuc29yIGJ1cyBnYXRlIGNsb2NrcyAoczRfdHNfZGRyIC8gQ0xLSURf VFNfRERSCmFuZCBzNF90c19wbGwgLyBDTEtJRF9UU19QTEwpIGluIGFkZGl0aW9uIHRvIHRoZSBz aGFyZWQgZnVuY3Rpb25hbCBjbG9jawooczRfdHNfY2xrIC8gQ0xLSURfVFMpOgoKZHJpdmVycy9j bGsvbWVzb24vczQtcGVyaXBoZXJhbHMuYzoKc3RhdGljIFM0X1BDTEsoczRfdHNfZGRyLAlDTEtD VFJMX1NZU19DTEtfRU4wX1JFRzEsIDE1LCBDTEtfSUdOT1JFX1VOVVNFRCk7CnN0YXRpYyBTNF9Q Q0xLKHM0X3RzX3BsbCwJQ0xLQ1RSTF9TWVNfQ0xLX0VOMF9SRUcxLCAxNiwgQ0xLX0lHTk9SRV9V TlVTRUQpOwoKV2l0aG91dCBhbGxvd2luZyBib3RoIGNsb2NrcyBpbiB0aGUgYmluZGluZywgZGV2 aWNlIHRyZWUgbm9kZXMgdXNpbmcKYW1sb2dpYyxzNC1jcHUtdGhlcm1hbCBjYW5ub3QgZGVzY3Jp YmUgdGhlIHNlbnNvcidzIHBlcmlwaGVyYWwgYnVzIGdhdGUgY2xvY2sKZm9yIGFtbG9naWNfdGhl cm1hbF9wcm9iZSgpIHRvIG1hbmFnZSB2aWEgZGV2bV9jbGtfYnVsa19nZXRfYWxsKCksIGxlYXZp bmcKdGhlIHNlbnNvciByZWxpYW50IG9uIHRoZSB0ZW1wb3JhcnkgQ0xLX0lHTk9SRV9VTlVTRUQg ZmxhZyBvbiBzNF90c19wbGwuCgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNo aWtvLmRldi8jL3BhdGNoc2V0LzIwMjYxMDI1MTkyMjQ0LjIwOTI1Ni0xLWNocmlzdGlhbi5rb2V2 ZXItZHJheGxAc3R1ZGVudC51aWJrLmFjLmF0P3BhcnQ9MQoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYW1sb2dpYyBtYWlsaW5nIGxpc3QKbGlu dXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo=