From: sashiko-bot@kernel.org
To: "Selby Mashiki" <mashikiselby@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: typec: tcpm: qcom: fix connector fwnode_handle leak in qcom_pmic_typec_port_probe()
Date: Sun, 25 Oct 2026 20:52:44 +0000 [thread overview]
Message-ID: <sashiko-outbox-184441@kernel.org> (raw)
In-Reply-To: <20261025203151.455062-1-mashikiselby@gmail.com>
> In qcom_pmic_typec_port_probe(), device_get_named_child_node(dev,
> "connector") acquires a reference to the connector fwnode_handle to pass
> to_of_node(connector) to devm_of_regulator_get_optional(), but never
> releases the reference.
>
> Call fwnode_handle_put(connector) immediately after
> devm_of_regulator_get_optional() to fix the leak.
>
> Fixes: 506927b6bf29 ("usb: typec: tcpm: qcom: prefer VBUS supply from the connector node")
> Signed-off-by: Selby Mashiki <mashikiselby@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261025203151.455062-1-mashikiselby@gmail.com?part=1
next prev parent reply other threads:[~2026-10-25 20:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 20:31 [PATCH] usb: typec: tcpm: qcom: fix connector fwnode_handle leak in qcom_pmic_typec_port_probe() Selby Mashiki
2026-10-25 20:52 ` sashiko-bot [this message]
2026-10-25 22:00 ` David Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-184441@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mashikiselby@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.