Re: [PATCH v7 1/3] dt-bindings: platform: introduce EC for Dell XPS 13 9345

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: syntax error in dell,xps13-9345-ec.yaml example io-channels
--

commit 6b26d06321d0162521ee363bfa4a27b82eb6cc2e
Author: Aleksandrs Vinarskis <alex@vinarskis.com>

dt-bindings: platform: introduce EC for Dell XPS 13 9345

This commit adds Device Tree bindings for the Embedded Controller (EC) in
the Dell XPS 13 9345 (platform codename tributo).

> diff --git a/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml
> new file mode 100644
> index 0000000000000..29cbb837a31b8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml
> @@ -0,0 +1,90 @@

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        embedded-controller@3b {
> +            compatible = "dell,xps13-9345-ec";
> +            reg = <0x3b>;
> +            interrupts-extended = <&tlmm 66 IRQ_TYPE_LEVEL_LOW>;
> +
> +            io-channels = <&pmk8550_vadc 0x14a>,
> +                          <&pmk8550_vadc 0x14b>,
> +                          <&pmk8550_vadc 0x144>,
> +                          <&pmk8550_vadc 0x145>,
> +                          <&pmk8550_vadc 0x146>,
> +                          <&pmk8550_vadc 0x147>,
> +                          <&pmk8550_vadc 0x148>,
> +            io-channel-names = "sys_therm1",

[Severity: Low]
In the examples section of
Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml,
the last entry of io-channels in embedded-controller@3b ends with a comma
instead of a semicolon before io-channel-names.

Should <&pmk8550_vadc 0x148>, end with a semicolon instead so that
dt_binding_check does not fail with a dtc syntax error when compiling the
example?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261026-dell-xps-9345-ec-v7-0-828ce301b839@vinarskis.com?part=1