From: sashiko-bot@kernel.org
To: "Biju Das" <biju.das.au@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH v3 4/4] serial: sh-sci: Toggle TE when restoring SCSCR in console write on SCI
Date: Mon, 26 Oct 2026 11:54:18 +0000 [thread overview]
Message-ID: <sashiko-outbox-185133@kernel.org> (raw)
In-Reply-To: <20261026-g2ul_sci-v3-4-b3097163edd5@bp.renesas.com>
> From: Au Dang <au.dang.jx@renesas.com>
>
> When SCI0 (PORT_SCI) is the system console on RZ/G2UL, the board can
> hang at the serial console output stage during boot.
>
> ftrace shows the following sequence:
>
> 1. sci_transmit_chars() is draining the TX kfifo through TXI
> interrupts with SCSCR=0xf0 (TE=1, TIE=1, RE=1, RIE=1).
>
> 2. serial_console_write() runs in the middle of that drain. It saves
> SCSCR=0xf0, switches to polling by writing SCSCR=0x30 (TE=1, TIE=0)
> and outputs the characters with sci_poll_put_char().
>
> 3. It then restores SCSCR=0xf0 in a single write. TE is 1 both before
> [ ... ]
> TIE is being re-enabled, so TXI fires and the interrupted drain
> resumes.
>
> Signed-off-by: Au Dang <au.dang.jx@renesas.com>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261026-g2ul_sci-v3-0-b3097163edd5@bp.renesas.com?part=4
next prev parent reply other threads:[~2026-10-26 11:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 11:23 [PATCH v3 0/4] Fix transmit handling on SCI/RSCI ports Biju Das
2026-10-26 11:23 ` [PATCH v3 1/4] serial: sh-sci: Drop TE disable at end of transmission on SCI Biju Das
2026-10-26 11:53 ` sashiko-bot
2026-10-26 11:23 ` [PATCH v3 2/4] serial: sh-sci: Keep TX enabled on TEI while data is pending Biju Das
2026-10-26 12:13 ` sashiko-bot
2026-10-26 11:23 ` [PATCH v3 3/4] serial: sh-sci: Skip TDxE clear when hardware clears it automatically Biju Das
2026-10-26 11:52 ` sashiko-bot
2026-10-26 11:23 ` [PATCH v3 4/4] serial: sh-sci: Toggle TE when restoring SCSCR in console write on SCI Biju Das
2026-10-26 11:54 ` sashiko-bot [this message]
2026-10-27 5:57 ` [PATCH v3 0/4] Fix transmit handling on SCI/RSCI ports Borislav Petkov
2026-10-27 7:19 ` Biju Das
2026-10-27 7:23 ` Krzysztof Kozlowski
2026-10-27 8:33 ` Biju Das
2026-10-27 9:34 ` Krzysztof Kozlowski
2026-10-27 20:54 ` Borislav Petkov
2026-10-28 9:13 ` Biju Das
2026-10-28 11:02 ` Krzysztof Kozlowski
2026-10-28 15:47 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-185133@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=biju.das.au@gmail.com \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.