From: sashiko-bot@kernel.org
To: "Zhang Yi" <yi.zhang@huaweicloud.com>, linux-ext4@vger.kernel.org
Cc: tytso@mit.edu
Subject: Re: [PATCH 2/4] ext4: fix extent status cache clearing when truncating inline data
Date: Mon, 26 Oct 2026 12:47:17 +0000 [thread overview]
Message-ID: <sashiko-outbox-185244@kernel.org> (raw)
In-Reply-To: <20261026115131.1735014-3-yi.zhang@huaweicloud.com>
> From: Zhang Yi <yi.zhang@huawei.com>
>
> ext4_inline_data_truncate() clears the whole extent status tree of the
> inode when it truncates the inline data, with
>
> ext4_es_remove_extent(inode, 0, EXT_MAX_BLOCKS);
>
> It does that when the inode still carries inline data while the
> EXT4_STATE_MAY_INLINE_DATA state bit is already cleared. This is the
> case once an inline-to-extent conversion has been initiated, which is
> triggered by a delalloc buffered write larger than the inline space in
> ext4_da_convert_inline_data_to_extent().
>
> The clear is meant to drop stale extent status entries of such an inode
> to prevent stale extents and stale reserved space after the conversion,
> [ ... ]
>
> Reported-by: syzbot ci <syzbot+ci46f64f7b6a2a188e@syzkaller.appspotmail.com>
> Closes: https://lore.kernel.org/linux-ext4/6ac92a4c.70ed5d86.2ac85.0072.GAE@google.com/
> Fixes: 0add491df4e5 ("ext4: remove extent cache entries when truncating inline data")
> Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261026115131.1735014-1-yi.zhang@huaweicloud.com?part=2
next prev parent reply other threads:[~2026-10-26 12:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 11:51 [PATCH 0/4] ext4: assorted fixes related to the buffered iomap conversion Zhang Yi
2026-10-26 11:51 ` [PATCH 1/4] ext4: return 0 instead of stale ret in ext4_iomap_writepages() Zhang Yi
2026-10-26 12:13 ` sashiko-bot
2026-10-26 11:51 ` [PATCH 2/4] ext4: fix extent status cache clearing when truncating inline data Zhang Yi
2026-10-26 12:47 ` sashiko-bot [this message]
2026-10-26 11:51 ` [PATCH 3/4] ext4: add inode to orphan list before extent conversion Zhang Yi
2026-10-26 13:10 ` sashiko-bot
2026-10-27 8:20 ` Zhang Yi
2026-10-26 11:51 ` [PATCH 4/4] ext4: initialize map->m_pblk in ext4_da_map_blocks() Zhang Yi
2026-10-26 13:12 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-185244@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tytso@mit.edu \
--cc=yi.zhang@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.