From: sashiko-bot@kernel.org
To: "Hamza Mahfooz" <hamzamahfooz@linux.microsoft.com>,
linux-rtc@vger.kernel.org
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH v3 2/2] rtc: efi: defer to the ACPI TAD if it can drive the RTC
Date: Mon, 26 Oct 2026 15:26:40 +0000 [thread overview]
Message-ID: <sashiko-outbox-185436@kernel.org> (raw)
In-Reply-To: <20261026152103.3109313-2-hamzamahfooz@linux.microsoft.com>
> EFI runtime services are best avoided where possible, and ACPI defines a
> standard interface to the RTC in the form of the Time and Alarm Device
> (TAD), which the acpi-tad driver has been exposing as an RTC class
> device since commit 8a1e7f4b1764 ("ACPI: TAD: Add RTC class device
> interface").
>
> So, make rtc-efi decline to probe, before calling GetTime(), if
> acpi_has_rtc() says that the RTC can be driven via the TAD.
>
> Also, to ensure that acpi_has_rtc() is always reachable from rtc-efi
> when ACPI_TAD is enabled, make RTC_DRV_EFI depend on
> ACPI_TAD || !ACPI_TAD.
>
> Suggested-by: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Hamza Mahfooz <hamzamahfooz@linux.microsoft.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261026152103.3109313-1-hamzamahfooz@linux.microsoft.com?part=2
next prev parent reply other threads:[~2026-10-26 15:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 15:21 [PATCH v3 1/2] ACPI: TAD: introduce acpi_has_rtc() Hamza Mahfooz
2026-10-26 15:21 ` [PATCH v3 2/2] rtc: efi: defer to the ACPI TAD if it can drive the RTC Hamza Mahfooz
2026-10-26 15:26 ` sashiko-bot [this message]
2026-10-26 15:30 ` [PATCH v3 1/2] ACPI: TAD: introduce acpi_has_rtc() sashiko-bot
2026-10-27 11:02 ` Ard Biesheuvel
2026-10-27 11:53 ` Rafael J. Wysocki (Intel)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-185436@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=hamzamahfooz@linux.microsoft.com \
--cc=linux-rtc@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.