Re: [PATCH v3 18/22] gpio: Unify style of of_device_id arrays

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] gpio: remaining of_device_id arrays violating stated coding style rules
--

commit bbadc9bb71d86d6711999d534e5d9672f8b1e52e
Author: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>

gpio: Unify style of of_device_id arrays

This commit updates the of_device_id arrays across drivers/gpio/ to follow a
consistent coding style for initializers, spaces around braces, and list
terminators.

[ ... ]

> diff --git a/drivers/gpio/gpio-grgpio.c b/drivers/gpio/gpio-grgpio.c
> index e4fa84e227262..fbbe201cce4ca 100644
> --- a/drivers/gpio/gpio-grgpio.c
> +++ b/drivers/gpio/gpio-grgpio.c
> @@ -444,7 +444,7 @@ static int grgpio_probe(struct platform_device *ofdev)
>  static const struct of_device_id grgpio_match[] = {
>  	{.name = "GAISLER_GPIO"},
>  	{.name = "01_01a"},
> -	{},
> +	{ }
>  };

[Severity: Low]
Should the two non-sentinel entries in grgpio_match[] also have a space after
the opening { and before the closing } to match the style described in the
commit message?

[ ... ]

> diff --git a/drivers/gpio/gpio-realtek-otto.c b/drivers/gpio/gpio-realtek-otto.c
> index 5d98ad597d9e2..46ded0e228827 100644
> --- a/drivers/gpio/gpio-realtek-otto.c
> +++ b/drivers/gpio/gpio-realtek-otto.c
> @@ -356,7 +356,7 @@ static const struct of_device_id realtek_gpio_of_match[] = {
>  		.compatible = "realtek,rtl9607-gpio",
>  		.data = (void *)GPIO_PORTS_REVERSED,
>  	},
> -	{}
> +	{ }
>  };

[Severity: Low]
Earlier in realtek_gpio_of_match[] in drivers/gpio/gpio-realtek-otto.c, the
"realtek,rtl9300-gpio" entry is missing a trailing comma on its .data
initializer even though the closing } is on the next line:

	{
		.compatible = "realtek,rtl9300-gpio",
		.data = (void *)(GPIO_PORTS_REVERSED | GPIO_INTERRUPTS_PER_CPU)
	},

Should a comma be added there as well?

In addition, were the following three of_device_id arrays in drivers/gpio/
intentionally left out, or should they also be updated to match the stated
rules?

drivers/gpio/gpio-bcm-kona.c (bcm_kona_gpio_of_match[], missing space in the
terminator):
	static struct of_device_id const bcm_kona_gpio_of_match[] = {
		{ .compatible = "brcm,kona-gpio" },
		{}
	};

drivers/gpio/gpio-pca953x.c (pca953x_dt_ids[], trailing commas before closing
} on single-line entries):
	static const struct of_device_id pca953x_dt_ids[] = {
		{ .compatible = "nxp,pca6408", .data = OF_953X(8, PCA_INT), },
		...

drivers/gpio/gpio-ppc44x.c (ppc44x_gpio_match[], missing space and trailing
comma on the terminator):
	static const struct of_device_id ppc44x_gpio_match[] = {
		{
			.compatible = "ibm,ppc4xx-gpio",
		},
		{},
	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1793030820.git.u.kleine-koenig@baylibre.com?part=18