All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Tarun Sahu" <tarunsahu@google.com>,
	loganodell@google.com, alex@shazbot.org, dwmw2@infradead.org,
	seanjc@google.com, "Mike Rapoport" <rppt@kernel.org>,
	will@kernel.org, pbonzini@redhat.com, jgg@nvidia.com,
	"Pasha Tatashin" <pasha.tatashin@soleen.com>,
	arnd@arndb.de, "Andrew Morton" <akpm@linux-foundation.org>,
	oupton@kernel.org, baolu.lu@linux.intel.com,
	"David Matlack" <dmatlack@google.com>,
	robin.murphy@arm.com, maz@kernel.org,
	"Alexander Graf" <graf@amazon.com>,
	joro@8bytes.org, "Bjorn Helgaas" <bhelgaas@google.com>,
	kevin.tian@intel.com, "Pratyush Yadav" <pratyush@kernel.org>
Cc: kexec@lists.infradead.org
Subject: Re: [RFC PATCH v3 2/4] liveupdate: Add feature header for fine-grained ABI compatibility
Date: Mon, 26 Oct 2026 17:53:52 +0000	[thread overview]
Message-ID: <sashiko-outbox-185599@kernel.org> (raw)
In-Reply-To: <20261026174217.603114-3-tarunsahu@google.com>

> LUO and its file handlers currently rely solely on coarse-grained
> compatibility strings (such as luo-v5 and memfd-v2) to validate
> handed-over state across kexec. Because compatibility is checked only
> at the whole-structure level, any change to a serialized structure,
> even an optional additive field, requires bumping the compatibility
> string and breaks live update between adjacent kernels.
> 
> Introduce a feature header (struct luo_ser_hdr) ahead of serialized LUO
> structures so subsystems can evolve their serialized state at
> per-feature granularity. Each subsystem groups the fields of its
> serialized structure under feature indices, starting with index 0 for the
> base fields. When a subsystem adds a new capability, it appends any new
> fields to the end of its payload structure under a new feature index.
> Retired fields are kept in place so existing field offsets never shift;
> if the type or format of a field needs to change, the existing field and
> [ ... ]
> Also, introduce the LUO_CORE_FEAT_CORE for LUO for the existing mechanism
> which is also a required feature.
> 
> Signed-off-by: Logan Odell <loganodell@google.com>
> Signed-off-by: Tarun Sahu <tarunsahu@google.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261026174217.603114-1-tarunsahu@google.com?part=2



  reply	other threads:[~2026-10-26 17:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 17:42 [RFC PATCH v3 0/4] liveupdate: Add feature header for fine-grained ABI compatibility Tarun Sahu
2026-10-26 17:42 ` [RFC PATCH v3 1/4] liveupdate: Remove __packed from LUO and memfd ABI structures Tarun Sahu
2026-10-26 17:53   ` sashiko-bot
2026-10-26 17:42 ` [RFC PATCH v3 2/4] liveupdate: Add feature header for fine-grained ABI compatibility Tarun Sahu
2026-10-26 17:53   ` sashiko-bot [this message]
2026-10-26 17:42 ` [RFC PATCH v3 3/4] mm: memfd_luo: Add the feature header Tarun Sahu
2026-10-26 17:53   ` sashiko-bot
2026-10-26 17:42 ` [RFC PATCH v3 4/4] liveupdate: Add KUnit test for the feature header helpers Tarun Sahu
2026-10-26 17:53   ` sashiko-bot
2026-10-26 18:58 ` [RFC PATCH v3 0/4] liveupdate: Add feature header for fine-grained ABI compatibility tarunsahu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-185599@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alex@shazbot.org \
    --cc=arnd@arndb.de \
    --cc=baolu.lu@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=dmatlack@google.com \
    --cc=dwmw2@infradead.org \
    --cc=graf@amazon.com \
    --cc=jgg@nvidia.com \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=kexec@lists.infradead.org \
    --cc=loganodell@google.com \
    --cc=maz@kernel.org \
    --cc=oupton@kernel.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=pbonzini@redhat.com \
    --cc=pratyush@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=rppt@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=seanjc@google.com \
    --cc=tarunsahu@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.