All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Giuseppe Piscitelli" <ooonea@gmail.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/PM: Serialize PMCSR updates against PME handling
Date: Mon, 26 Oct 2026 20:35:25 +0000	[thread overview]
Message-ID: <sashiko-outbox-185731@kernel.org> (raw)
In-Reply-To: <20261026202647.669817-1-ooonea@gmail.com>

> PME handling and native power transitions independently read and update
> PMCSR. Config access locking protects individual transactions, so a PME
> worker can read D0, another CPU can request D3hot, and the worker can write
> its stale D0 state back while acknowledging PME status. This was observed
> during normal runtime PM of an NVIDIA UCSI controller, followed by a
> D0-to-D3hot refusal message.
> 
> Serialize native PCI-core PMCSR writers with the existing capability
> lock, releasing it before transition delays and readiness waits.
> State-only updates write zero to the RW1C PME_Status bit to preserve
> pending wakeups. Read fresh PMCSR for each PM-reset transition instead of
> keeping a stale word across the cooldown. Keep the literal-zero power-up
> write.
> 
> Fixes: 58ff463396ad ("PCI PM: Add function for checking PME status of devices")
> Signed-off-by: Giuseppe Piscitelli <ooonea@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261026202647.669817-1-ooonea@gmail.com?part=1


      reply	other threads:[~2026-10-26 20:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 20:26 [PATCH] PCI/PM: Serialize PMCSR updates against PME handling Giuseppe Piscitelli
2026-10-26 20:35 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-185731@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=ooonea@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.