From: sashiko-bot@kernel.org
To: "Mrigendra Chaubey" <mrigendra.chaubey@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] arm64: dts: ti: k3-j722s-evm: Enable HDMI display
Date: Tue, 27 Oct 2026 04:29:10 +0000 [thread overview]
Message-ID: <sashiko-outbox-186080@kernel.org> (raw)
In-Reply-To: <20261027042231.499107-1-mrigendra.chaubey@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] arm64: dts: ti: unresolved dss1 label reference in k3-j722s-evm.dts
--
commit 91b798e074e4955950640ee6d66d8481cca226d2
Author: Jayesh Choudhary <j-choudhary@ti.com>
arm64: dts: ti: k3-j722s-evm: Enable HDMI display
This commit adds the TCA6416 I/O expander, SiI9022 HDMI bridge, HDMI
connector, and DPI pinmux to k3-j722s-evm.dts, and enables the DSS1 node
to drive HDMI output from VP0.
> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> index e66330c71593a..bcf8088c9bf07 100644
> --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
[ ... ]
> @@ -854,4 +991,39 @@ &mcu_i2c0 {
> status = "okay";
> };
>
> +&dss1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&dss1_pins_default>;
[Severity: Low]
Does this break building k3-j722s-evm.dtb when CONFIG_ARCH_K3 is enabled in
this tree?
In arch/arm64/boot/dts/ti/Makefile, k3-j722s-evm.dtb is built unconditionally
for CONFIG_ARCH_K3:
dtb-$(CONFIG_ARCH_K3) += k3-j722s-evm.dtb
Although cbass_main in arch/arm64/boot/dts/ti/k3-j722s.dtsi maps the bus
range for DSS1:
<0x00 0x30220000 0x00 0x30220000 0x00 0x00010000>, /* DSS1 */
none of the included .dtsi files (such as k3-am62p-j722s-common-main.dtsi or
k3-j722s-main.dtsi) define the dss1 node or label yet, because the
prerequisite AM62P/J722S DSS series noted in the patch commentary is not
applied in this tree. As a result, referencing &dss1 here causes dtc to fail
with an unresolved label error during a dtbs build.
Should the prerequisite patch defining the dss1 node be applied before this
change?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261027042231.499107-1-mrigendra.chaubey@gmail.com?part=1
prev parent reply other threads:[~2026-10-27 4:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 4:22 [PATCH] arm64: dts: ti: k3-j722s-evm: Enable HDMI display Mrigendra Chaubey
2026-10-27 4:29 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-186080@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=mrigendra.chaubey@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.