Re: [PATCH v4 10/16] PCI: dwc: qcom-ep: Use cached PCIe capability offset

[sashiko-bot@kernel.org]

> Replace the three dw_pcie_find_capability(pci, PCI_CAP_ID_EXP) calls in
> the qcom-ep driver with dw_pcie_get_pcie_cap().
> 
> qcom_pcie_perst_deassert() is the point where the controller resources
> have just been enabled and DBI becomes accessible, so the offset is
> looked up and cached there. Both the L0s and the L1 exit latency are
> then programmed using that same cached offset instead of walking the
> capability list again.
> 
> qcom_pcie_ep_icc_update() may run from the global IRQ handler, which is
> requested before the PERST# IRQ. The helper performs its lookup at that
> point of use, i.e. exactly where the open coded search happened before,
> so this change neither adds nor moves a DBI access and does not
> introduce a new race with the PERST# handler.
> 
> Signed-off-by: Hans Zhang <18255117159@163.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261027122827.2725643-1-18255117159@163.com?part=10