Re: [PATCH v3] usb: uas: wait for pending commands before unbinding

[sashiko-bot@kernel.org]

> USB core normally disables interface endpoints before calling
> uas_disconnect(), cancelling URBs while the device may still be
> processing the associated commands. Some storage bridges may then
> fail to recover after a driver rebind and require a disconnect and
> reconnect.
> 
> Enable soft unbinding and give already accepted commands a bounded
> grace period to complete before teardown. The disconnect sequence is:
> 
>   -> cancel pending scan work and block new requests
>   -> stop software retries for accepted commands
>   -> wait for commands that can still complete normally
>   -> set resetting and unblock requests
>   -> cancel work and URBs, then clean up remaining commands
>   -> synchronize scan work and remove the host
> 
> Commands needing a retry are left for the existing cleanup, while
> other accepted commands can still complete normally. Stop waiting
> when there are no commands left to wait for, USB core marks the device
> as not attached, or the grace period expires.
> 
> This does not abort tasks already accepted by the device. If a command
> cannot finish during the grace period, an affected bridge may still
> require a disconnect and reconnect to recover.
> 
> Signed-off-by: Jiayi Li <lijiayi@kylinos.cn>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261027131458.983241-1-lijiayi@kylinos.cn?part=1