Re: [PATCH 03/19] usbip: vudc: free the unlink item if the send fails

[sashiko-bot@kernel.org]

> From: Josef Bacik <josef@toxicpanda.com>
> 
> v_send_ret() takes an item off udc->tx_queue, hands what it carries to
> v_send_ret_submit() or v_send_ret_unlink(), and frees only the item
> itself. v_send_ret_submit() releases its urbp on all paths behind the
> first check; v_send_ret_unlink() frees the struct v_unlink only after a
> complete send. When the connection breaks while a RET_UNLINK is being
> sent, the v_unlink is leaked.
> 
> The reply has been built from it before the send: free it right after
> kernel_sendmsg().
> 
> Fixes: d62ba981a9de ("usbip: vudc: Add vudc_tx")
> Cc: stable <stable@kernel.org>
> Cc: Valentina Manea <valentina.manea.m@gmail.com>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: Hongren Zheng <i@zenithal.me>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261027-llm-usb-v1-0-b9751ddb9c7c@linuxfoundation.org?part=3