Re: [PATCH v4 2/2] arm64: dts: ti: Add support for the phyCORE-AM62Px

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] arm64: dts: ti: missing wkup_r5fss0_core0_memory_region label breaks DTB build
--

commit 0b85146939f017914b2af5c4afd5af0993cf3aad
Author: John Ma <jma@phytec.com>

arm64: dts: ti: Add support for the phyCORE-AM62Px

This commit adds device tree support for the PHYTEC phyCORE-AM62Px SoM and
the phyBOARD-Lynx carrier board.

> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-phycore-som.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-phycore-som.dtsi
> new file mode 100644
> index 0000000000000..1955ef49bc3af
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-phycore-som.dtsi
> @@ -0,0 +1,378 @@
[ ... ]
> +	reserved_memory: reserved-memory {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		/* global cma region */
> +		linux,cma {
> +			compatible = "shared-dma-pool";
> +			reusable;
> +			size = <0x00 0x24000000>;
> +			linux,cma-default;
> +		};
> +
> +		wkup_r5fss0_core0_dma_memory_region: memory@9c800000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0x00 0x9c800000 0x00 0x100000>;
> +			no-map;
> +		};
> +
> +		wkup_r5fss0_core0_ipc_region: memory@9c900000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0x00 0x9c900000 0x00 0x100000>;
> +			no-map;
> +		};
> +
> +		wkup_r5fss0_core0_lpm_fs_stub_region: memory@9ca00000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0x00 0x9ca00000 0x00 0x8000>;
> +			no-map;
> +		};
> +
> +		wkup_r5fss0_core0_lpm_metadata_region: memory@9ca08000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0x00 0x9ca08000 0x00 0x1000>;
> +			bootph-pre-ram;
> +			no-map;
> +		};
> +
> +		wkup_r5fss0_core0_lpm_rest_region: memory@9ca09000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0x00 0x9ca09000 0x00 0x97000>;
> +			no-map;
> +		};
> +
> +		wkup_r5fss0_core0_dm_region: memory@9caa0000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0x00 0x9caa0000 0x00 0x1b68000>;
> +			no-map;
> +		};
[ ... ]
> +	i2c_som_rtc: rtc@52 {
> +		compatible = "microcrystal,rv3028";
> +		reg = <0x52>;
> +	};
> +};
> +
> +#include "k3-am62p-ti-ipc-firmware.dtsi"

[Severity: Low]
Does building k3-am62p5-phyboard-lynx.dtb when CONFIG_ARCH_K3 is enabled
fail in dtc due to an unresolved reference to
wkup_r5fss0_core0_memory_region?

k3-am62p-phycore-som.dtsi includes k3-am62p-ti-ipc-firmware.dtsi, which
configures wkup_r5fss0_core0 as follows:

&wkup_r5fss0_core0 {
	mboxes = <&mailbox0_cluster0 &mbox_r5_0>;
	memory-region = <&wkup_r5fss0_core0_dma_memory_region>,
			<&wkup_r5fss0_core0_memory_region>;
	memory-region-names = "dma", "firmware";
	status = "okay";
};

However, the reserved_memory node in k3-am62p-phycore-som.dtsi defines
wkup_r5fss0_core0_ipc_region, wkup_r5fss0_core0_lpm_fs_stub_region,
wkup_r5fss0_core0_lpm_metadata_region, wkup_r5fss0_core0_lpm_rest_region,
and wkup_r5fss0_core0_dm_region instead of wkup_r5fss0_core0_memory_region,
and &wkup_r5fss0_core0's memory-region property is not overridden.

Should reserved_memory define wkup_r5fss0_core0_memory_region to match
k3-am62p-ti-ipc-firmware.dtsi?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261027193901.3538135-1-jma@phytec.com?part=2