From: sashiko-bot@kernel.org
To: "Joanne Koong" <joannelkoong@gmail.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH 4/5] iomap: pass iomap_iter_next_fn directly instead of struct iomap_ops
Date: Tue, 27 Oct 2026 22:06:46 +0000 [thread overview]
Message-ID: <sashiko-outbox-187142@kernel.org> (raw)
In-Reply-To: <20261027215326.2693300-5-joannelkoong@gmail.com>
> Now that all filesystems implement ->iomap_next() and the legacy
> ->iomap_begin()/->iomap_end() fallback is gone, struct iomap_ops only
> wraps a single iomap_next function pointer. Drop the struct entirely and
> pass the iomap_iter_next_fn directly to iomap_iter() and all the
> iomap/dax entry points. Filesystems pass their iomap_iter_next_fn
> callback directly instead of an ops struct. Several iomap_iter_next_fn
> callbacks become non-static and gain header declarations since callers
> now reference them directly.
>
> The iomap_iter tracepoint's ops field is renamed to next to match. These
> tracepoints are explicitly not stable ABI (see the note in iomap/trace.h).
>
> No functional change intended other than the tracepoint field rename
> noted above.
>
> Acked-by: Jan Kara <jack@suse.cz>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261027215326.2693300-1-joannelkoong@gmail.com?part=4
next prev parent reply other threads:[~2026-10-27 22:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 21:53 [PATCH 0/5] iomap: remaining patches for iomap_iter_next conversion Joanne Koong
2026-10-27 21:53 ` [PATCH 1/5] nilfs2: convert iomap ops to ->iomap_next() Joanne Koong
2026-10-27 22:03 ` sashiko-bot
2026-10-28 15:00 ` Christoph Hellwig
2026-10-28 16:17 ` Ryusuke Konishi
2026-10-27 21:53 ` [PATCH 2/5] fuse: convert ext_map " Joanne Koong
2026-10-27 22:02 ` sashiko-bot
2026-10-28 15:01 ` Christoph Hellwig
2026-10-27 21:53 ` [PATCH 3/5] iomap: remove ->iomap_begin()/->iomap_end() legacy path Joanne Koong
2026-10-27 22:04 ` sashiko-bot
2026-10-27 21:53 ` [PATCH 4/5] iomap: pass iomap_iter_next_fn directly instead of struct iomap_ops Joanne Koong
2026-10-27 22:06 ` sashiko-bot [this message]
2026-10-27 21:53 ` [PATCH 5/5] Documentation: iomap: update docs to reflect iomap_iter_next model Joanne Koong
2026-10-27 22:07 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-187142@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=joannelkoong@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.