From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-s390@vger.kernel.org, "Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH v2 8/9] drm/amdkfd: Free queue in procfs_queue_type kobject release callback
Date: Tue, 27 Oct 2026 22:45:16 +0000 [thread overview]
Message-ID: <sashiko-outbox-187175@kernel.org> (raw)
In-Reply-To: <20261027223847.652884-9-irogers@google.com>
> struct queue embeds a struct kobject (q->kobj) for procfs entries, but
> procfs_queue_type had no .release callback and uninit_queue() freed q
> immediately after kfd_procfs_del_queue() called kobject_put(&q->kobj).
> With CONFIG_DEBUG_KOBJECT_RELEASE=y, this causes a use-after-free.
>
> Add kfd_procfs_queue_release() to free struct queue from the kobject
> release callback, change kfd_procfs_del_queue() to only remove the
> kobject from sysfs via kobject_del(), and drop the final reference in
> uninit_queue() via kobject_put(). Check q->kobj.state_in_sysfs before
> calling kobject_del() in kfd_procfs_del_queue() to avoid warnings if
> sysfs creation previously failed.
>
> Fixes: 6d220a7e7971 ("drm/amdkfd: Add queue information to sysfs")
> Signed-off-by: Ian Rogers <irogers@google.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261027223847.652884-1-irogers@google.com?part=8
next prev parent reply other threads:[~2026-10-27 22:45 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 22:38 [PATCH v2 0/9] Add __must_init and require explicit kobj_type::release Ian Rogers
2026-10-27 22:38 ` Ian Rogers
2026-10-27 22:38 ` [PATCH v2 1/9] Compiler Attributes: Add __must_init macro Ian Rogers
2026-10-27 22:38 ` Ian Rogers
2026-10-27 22:43 ` sashiko-bot
2026-10-28 18:56 ` Kees Cook
2026-10-28 18:56 ` Kees Cook
2026-10-28 19:02 ` Nathan Chancellor
2026-10-28 19:02 ` Nathan Chancellor
2026-10-27 22:38 ` [PATCH v2 2/9] powerpc/secvar: Add missing kobject release callback to secvar_ktype Ian Rogers
2026-10-27 22:38 ` Ian Rogers
2026-10-27 22:42 ` sashiko-bot
2026-10-27 22:38 ` [PATCH v2 3/9] sh: sq: Add missing kobject release callback to ktype_percpu_entry Ian Rogers
2026-10-27 22:38 ` Ian Rogers
2026-10-27 22:46 ` sashiko-bot
2026-10-27 22:38 ` [PATCH v2 4/9] cpufreq: governor: Initialize kobj_type release callback statically Ian Rogers
2026-10-27 22:38 ` Ian Rogers
2026-10-27 22:43 ` sashiko-bot
2026-10-28 3:36 ` Zhongqiu Han
2026-10-28 3:36 ` Zhongqiu Han
2026-10-28 11:38 ` Rafael J. Wysocki (Intel)
2026-10-28 11:38 ` Rafael J. Wysocki (Intel)
2026-10-28 15:35 ` Ian Rogers
2026-10-28 15:35 ` Ian Rogers
2026-10-28 15:39 ` Rafael J. Wysocki (Intel)
2026-10-28 15:39 ` Rafael J. Wysocki (Intel)
2026-10-27 22:38 ` [PATCH v2 5/9] dlm: Free dlm_ls in kobject release callback Ian Rogers
2026-10-27 22:38 ` Ian Rogers
2026-10-27 22:45 ` sashiko-bot
2026-10-27 22:38 ` [PATCH v2 6/9] xen/sys-hypervisor: Add release callback to hyp_sysfs_kobj_type Ian Rogers
2026-10-27 22:38 ` Ian Rogers
2026-10-27 22:42 ` sashiko-bot
2026-10-27 22:38 ` [PATCH v2 7/9] ubifs: sysfs: Use kset_create_and_add() for ubifs_kset Ian Rogers
2026-10-27 22:38 ` Ian Rogers
2026-10-27 22:42 ` sashiko-bot
2026-10-27 22:38 ` [PATCH v2 8/9] drm/amdkfd: Free queue in procfs_queue_type kobject release callback Ian Rogers
2026-10-27 22:38 ` Ian Rogers
2026-10-27 22:45 ` sashiko-bot [this message]
2026-10-27 23:15 ` Felix Kuehling
2026-10-27 23:15 ` Felix Kuehling
2026-10-27 22:38 ` [PATCH v2 9/9] kobject: Require explicit initialization of struct kobj_type::release Ian Rogers
2026-10-27 22:38 ` [f2fs-dev] " Ian Rogers via Linux-f2fs-devel
2026-10-27 22:38 ` Ian Rogers
2026-10-27 22:56 ` sashiko-bot
2026-10-27 22:56 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-187175@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=irogers@google.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.