Re: [PATCH v6 05/11] phy: qualcomm: qmp-combo: Add hardware-specific dp_aux_cfg2 and dp_phy_cfg1 fields

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] phy: qcom-qmp-combo: missing dp_aux_cfg2 and dp_phy_cfg1 in nord_usb3dpphy_cfg
--

commit e183e9431641d2a7db9131517f22725ae7d0ce96
Author: Ritesh Kumar <ritesh.kumar@oss.qualcomm.com>

phy: qualcomm: qmp-combo: Add hardware-specific dp_aux_cfg2 and dp_phy_cfg1 fields

This commit adds dp_aux_cfg2 and dp_phy_cfg1 fields to struct qmp_phy_cfg
and populates them with hardware-version-specific constants across existing
DP PHY configurations.

> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
> index 062ee4397171e..2a4cc45d6daa1 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c

[ ... ]

> @@ -3431,7 +3465,8 @@ static const struct qmp_phy_cfg glymur_usb3dpphy_cfg = {
>  	.configure_dp_tx	= qmp_v4_configure_dp_tx,
>  	.configure_dp_clocks	= qmp_v8_configure_dp_clocks,
>  	.configure_dp_phy	= qmp_v8_configure_dp_phy,
> -
> +	.dp_aux_cfg2		= QSERDES_DP_PHY_AUX_CFG2_V8,
> +	.dp_phy_cfg1		= QSERDES_DP_PHY_CFG1_V8,
>  	.dp_mode_ignore_reverse	= true,
>  
>  	.regs			= qmp_v8_n3_usb43dpphy_regs_layout,

[Severity: High]
Should nord_usb3dpphy_cfg right below glymur_usb3dpphy_cfg also set
dp_aux_cfg2 and dp_phy_cfg1?

Like the other V6 configurations, nord_usb3dpphy_cfg uses qmp_v4_configure_dp_phy:

static const struct qmp_phy_cfg nord_usb3dpphy_cfg = {
	...
	.dp_aux_init		= qmp_v4_dp_aux_init,
	.configure_dp_tx	= qmp_v4_configure_dp_tx,
	.configure_dp_clocks	= qmp_v3_configure_dp_clocks,
	.configure_dp_phy	= qmp_v4_configure_dp_phy,

	.regs			= qmp_v6_usb3phy_regs_layout,
	...
};

In the subsequent commit ("phy: qualcomm: qmp-combo: Extract common DP PHY
init sequence"), qmp_v4_configure_dp_phy() is updated to call
qmp_combo_configure_dp_phy_common(), which rejects a zero dp_aux_cfg2 with
-EINVAL, and ("phy: qualcomm: qmp-combo: Fix error propagation in
qmp_combo_dp_power_on()") propagates that error during DisplayPort power-on:

qmp_combo_dp_power_on()
  -> qmp_v4_configure_dp_phy()
    -> qmp_combo_configure_dp_phy_common()
         if (!cfg->dp_aux_cfg2)
                 return -EINVAL;

Without QSERDES_DP_PHY_AUX_CFG2_V456 and QSERDES_DP_PHY_CFG1_V456 populated
in nord_usb3dpphy_cfg, will DisplayPort initialization unconditionally fail
on Nord platforms?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261028-glymur-phy-v3-v6-0-1f1d2e565a66@oss.qualcomm.com?part=5

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy