Re: [PATCH 3/5] drm/imagination: Update RISC-V firmware header

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] drm/imagination: leftover pvr_rogue_riscv_internal.h after header rename
--

commit eeabb2d4154441b38cbf731b40c5f4e3c830252e
Author: Alessio Belle <alessio.belle@imgtec.com>

drm/imagination: Update RISC-V firmware header

This commit introduces pvr_fw_riscv_internal.h with arch-independent
definitions and updates pvr_fw_riscv.c to include it in place of
pvr_rogue_riscv_internal.h.

> diff --git a/drivers/gpu/drm/imagination/pvr_fw_riscv.c b/drivers/gpu/drm/imagination/pvr_fw_riscv.c
> index 0d4dd45520a9c..2b24c40bc20f9 100644
> --- a/drivers/gpu/drm/imagination/pvr_fw_riscv.c
> +++ b/drivers/gpu/drm/imagination/pvr_fw_riscv.c
> @@ -6,10 +6,10 @@
>  #include "pvr_fw_info.h"
>  #include "pvr_fw_mips.h"
>  #include "pvr_gem.h"
> +#define PVR_FW_RISCV_INTERNAL_H_EXPLICIT_INCLUDE
> +#include "pvr_fw_riscv_internal.h"
> +#undef PVR_FW_RISCV_INTERNAL_H_EXPLICIT_INCLUDE
>  #include "pvr_rogue_cr_defs.h"
> -#define PVR_ROGUE_RISCV_INTERNAL_H_EXPLICIT_INCLUDE
> -#include "pvr_rogue_riscv_internal.h"
> -#undef PVR_ROGUE_RISCV_INTERNAL_H_EXPLICIT_INCLUDE
>  #include "pvr_vm.h"

[ ... ]

> diff --git a/drivers/gpu/drm/imagination/pvr_fw_riscv_internal.h b/drivers/gpu/drm/imagination/pvr_fw_riscv_internal.h
> new file mode 100644
> index 0000000000000..abcbb4ef06fe1
> --- /dev/null
> +++ b/drivers/gpu/drm/imagination/pvr_fw_riscv_internal.h
> @@ -0,0 +1,43 @@
> +/* SPDX-License-Identifier: GPL-2.0 OR MIT */
> +/* Copyright (c) 2024 Imagination Technologies Ltd. */
> +
> +#ifndef PVR_FW_RISCV_INTERNAL_H
> +#define PVR_FW_RISCV_INTERNAL_H

[Severity: Low]
The commit message notes that the header file is being renamed to
pvr_fw_riscv_internal.h, and drivers/gpu/drm/imagination/pvr_fw_riscv.c
(the only user of pvr_rogue_riscv_internal.h) is updated to include the new
header instead.

However, drivers/gpu/drm/imagination/pvr_fw_riscv_internal.h is added as a
new file while drivers/gpu/drm/imagination/pvr_rogue_riscv_internal.h is
left in the tree (and is not removed by subsequent patches in the series,
commits 00700f5214fc and 350cb613ac62).

Should drivers/gpu/drm/imagination/pvr_rogue_riscv_internal.h be deleted as
part of this rename so it is not left behind as unused code?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261028-prep-meta-fw-arch-independent-v1-0-73e116f02172@imgtec.com?part=3