From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793201367; b=Qv/r3mGuY8fd9iuqjJd11PDv4eGux7xs9hBWy4i3UmfAVc0EaFYIYw6f1q3qpRiUIs9V zQGJxdCDwz0wy50u0xCdMBS1ja1ilPM8cX1SKBRhpNVT7Tfp0NJdtfrJs/7gtB2WgZz1d v1Yiqw/HpnRZrtCjDBLGLS6cy0latzIh+QZuKdGHH+MlO76YwomfbnHYlPjke97YNp6YZ aloAOMj3d3ZFqtEZDCo0Mhiihk/esCXXHwB2u7broZeFYV9+eYKZVbvVNH8kL0rMNnE0l hMBt5N6A/mAeCM58wcCzlEFIxF4v8hpqoDDJE0U9e26WEQVKyYwLOaSRb3bGut337WQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793201367; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=hgvCM9V7TaLd2jb0CYmQlKZURS/+sTIaKdo5XUJ8X48=; b=3QzhT+bs8ywBJz8j0kgWy5H5hF9H54flQhS9dWaQ6xgoV20hlUlXVoN8hIzP0n2p5R+U sZJ7Uip1wlTAO7OM7lFaH0Xyb0jf/gsVSV80MV4k6A1Bb7mmHFFkroyoQ2yuSQ0KUltii BFnOmHNkGV0I3oPsX11U2Pfa77rxPLe5lLeHU+BKa3U1SJhGCTwmb/knf4jrDUOOus9nS POKOsDxKX5KTT9akaw8OIX9cbR+ww7g6vOY7Nbvyu/8cgP1R9deYVahiY/bLxoxW02zh9 nQFMMjBRpnQuPmjQ+DHOi9ZTGs+xRhtckN3w+veZpiQQlFl9iC/j3AjE4VC9UHBYrAQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=HTM4YCYk; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D03F606A31A for ; Wed, 28 Oct 2026 15:29:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=HTM4YCYk Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2E8D1F01825; Wed, 28 Oct 2026 15:29:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793201367; bh=hgvCM9V7TaLd2jb0CYmQlKZURS/+sTIaKdo5XUJ8X48=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=HTM4YCYk4X24n86MrFtav6/bhaqv9qZMikQmZcrIxNVWsUnGf1j3KEcsDAFOiDRUj oU2+6LU3zC8aUGgXcm+A8LIAxr3FUBXQnS4CYeygLf3CfqRieI33RCPGGeojNw3SWM 08d0SjqXYo2nk/W9mOsW8qmR0bzgf/9OgGOPCtVcTLazGIFAYUZfoKaFD7+VTvoe68 RPEAhIyHkFc3NIKBU8uruyLJzky//LSODAZ3uDbLqJdmsvZvj6Okw2xBODcWBkaiwn Wuu2Y5e5fROjJlMGSkhsh+sh+avXFSJOWLW1YNorw+oxVGN+lwX3OSnotbWIjjTrCX eg3j6c5vdVhMg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v23 11/15] media: qcom: camss: tpg: Add support for v2.4.0 TPG Reply-To: sashiko-reviews@lists.linux.dev To: "Hangxiang Ma" Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, media-ci@linuxtv.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261028-kaanapali-camss-v23-11-95f250b18612@oss.qualcomm.com> References: <20261028-kaanapali-camss-v23-0-95f250b18612@oss.qualcomm.com> <20261028-kaanapali-camss-v23-11-95f250b18612@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 28 Oct 2026 15:29:26 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] media: qcom: camss: uninitialized hw_version check in tpg_reset() -- commit f50ae6ce8455f618cec0228f4b565ad64a56769a Author: Hangxiang Ma media: qcom: camss: tpg: Add support for v2.4.0 TPG This commit adds support for the v2.4.0 TPG hardware found on Kaanapali, routing TPG output through the CSI2 TPG mux in CSID 1080 RX and handling test-enable and reset via TPG_CTRL_CMD. > diff --git a/drivers/media/platform/qcom/camss/camss-tpg-gen1.c b/drivers= /media/platform/qcom/camss/camss-tpg-gen1.c > index d29de5f93c18e..cabbb2638cf38 100644 > --- a/drivers/media/platform/qcom/camss/camss-tpg-gen1.c > +++ b/drivers/media/platform/qcom/camss/camss-tpg-gen1.c [ ... ] > @@ -164,18 +167,26 @@ static int tpg_stream_on(struct tpg_device *tpg) [ ... ] > static int tpg_reset(struct tpg_device *tpg) > { > - writel(0, tpg->base + TPG_CTRL); > - writel(1, tpg->base + TPG_CLEAR); > + if (tpg->hw_version < TPG_HW_VER_2_4_0) > + writel(0, tpg->base + TPG_CTRL); > + > + writel(TPG_CTRL_CMD_HW_RESET, tpg->base + TPG_CTRL_CMD); > =20 > return 0; > } [Severity: Medium] Is tpg->hw_version initialized when tpg_reset() runs for the first time? In drivers/media/platform/qcom/camss/camss-tpg.c, tpg_set_power() calls reset() before hw_version(): drivers/media/platform/qcom/camss/camss-tpg.c:tpg_set_power() { if (on) { ... tpg->res->hw_ops->reset(tpg); tpg->res->hw_ops->hw_version(tpg); } } Since tpg_hw_version() in drivers/media/platform/qcom/camss/camss-tpg-gen1.c is where tpg->hw_version is populated from the TPG_HW_VERSION register, tpg->hw_version is still 0 on the initial power-on. Won't this cause tpg_reset() to evaluate 0 < TPG_HW_VER_2_4_0 as true and write 0 to TPG_CTRL even on v2.4.0 hardware? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261028-kaanapali-= camss-v23-0-95f250b18612@oss.qualcomm.com?part=3D11 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED593606A31C for ; Wed, 28 Oct 2026 15:29:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=aacnvrpH; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=HTM4YCYk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=TwZUKmYMk8yvVVlq923CKN41wH/dT+zp63dgiPkdqnQ=; b=aacnvrpHhu36+AggGK8vYddLPj QdgRUh4RkkQgE6KpCjV7N1p5UfdZeq539KM4ZT5xQtHe3xHcRHCM14hKZVeeAWhHc4KXw5g/THAoq zr80eoy7AzvzR4TCpPGJTIdEB718VjoFJqCmHz19qcwNz/Jn07zMlkcm177XN9QF3XVXUKIceLcgp RMU9DgwSYqH/g1OjdlE7CyEoAsZhoPyNk0Y72zBb1A9K71wiV5HwXh9MN6DXvvMkwHbDIPEqiWvl0 51pV31mLOAAtEgNEJw7InVRWZw+MM/9uNJzL11ln6DcVvf8Yk3w0u03s6hZvyGI79dd17dnsyl+r0 vgSiU1Ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xM5aj-00000007O7i-2ogB; Wed, 28 Oct 2026 15:29:29 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xM5ai-00000007O5p-07ec for linux-phy@lists.infradead.org; Wed, 28 Oct 2026 15:29:28 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 45484433E7; Wed, 28 Oct 2026 15:29:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2E8D1F01825; Wed, 28 Oct 2026 15:29:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793201367; bh=hgvCM9V7TaLd2jb0CYmQlKZURS/+sTIaKdo5XUJ8X48=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=HTM4YCYk4X24n86MrFtav6/bhaqv9qZMikQmZcrIxNVWsUnGf1j3KEcsDAFOiDRUj oU2+6LU3zC8aUGgXcm+A8LIAxr3FUBXQnS4CYeygLf3CfqRieI33RCPGGeojNw3SWM 08d0SjqXYo2nk/W9mOsW8qmR0bzgf/9OgGOPCtVcTLazGIFAYUZfoKaFD7+VTvoe68 RPEAhIyHkFc3NIKBU8uruyLJzky//LSODAZ3uDbLqJdmsvZvj6Okw2xBODcWBkaiwn Wuu2Y5e5fROjJlMGSkhsh+sh+avXFSJOWLW1YNorw+oxVGN+lwX3OSnotbWIjjTrCX eg3j6c5vdVhMg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v23 11/15] media: qcom: camss: tpg: Add support for v2.4.0 TPG To: "Hangxiang Ma" Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, media-ci@linuxtv.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261028-kaanapali-camss-v23-11-95f250b18612@oss.qualcomm.com> References: <20261028-kaanapali-camss-v23-0-95f250b18612@oss.qualcomm.com> <20261028-kaanapali-camss-v23-11-95f250b18612@oss.qualcomm.com> Date: Wed, 28 Oct 2026 15:29:26 +0000 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gbWVkaWE6IHFjb206 IGNhbXNzOiB1bmluaXRpYWxpemVkIGh3X3ZlcnNpb24gY2hlY2sgaW4gdHBnX3Jlc2V0KCkKLS0K CmNvbW1pdCBmNTBhZTZjZTg0NTVmNjE4Y2VjMDIyOGY0YjU2NWFkNjRhNTY3NjlhCkF1dGhvcjog SGFuZ3hpYW5nIE1hIDxoYW5neGlhbmcubWFAb3NzLnF1YWxjb21tLmNvbT4KCm1lZGlhOiBxY29t OiBjYW1zczogdHBnOiBBZGQgc3VwcG9ydCBmb3IgdjIuNC4wIFRQRwoKVGhpcyBjb21taXQgYWRk cyBzdXBwb3J0IGZvciB0aGUgdjIuNC4wIFRQRyBoYXJkd2FyZSBmb3VuZCBvbiBLYWFuYXBhbGks CnJvdXRpbmcgVFBHIG91dHB1dCB0aHJvdWdoIHRoZSBDU0kyIFRQRyBtdXggaW4gQ1NJRCAxMDgw IFJYIGFuZCBoYW5kbGluZwp0ZXN0LWVuYWJsZSBhbmQgcmVzZXQgdmlhIFRQR19DVFJMX0NNRC4K Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vcWNvbS9jYW1zcy9jYW1zcy10 cGctZ2VuMS5jIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9xY29tL2NhbXNzL2NhbXNzLXRwZy1n ZW4xLmMKPiBpbmRleCBkMjlkZTVmOTNjMThlLi5jYWJiYjI2MzhjZjM4IDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vcWNvbS9jYW1zcy9jYW1zcy10cGctZ2VuMS5jCj4gKysr IGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9xY29tL2NhbXNzL2NhbXNzLXRwZy1nZW4xLmMKClsg Li4uIF0KCj4gQEAgLTE2NCwxOCArMTY3LDI2IEBAIHN0YXRpYyBpbnQgdHBnX3N0cmVhbV9vbihz dHJ1Y3QgdHBnX2RldmljZSAqdHBnKQoKWyAuLi4gXQoKPiAgc3RhdGljIGludCB0cGdfcmVzZXQo c3RydWN0IHRwZ19kZXZpY2UgKnRwZykKPiAgewo+IC0Jd3JpdGVsKDAsIHRwZy0+YmFzZSArIFRQ R19DVFJMKTsKPiAtCXdyaXRlbCgxLCB0cGctPmJhc2UgKyBUUEdfQ0xFQVIpOwo+ICsJaWYgKHRw Zy0+aHdfdmVyc2lvbiA8IFRQR19IV19WRVJfMl80XzApCj4gKwkJd3JpdGVsKDAsIHRwZy0+YmFz ZSArIFRQR19DVFJMKTsKPiArCj4gKwl3cml0ZWwoVFBHX0NUUkxfQ01EX0hXX1JFU0VULCB0cGct PmJhc2UgKyBUUEdfQ1RSTF9DTUQpOwo+ICAKPiAgCXJldHVybiAwOwo+ICB9CgpbU2V2ZXJpdHk6 IE1lZGl1bV0KSXMgdHBnLT5od192ZXJzaW9uIGluaXRpYWxpemVkIHdoZW4gdHBnX3Jlc2V0KCkg cnVucyBmb3IgdGhlIGZpcnN0IHRpbWU/CgpJbiBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3Fjb20v Y2Ftc3MvY2Ftc3MtdHBnLmMsIHRwZ19zZXRfcG93ZXIoKSBjYWxscwpyZXNldCgpIGJlZm9yZSBo d192ZXJzaW9uKCk6Cgpkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3Fjb20vY2Ftc3MvY2Ftc3MtdHBn LmM6dHBnX3NldF9wb3dlcigpIHsKCWlmIChvbikgewoJCS4uLgoJCXRwZy0+cmVzLT5od19vcHMt PnJlc2V0KHRwZyk7CgoJCXRwZy0+cmVzLT5od19vcHMtPmh3X3ZlcnNpb24odHBnKTsKCX0KfQoK U2luY2UgdHBnX2h3X3ZlcnNpb24oKSBpbiBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3Fjb20vY2Ft c3MvY2Ftc3MtdHBnLWdlbjEuYwppcyB3aGVyZSB0cGctPmh3X3ZlcnNpb24gaXMgcG9wdWxhdGVk IGZyb20gdGhlIFRQR19IV19WRVJTSU9OIHJlZ2lzdGVyLAp0cGctPmh3X3ZlcnNpb24gaXMgc3Rp bGwgMCBvbiB0aGUgaW5pdGlhbCBwb3dlci1vbi4gV29uJ3QgdGhpcyBjYXVzZQp0cGdfcmVzZXQo KSB0byBldmFsdWF0ZSAwIDwgVFBHX0hXX1ZFUl8yXzRfMCBhcyB0cnVlIGFuZCB3cml0ZSAwIHRv IFRQR19DVFJMCmV2ZW4gb24gdjIuNC4wIGhhcmR3YXJlPwoKLS0gClNhc2hpa28gQUkgcmV2aWV3 IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MTAyOC1rYWFuYXBhbGktY2Ft c3MtdjIzLTAtOTVmMjUwYjE4NjEyQG9zcy5xdWFsY29tbS5jb20/cGFydD0xMQoKLS0gCmxpbnV4 LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcGh5Cg==