From: sashiko-bot@kernel.org
To: "Danish Khateeb" <danishkhateeb03@gmail.com>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH v3 2/2] leds: tca6507: Turn the LEDs off on unbind
Date: Wed, 28 Oct 2026 17:51:42 +0000 [thread overview]
Message-ID: <sashiko-outbox-188257@kernel.org> (raw)
In-Reply-To: <20261028174348.64014-3-danishkhateeb03@gmail.com>
> Unregistering an LED that is on turns it off, and the driver does that
> from its work, which is queued from led_assign(). On unbind the work is
> then cancelled by devres, so if it has not run yet the LED stays on after
> the driver is gone.
>
> Flush the work instead of cancelling it. By the time the devres action
> runs, the LEDs and the GPIO chip have been unregistered, and the work
> does not queue itself, so nothing can queue it again.
>
> Signed-off-by: Danish Khateeb <danishkhateeb03@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261028174348.64014-1-danishkhateeb03@gmail.com?part=2
prev parent reply other threads:[~2026-10-28 17:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 17:43 [PATCH v3 0/2] leds: tca6507: Fix use-after-free on unbind and turn the LEDs off Danish Khateeb
2026-10-28 17:43 ` [PATCH v3 1/2] leds: tca6507: Fix use-after-free on unbind Danish Khateeb
2026-10-28 17:47 ` sashiko-bot
2026-10-28 17:43 ` [PATCH v3 2/2] leds: tca6507: Turn the LEDs off " Danish Khateeb
2026-10-28 17:51 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-188257@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=danishkhateeb03@gmail.com \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.