From: sashiko-bot@kernel.org
To: "Gergo Koteles" <soyer@irl.hu>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: sm7325-motorola-dubai: Add vibrator support
Date: Wed, 28 Oct 2026 20:46:22 +0000 [thread overview]
Message-ID: <sashiko-outbox-188445@kernel.org> (raw)
In-Reply-To: <89f7e6e9988c8744be37093777b0bc065a0e2ab8.1793218514.git.soyer@irl.hu>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] arm64: dts: qcom: missing aw86224_reset_default in vibrator@58 pinctrl-0
--
commit 0c4fc157858ecc13c8cc7fb55e5af412993c27bd
Author: Gergo Koteles <soyer@irl.hu>
arm64: dts: qcom: sm7325-motorola-dubai: Add vibrator support
This commit adds the device tree node for the Awinic AW86224 haptic
controller on sm7325-motorola-dubai boards.
> diff --git a/arch/arm64/boot/dts/qcom/sm7325-motorola-dubai-common.dtsi b/arch/arm64/boot/dts/qcom/sm7325-motorola-dubai-common.dtsi
> index 3860ab8508a09..df2cb58e95d06 100644
> --- a/arch/arm64/boot/dts/qcom/sm7325-motorola-dubai-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm7325-motorola-dubai-common.dtsi
> @@ -721,6 +721,17 @@ fsa4480_sbu_mux: endpoint {
> };
> };
> };
> +
> + vibrator@58 {
> + compatible = "awinic,aw86224";
> + reg = <0x58>;
> +
> + interrupts-extended = <&tlmm 47 IRQ_TYPE_EDGE_FALLING>;
> + reset-gpios = <&tlmm 46 GPIO_ACTIVE_LOW>;
> +
> + pinctrl-0 = <&aw86224_int_default>;
> + pinctrl-names = "default";
[Severity: Medium]
Should pinctrl-0 in vibrator@58 also include &aw86224_reset_default?
The node consumes gpio46 via reset-gpios, and &tlmm in
arch/arm64/boot/dts/qcom/sm7325-motorola-dubai-common.dtsi defines a dedicated
pin configuration state for it:
aw86224_reset_default: aw86224-reset-default-state {
pins = "gpio46";
function = "gpio";
drive-strength = <2>;
bias-pull-down;
};
Without &aw86224_reset_default in pinctrl-0, this pinctrl node remains
unreferenced and the pinmux, drive-strength, and pull-down bias for gpio46
are not applied when the device probes.
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1793218514.git.soyer@irl.hu?part=3
next prev parent reply other threads:[~2026-10-28 20:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 20:37 [PATCH v2 0/3] AW86224 haptic driver Gergo Koteles
2026-10-28 20:37 ` [PATCH v2 1/3] dt-bindings: input: Add compatibility for Awinic AW86224 Gergo Koteles
2026-10-29 7:13 ` Krzysztof Kozlowski
2026-10-28 20:37 ` [PATCH v2 2/3] Input: aw86224 - add driver " Gergo Koteles
2026-10-28 20:37 ` [PATCH v2 3/3] arm64: dts: qcom: sm7325-motorola-dubai: Add vibrator support Gergo Koteles
2026-10-28 20:46 ` sashiko-bot [this message]
2026-10-29 8:06 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-188445@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=soyer@irl.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.