From: sashiko-bot@kernel.org
To: "Kyle Farrell" <kaf@nwlink.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: f_uac2: prevent invalid bInterval auto-selection
Date: Wed, 28 Oct 2026 22:31:47 +0000 [thread overview]
Message-ID: <sashiko-outbox-188505@kernel.org> (raw)
In-Reply-To: <20261028222800.782988-1-kaf@nwlink.com>
> When p_hs_bint or c_hs_bint is 0, the driver selects the largest
> bInterval from 4 down to 1 for which the required bandwidth fits the
> maximum packet size. The original implementation intends to keep
> bInterval at 1 when required bandwidth exceeds the single-packet maximum,
> but the search loop instead decrements bInterval to 0 in that case.
>
> A bInterval of 0 is invalid for an isochronous endpoint. A Linux host
> reports it and substitutes a default:
>
> usb 3-8: ... endpoint 0x1 has an invalid bInterval 0, changing to 7
>
> Stop the search at bInterval=1. Maintain existing clamping of
> wMaxPacketSize and warning about possible data loss when the required
> bandwidth cannot be accommodated.
>
> Fixes: 355a05dc8367 ("usb: gadget: f_uac2: Optionally determine bInterval for HS and SS")
> Signed-off-by: Kyle Farrell <kaf@nwlink.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261028222800.782988-1-kaf@nwlink.com?part=1
prev parent reply other threads:[~2026-10-28 22:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 22:28 [PATCH] usb: gadget: f_uac2: prevent invalid bInterval auto-selection Kyle Farrell
2026-10-28 22:31 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-188505@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=kaf@nwlink.com \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.