From: sashiko-bot@kernel.org
To: "Hungyu Lin" <dennylin0707@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: n_tty: convert the full VTIME interval to jiffies
Date: Thu, 29 Oct 2026 00:24:20 +0000 [thread overview]
Message-ID: <sashiko-outbox-188567@kernel.org> (raw)
In-Reply-To: <20261029002052.54117-1-dennylin0707@gmail.com>
> VTIME specifies a timeout in tenths of a second, but n_tty_read() divides
> HZ by 10 before multiplying by VTIME. For supported HZ values that are
> not divisible by 10, this truncates each decisecond and shortens the
> requested interval. For example, HZ=128 and VTIME=40 produce 480 ticks
> instead of 512 ticks for four seconds.
>
> Convert the full interval to milliseconds before calling
> msecs_to_jiffies(), for both the read and inter-byte timeouts. This
> preserves zero VTIME and avoids accumulating the initial division's
> rounding loss.
>
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261029002052.54117-1-dennylin0707@gmail.com?part=1
next prev parent reply other threads:[~2026-10-29 0:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 0:20 [PATCH] tty: n_tty: convert the full VTIME interval to jiffies Hungyu Lin
2026-10-29 0:24 ` sashiko-bot [this message]
2026-10-29 6:23 ` Greg KH
2026-10-29 6:38 ` Hungyu Lin
2026-10-29 7:04 ` Greg KH
2026-10-29 7:52 ` Hungyu Lin
2026-10-29 8:09 ` Greg KH
2026-10-29 8:17 ` Hungyu Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-188567@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dennylin0707@gmail.com \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.