Re: [PATCH v2 1/2] PCI: dw-rockchip: Power on devices below the RC using pwrctrl

[sashiko-bot@kernel.org]

> Devices below the Rockchip PCIe host controller may need resources
> (regulators, clocks) enabled before they can be detected on the bus. So
> far the driver only enabled a single vpcie3v3 supply described by the
> controller node itself, which cannot express per-device or per-slot
> supplies.
> 
> Use the PCI pwrctrl framework: before initializing the PHY, create the
> pwrctrl devices for the DT nodes below the controller and power them on.
> The supplies of the slot must be up before PHY init, so this has to run
> ahead of rockchip_pcie_phy_init().
> 
> The controller node supply is kept for backward compatibility: boards
> that still describe vpcie3v3 on the controller keep working, and boards
> that move the supply into a child node get it enabled by pwrctrl.
> 
> Only the RC mode is affected, the endpoint does not own the supplies of
> the devices below it.
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261029024006.3483210-1-shawn.lin@rock-chips.com?part=1