Re: [PATCH] 9p: optimize p9_fcall struct

[sashiko-bot@kernel.org]

> p9_fcall has a 1 byte hole followed by more data and then a single byte
> element:
> 
> struct p9_fcall {
> 	u32                        size;                 /*     0     4 */
> 	u8                         id;                   /*     4     1 */
> 
> 	/* XXX 1 byte hole, try to pack */
> 
> 	u16                        tag;                  /*     6     2 */
> 	size_t                     offset;               /*     8     8 */
> 	size_t                     capacity;             /*    16     8 */
> 	struct kmem_cache *        cache;                /*    24     8 */
> 	u8 *                       sdata;                /*    32     8 */
> 	bool                       zc;                   /*    40     1 */
> [ ... ]
> 
> This in turn also makes p9_req_t 16 bytes smaller (152 -> 136) as it
> contains two of these.
> 
> Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261029060014.3-1-asmadeus@codewreck.org?part=1