From: sashiko-bot@kernel.org
To: "Karl Mehltretter" <kmehltretter@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH 5.10.y] serial: tegra: Add missing clk_disable_unprepare() in tegra_uart_hw_init()
Date: Thu, 29 Oct 2026 06:18:17 +0000 [thread overview]
Message-ID: <sashiko-outbox-188804@kernel.org> (raw)
In-Reply-To: <20261029061427.27973-1-kmehltretter@gmail.com>
> From: Yi Yang <yiyang13@huawei.com>
>
> commit 38f28cfe9d08e3a47ef008798b275fef8118fc20 upstream.
>
> Add the missing clk_disable_unprepare() before return from
> tegra_uart_hw_init() in the error handling path.
> When request_irq() fails in tegra_uart_startup(), 'tup->uart_clk'
> has been enabled, fix it by adding clk_disable_unprepare().
>
> Fixes: cc9ca4d95846 ("serial: tegra: Only print FIFO error message when an error occurs")
> Fixes: d781ec21bae6 ("serial: tegra: report clk rate errors")
> Signed-off-by: Yi Yang <yiyang13@huawei.com>
> Link: https://lore.kernel.org/r/20221126020852.113378-1-yiyang13@huawei.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261029061427.27973-1-kmehltretter@gmail.com?part=1
next prev parent reply other threads:[~2026-10-29 6:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 6:14 [PATCH 5.10.y] serial: tegra: Add missing clk_disable_unprepare() in tegra_uart_hw_init() Karl Mehltretter
2026-10-29 6:18 ` sashiko-bot [this message]
2026-10-29 18:43 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-188804@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=kmehltretter@gmail.com \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.