Re: [PATCH v2 3/5] drm/imagination: Make the RISC-V firmware header arch-independent

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] drm/imagination: leftover pvr_rogue_riscv_internal.h after header rename
--

commit aa862385062c21d7cdb9dd94ddf176fd3c9475ba
Author: Alessio Belle <alessio.belle@imgtec.com>

drm/imagination: Make the RISC-V firmware header arch-independent

This commit introduces drivers/gpu/drm/imagination/pvr_fw_riscv_internal.h
with architecture-independent PVR_RISCV* definitions and updates
drivers/gpu/drm/imagination/pvr_fw_riscv.c to use them instead of the
ROGUE_RISCV* definitions from pvr_rogue_riscv_internal.h.

> diff --git a/drivers/gpu/drm/imagination/pvr_fw_riscv.c b/drivers/gpu/drm/imagination/pvr_fw_riscv.c
> index 0d4dd45520a9c..2b24c40bc20f9 100644
> --- a/drivers/gpu/drm/imagination/pvr_fw_riscv.c
> +++ b/drivers/gpu/drm/imagination/pvr_fw_riscv.c
> @@ -6,10 +6,10 @@
>  #include "pvr_fw_info.h"
>  #include "pvr_fw_mips.h"
>  #include "pvr_gem.h"
> +#define PVR_FW_RISCV_INTERNAL_H_EXPLICIT_INCLUDE
> +#include "pvr_fw_riscv_internal.h"
> +#undef PVR_FW_RISCV_INTERNAL_H_EXPLICIT_INCLUDE
>  #include "pvr_rogue_cr_defs.h"
> -#define PVR_ROGUE_RISCV_INTERNAL_H_EXPLICIT_INCLUDE
> -#include "pvr_rogue_riscv_internal.h"
> -#undef PVR_ROGUE_RISCV_INTERNAL_H_EXPLICIT_INCLUDE
>  #include "pvr_vm.h"

[ ... ]

> diff --git a/drivers/gpu/drm/imagination/pvr_fw_riscv_internal.h b/drivers/gpu/drm/imagination/pvr_fw_riscv_internal.h
> new file mode 100644
> index 0000000000000..abcbb4ef06fe1
> --- /dev/null
> +++ b/drivers/gpu/drm/imagination/pvr_fw_riscv_internal.h
> @@ -0,0 +1,43 @@
> +/* SPDX-License-Identifier: GPL-2.0 OR MIT */
> +/* Copyright (c) 2024 Imagination Technologies Ltd. */
> +
> +#ifndef PVR_FW_RISCV_INTERNAL_H
> +#define PVR_FW_RISCV_INTERNAL_H

[Severity: Low]
The commit message states that this patch renames both the header file and
its contents, and drivers/gpu/drm/imagination/pvr_fw_riscv.c (the sole user
of pvr_rogue_riscv_internal.h) is updated to include
pvr_fw_riscv_internal.h instead.

However, drivers/gpu/drm/imagination/pvr_fw_riscv_internal.h is added as a
new file while drivers/gpu/drm/imagination/pvr_rogue_riscv_internal.h
(guarded by PVR_ROGUE_RISCV_INTERNAL_H) is left behind in the tree with no
remaining users.

Should drivers/gpu/drm/imagination/pvr_rogue_riscv_internal.h be removed in
this commit as part of the rename?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261029-prep-meta-fw-arch-independent-v2-0-b9f5d69b7a52@imgtec.com?part=3