From: sashiko-bot@kernel.org
To: "Sreeshankar K" <sreeshankar0910@gmail.com>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH RESEND v11 4/5] dt-bindings: cpufreq: qcom-hw: Document SM7250 cpufreq hardware
Date: Thu, 29 Oct 2026 07:11:03 +0000 [thread overview]
Message-ID: <sashiko-outbox-188839@kernel.org> (raw)
In-Reply-To: <20261029-master-v11-4-2c29e382162c@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: cpufreq: missing allOf constraints for qcom,sm7250-cpufreq-hw
--
commit 623b16fc0e86cc72b884cb60a98bee234109660b
Author: Sreeshankar K <sreeshankar0910@gmail.com>
dt-bindings: cpufreq: qcom-hw: Document SM7250 cpufreq hardware
This commit adds the qcom,sm7250-cpufreq-hw compatible string to the Qualcomm
cpufreq hardware Device Tree binding schema.
> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> index 98eb36bff1727..2dc2c265cac06 100644
> --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> @@ -29,6 +29,7 @@ properties:
> - qcom,sdm845-cpufreq-hw
> - qcom,sm6115-cpufreq-hw
> - qcom,sm6350-cpufreq-hw
> + - qcom,sm7250-cpufreq-hw
[Severity: Medium]
Should qcom,sm7250-cpufreq-hw also be added to one of the allOf conditional
blocks in Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml?
In this binding, the top-level definitions of reg, reg-names, interrupts, and
interrupt-names allow anywhere from 1 to 4 items. Every other SoC-specific
compatible string is listed in an allOf if-then block to constrain minItems
and maxItems for those properties to match the exact number of frequency
domains and interrupts on that SoC:
- if:
properties:
compatible:
contains:
enum:
- qcom,sm8150-cpufreq-hw
then:
properties:
reg:
minItems: 3
maxItems: 3
...
Without an allOf entry for qcom,sm7250-cpufreq-hw, device tree nodes matching
qcom,sm7250-cpufreq-hw will leave reg, reg-names, interrupts, and
interrupt-names unconstrained between 1 and 4 items during schema validation.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261029-master-v11-0-2c29e382162c@gmail.com?part=4
next prev parent reply other threads:[~2026-10-29 7:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 7:02 [PATCH RESEND v11 0/5] Add initial support for Qualcomm SM7250 SoC Sreeshankar K
2026-10-29 7:02 ` [PATCH RESEND v11 1/5] dt-bindings: clock: Add SM7250 global clock controller Sreeshankar K
2026-10-29 7:02 ` [PATCH RESEND v11 2/5] clk: qcom: Add Global Clock Controller (GCC) driver for SM7250 Sreeshankar K
2026-10-29 7:25 ` sashiko-bot
2026-10-29 7:03 ` [PATCH RESEND v11 3/5] dt-bindings: firmware: qcom,scm: Document SM7250 SCM Sreeshankar K
2026-10-29 7:03 ` [PATCH RESEND v11 4/5] dt-bindings: cpufreq: qcom-hw: Document SM7250 cpufreq hardware Sreeshankar K
2026-10-29 7:11 ` sashiko-bot [this message]
2026-10-29 7:03 ` [PATCH RESEND v11 5/5] arm64: dts: qcom: Add SM7250 devicetree file Sreeshankar K
2026-10-29 7:26 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-188839@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sreeshankar0910@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.